PageStorage add PageFileID existence check for multi disk deployment#2412
Merged
ti-srebot merged 2 commits intopingcap:masterfrom Jul 19, 2021
Merged
PageStorage add PageFileID existence check for multi disk deployment#2412ti-srebot merged 2 commits intopingcap:masterfrom
ti-srebot merged 2 commits intopingcap:masterfrom
Conversation
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
Contributor
Author
|
/run-all-tests |
Contributor
Author
|
@flowbehappy @lidezhu PTAL |
lidezhu
approved these changes
Jul 19, 2021
ti-srebot
approved these changes
Jul 19, 2021
Contributor
Author
|
/merge |
Collaborator
|
/run-all-tests |
Collaborator
|
cherry pick to release-5.1 in PR #2432 |
Collaborator
|
cherry pick to release-4.0 in PR #2433 |
Collaborator
|
cherry pick to release-5.0 in PR #2434 |
ti-srebot
added a commit
that referenced
this pull request
Jul 20, 2021
JaySon-Huang
added a commit
to JaySon-Huang/tiflash
that referenced
this pull request
Jul 21, 2021
JaySon-Huang
added a commit
that referenced
this pull request
Jul 21, 2021
flowbehappy
pushed a commit
that referenced
this pull request
Jul 21, 2021
* Revert "Revert skipping not consecutive sequence" This reverts commit 1cea4ef. * Add length check while running PageStorage GC (#2394) * PageStorage add PageFileID existence check for multi disk deployment (#2412) * Add query id for DT read result Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com> * Add failpoint for holding storage streams for long time Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com> * Add async metrics for oldest snapshot lifetime Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com> * Show longest snapshot lifetime on Grafana Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com> * calculating num of legacy independently Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com> * reading writable files Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com> * Add failpoint for testing skip non-continuous sequence Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com> * Stop Legacy compactor by the min persisted sequence Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com> * Fix other bugs Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com> * Make DataCompactor move GC forward when there are PageFiles with high valid rate/bytes Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com> * Split PageFile with valid pages and no valid pages Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com> * fix ut Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com> * enable fiu under release Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com> * Fix the min persisted sequence Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
JaySon-Huang
added a commit
that referenced
this pull request
Jul 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: JaySon-Huang jayson.hjs@gmail.com
What problem does this PR solve?
Issue Number: close #2413
Problem Summary: When TiFlash is deployed on multi disks, we need to check the file existence among all disks. Or we may generate some PageFiles that share the same PageFileID. While restoring from disks, we may ignore some PageFiles because of inserting them into PageFile "set".
What is changed and how it works?
DataCompactor:: migratePagesRelated changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Side effects
Release note