Skip to content

PageStorage add PageFileID existence check for multi disk deployment (#2412)#2433

Merged
JaySon-Huang merged 4 commits intopingcap:release-4.0from
ti-srebot:release-4.0-114c55c3cb1f
Jul 28, 2021
Merged

PageStorage add PageFileID existence check for multi disk deployment (#2412)#2433
JaySon-Huang merged 4 commits intopingcap:release-4.0from
ti-srebot:release-4.0-114c55c3cb1f

Conversation

@ti-srebot
Copy link
Collaborator

@ti-srebot ti-srebot commented Jul 19, 2021

cherry-pick #2412 to release-4.0
You can switch your code base to this Pull Request by using git-extras:

# In tics repo:
git pr https://github.com/pingcap/tics/pull/2433

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tics.git pr/2433:release-4.0-114c55c3cb1f

Signed-off-by: JaySon-Huang jayson.hjs@gmail.com

What problem does this PR solve?

Issue Number: close #2413

Problem Summary: When TiFlash is deployed on multi disks, we need to check the file existence among all disks. Or we may generate some PageFiles that share the same PageFileID. While restoring from disks, we may ignore some PageFiles because of inserting them into PageFile "set".

What is changed and how it works?

  • Check the file existence among all disks for DataCompactor:: migratePages
  • Add mock classes for testing

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch:

Check List

Tests

  • Unit test

Side effects

Release note

  • Fix the bug that TiFlash can not restore data under some situations when deployed on multi disks

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot added CHERRY-PICK cherry pick status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. labels Jul 19, 2021
@ti-srebot ti-srebot requested a review from flowbehappy July 19, 2021 12:02
@ti-srebot ti-srebot added this to the v4.0.14 milestone Jul 19, 2021
@JaySon-Huang JaySon-Huang changed the title PageStorage add PageFileID existence check for multi disk deployment (#2412) [DNM] PageStorage add PageFileID existence check for multi disk deployment (#2412) Jul 19, 2021
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
@JaySon-Huang
Copy link
Contributor

/run-all-tests

@JaySon-Huang JaySon-Huang changed the title [DNM] PageStorage add PageFileID existence check for multi disk deployment (#2412) PageStorage add PageFileID existence check for multi disk deployment (#2412) Jul 20, 2021
@JaySon-Huang
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot added status/LGT1 Indicates that a PR has LGTM 1. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Jul 20, 2021
@JaySon-Huang JaySon-Huang merged commit 97ae0db into pingcap:release-4.0 Jul 28, 2021
@JaySon-Huang JaySon-Huang deleted the release-4.0-114c55c3cb1f branch July 28, 2021 11:51
@zhouqiang-cl zhouqiang-cl modified the milestones: v4.0.14, v4.0.15 Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CHERRY-PICK cherry pick status/LGT1 Indicates that a PR has LGTM 1. type/bugfix This PR fixes a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants