PageStorage add PageFileID existence check for multi disk deployment (#2412)#2432
Merged
JaySon-Huang merged 4 commits intopingcap:release-5.1from Jul 21, 2021
Merged
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
Contributor
|
/run-all-tests |
lidezhu
approved these changes
Jul 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry-pick #2412 to release-5.1
You can switch your code base to this Pull Request by using git-extras:
# In tics repo: git pr https://github.com/pingcap/tics/pull/2432After apply modifications, you can push your change to this PR via:
Signed-off-by: JaySon-Huang jayson.hjs@gmail.com
What problem does this PR solve?
Issue Number: close #2413
Problem Summary: When TiFlash is deployed on multi disks, we need to check the file existence among all disks. Or we may generate some PageFiles that share the same PageFileID. While restoring from disks, we may ignore some PageFiles because of inserting them into PageFile "set".
What is changed and how it works?
DataCompactor:: migratePagesRelated changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Side effects
Release note