Fix broken page storage stress testing#2297
Merged
ti-srebot merged 4 commits intopingcap:masterfrom Jul 23, 2021
Merged
Conversation
7d1162c to
d5b6ed0
Compare
298be1c to
44ee868
Compare
756bc35 to
f680b0b
Compare
fa134bf to
77fa7f0
Compare
Contributor
Author
|
/run-all-tests |
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
fbfc1cf to
9161bdb
Compare
Contributor
Author
|
/run-all-tests |
Contributor
Author
|
/run-all-tests |
Contributor
|
LGTM |
Collaborator
jiaqizho
reviewed
Jul 23, 2021
| opt.clean_before_run = options["clean_before_run"].as<bool>(); | ||
| opt.timeout_s = options["timeout"].as<UInt32>(); | ||
| opt.read_delay_ms = options["read_delay_ms"].as<UInt32>(); | ||
| opt.num_writer_slots = options["writer_slots"].as<UInt32>(); |
Contributor
There was a problem hiding this comment.
should check num_writer_slots same as num_writers?
Contributor
Author
There was a problem hiding this comment.
No, they can be different.
The num_writer_slots is the pending number of PageFiles that PageStorage can write in parallel. The num_writers is the number of write threads that call PageStorage::write.
num_writers can be greater that num_writer_slots, but finally the throughput is limited by num_writer_slots
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
JinheLin
approved these changes
Jul 23, 2021
Collaborator
Contributor
Author
|
/merge |
Collaborator
|
/run-all-tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: related to #2296
This stress testing helped us to locate the error of #2249 and #2461
What is changed and how it works?
Depending on #2296.
PageStorage::gc(bool not_skip = false, const RateLimiterPtr & rate_limiter);instead ofPageStorage::gc(const Context& global_context, bool not_skip = false);so that @JinheLinDB::Contextwe can speed up some buildingRateLimiterBut still
page_storagerely on some libraries that are useless and slow down the compiling (kv_clienttipbfor example). I will file another PR to make it more independent. (Mainly, we need to get some global object out ofDB::Context)Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Side effects
Release note