Fix deadlock on removeExpiredSnapshots (#2461)#2567
Merged
JaySon-Huang merged 3 commits intopingcap:release-4.0from Aug 10, 2021
Merged
Fix deadlock on removeExpiredSnapshots (#2461)#2567JaySon-Huang merged 3 commits intopingcap:release-4.0from
removeExpiredSnapshots (#2461)#2567JaySon-Huang merged 3 commits intopingcap:release-4.0from
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
ee41c60 to
ec7b043
Compare
Contributor
Contributor
|
/run-all-tests |
flowbehappy
approved these changes
Aug 8, 2021
Contributor
|
/merge |
Member
|
@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Member
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: 6cb5e7b |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry-pick #2461 to release-4.0
You can switch your code base to this Pull Request by using git-extras:
# In tics repo: git pr https://github.com/pingcap/tics/pull/2567After apply modifications, you can push your change to this PR via:
Signed-off-by: JaySon-Huang jayson.hjs@gmail.com
What problem does this PR solve?
Issue Number: close #2456
Problem Summary:
Similar to issue: #2249 PR: #2277
In
removeExpiredSnapshots, it may trigger the~Snapshotunderread_write_mutexbeing locked. It causes incursive deadlock.And we will call
removeExpiredSnapshotsevery minute after #2431 that reports the oldest snapshot to Prometheus.https://github.com/pingcap/tics/blob/e9f28c717902a4b22855970752a08ceca214cd01/dbms/src/Storages/Page/mvcc/VersionSetWithDelta.h#L313-L340
What is changed and how it works?
read_write_mutex, and only release those snapshots after the lock gets releasedRelated changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Tested by the stress testing in Fix broken page storage stress testing #2297 with 4 writers, 128 readers, and failpoint
random_slow_page_storage_remove_expired_snapshotsenabledSide effects
Release note