Skip to content

cherry-pick #2431 #2461 to release-5.0 (#2568)#3013

Merged
windtalker merged 1 commit intopingcap:release-5.0-20210902from
windtalker:release-5.0-20210902
Sep 6, 2021
Merged

cherry-pick #2431 #2461 to release-5.0 (#2568)#3013
windtalker merged 1 commit intopingcap:release-5.0-20210902from
windtalker:release-5.0-20210902

Conversation

@windtalker
Copy link
Contributor

@windtalker windtalker commented Sep 6, 2021

cherry pick #2568 to release-5.0-20210902 branch

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

Proposal: xxx

What's Changed:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch:

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

Release note 

Please add a release note, or a 'None' if it is not needed.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 6, 2021

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved labels Sep 6, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 6, 2021

@windtalker: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@windtalker windtalker merged commit d573f71 into pingcap:release-5.0-20210902 Sep 6, 2021
@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 6, 2021
@windtalker windtalker deleted the release-5.0-20210902 branch September 6, 2021 01:56
@zhouqiang-cl zhouqiang-cl added this to the v5.0.4 milestone Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

v5.0.4

Development

Successfully merging this pull request may close these issues.

4 participants

@windtalker @ti-chi-bot @zhouqiang-cl @JaySon-Huang