Skip to content

infoschema: Add new columns for information_schema.tiflash_tables#25678

Merged
ti-chi-bot merged 3 commits intopingcap:masterfrom
JaySon-Huang:update_tiflash_table
Jun 23, 2021
Merged

infoschema: Add new columns for information_schema.tiflash_tables#25678
ti-chi-bot merged 3 commits intopingcap:masterfrom
JaySon-Huang:update_tiflash_table

Conversation

@JaySon-Huang
Copy link
Contributor

@JaySon-Huang JaySon-Huang commented Jun 22, 2021 •
edited
Loading

Signed-off-by: JaySon-Huang tshent@qq.com

What problem does this PR solve?

Issue Number: related to pingcap/tiflash#2229

Problem Summary: Suspicious that some TiFlash tasks hold snapshot for a long time, prevent PageStorage from GCing old PageFiles. We add some information about the oldest snapshot in TiFlash system tables and want to access them by TiDB system table information_schema.tiflash_tables.

What is changed and how it works?

Add column STORAGE_{STABLE,DELTA,META}_OLDEST_SNAPSHOT_LIFETIME and STORAGE_{STABLE,DELTA,META}_OLDEST_SNAPSHOT_THREAD_ID for information_schema.tiflash_tables

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch: 4.0, 5.0, 5.1

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    • Deploy a TiFlash contains that commit
    • Deploy a TiDB contains this commit
    • Check the query result of select * from information_schema.tiflash_tables limit 1

Side effects

  • Breaking backward compatibility

Release note

  • No release note

@JaySon-Huang
Add columns for information_schema.tiflash_tables
287ccb9 
Signed-off-by: JaySon-Huang <tshent@qq.com>
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 22, 2021
@ti-srebot
Copy link
Contributor

ti-srebot commented Jun 22, 2021

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

JaySon-Huang
JaySon-Huang commented Jun 22, 2021
View reviewed changes
@JaySon-Huang JaySon-Huang mentioned this pull request Jun 22, 2021
Merged
@JaySon-Huang
Copy link
Contributor Author

JaySon-Huang commented Jun 22, 2021

/label needs-cherry-pick-4.0
/label needs-cherry-pick-5.0
/label needs-cherry-pick-5.1

@github-actions github-actions bot added the sig/sql-infra SIG: SQL Infra label Jun 22, 2021
This was referenced Jun 23, 2021
Closed
Merged
Merged
@JaySon-Huang
Copy link
Contributor Author

JaySon-Huang commented Jun 23, 2021

@crazycs520 PTAL

crazycs520
crazycs520 approved these changes Jun 23, 2021
View reviewed changes
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 23, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 23, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • crazycs520
  • tangenta

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 23, 2021
@JaySon-Huang
Copy link
Contributor Author

JaySon-Huang commented Jun 23, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 23, 2021

@JaySon-Huang: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

Details

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@tangenta
Copy link
Contributor

tangenta commented Jun 23, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 23, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 4204a5d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 23, 2021
@ti-chi-bot ti-chi-bot merged commit b0b01a9 into pingcap:master Jun 23, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jun 23, 2021
@JaySon-Huang @ti-srebot
cherry pick pingcap#25678 to release-4.0
1ca1f1a 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 23, 2021
Closed
@ti-srebot
Copy link
Contributor

ti-srebot commented Jun 23, 2021

cherry pick to release-4.0 in PR #25707

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jun 23, 2021
@JaySon-Huang @ti-srebot
cherry pick pingcap#25678 to release-5.0
244855d 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 23, 2021
Merged
@ti-srebot
Copy link
Contributor

ti-srebot commented Jun 23, 2021

cherry pick to release-5.0 in PR #25708

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jun 23, 2021
@JaySon-Huang @ti-srebot
cherry pick pingcap#25678 to release-5.1
fc18694 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 23, 2021
Merged
@ti-srebot
Copy link
Contributor

ti-srebot commented Jun 23, 2021

cherry pick to release-5.1 in PR #25709

@JaySon-Huang JaySon-Huang deleted the update_tiflash_table branch June 23, 2021 08:26
JaySon-Huang added a commit to JaySon-Huang/tidb that referenced this pull request Jun 24, 2021
@JaySon-Huang
infoschema: Add new columns for information_schema.tiflash_tables (pi…
2f103a4 
…ngcap#25678)
hanfei1991 pushed a commit that referenced this pull request Jun 24, 2021
@JaySon-Huang
infoschema: Add new columns for information_schema.tiflash_tables (#2…
0a5d04c 
…5678) (#25725)
ti-chi-bot pushed a commit that referenced this pull request Jun 24, 2021
@ti-srebot
infoschema: Add new columns for information_schema.tiflash_tables (#2…
5ed2c7e 
…5678) (#25708)
LittleFall pushed a commit to LittleFall/tidb that referenced this pull request Jun 28, 2021
@JaySon-Huang @LittleFall
infoschema: Add new columns for information_schema.tiflash_tables (pi…
e9849e8 
…ngcap#25678)
JaySon-Huang added a commit to JaySon-Huang/tidb that referenced this pull request Jun 29, 2021
@JaySon-Huang
Revert "infoschema: Add new columns for information_schema.tiflash_ta…
0b80aa3 
…bles (pingcap#25678) (pingcap#25708)"

This reverts commit 5ed2c7e.
@JaySon-Huang JaySon-Huang mentioned this pull request Jun 29, 2021
Closed
LittleFall added a commit that referenced this pull request Jul 1, 2021
@LittleFall @windtalker @JaySon-Huang
hotfix: merge to pingcap branch (#25860)
574b9d3 
* copr: log more mpp task info when rpc fail (#25671)

* infoschema: Add new columns for information_schema.tiflash_tables (#25678)

Co-authored-by: xufei <xufei@pingcap.com>
Co-authored-by: JaySon <tshent@qq.com>
ti-chi-bot pushed a commit that referenced this pull request Jul 21, 2021
@ti-srebot
infoschema: Add new columns for information_schema.tiflash_tables (#2…
37b2f1b 
…5678) (#25709)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lidezhu lidezhu lidezhu left review comments

@tangenta tangenta tangenta approved these changes

@crazycs520 crazycs520 crazycs520 approved these changes

Assignees

No one assigned

Labels

needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 sig/sql-infra SIG: SQL Infra size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@JaySon-Huang @ti-srebot @ti-chi-bot @tangenta @crazycs520 @lidezhu