Skip to content

hotfix: merge to pingcap branch#25860

Merged
LittleFall merged 2 commits intopingcap:release-5.1-hotfix-tiflash-patch1from
LittleFall:release-5.1-hotfix-tiflash-patch1
Jul 1, 2021
Merged

hotfix: merge to pingcap branch#25860
LittleFall merged 2 commits intopingcap:release-5.1-hotfix-tiflash-patch1from
LittleFall:release-5.1-hotfix-tiflash-patch1

Conversation

@LittleFall
Copy link
Contributor

@LittleFall LittleFall commented Jul 1, 2021 •
edited
Loading

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

Proposal: xxx

What's Changed:

How it Works:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM
  • Breaking backward compatibility

Release note

  • No release note

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 1, 2021

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 1, 2021
@sre-bot
Copy link
Contributor

sre-bot commented Jul 1, 2021

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what's changed

Or if the count of mainly changed packages are more than 3, use

  • *: what's changed

@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 1, 2021

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

@LittleFall
Copy link
Contributor Author

LittleFall commented Jul 1, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 1, 2021

@LittleFall: /merge in this pull request requires 2 approval(s).

Details

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 1, 2021

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

@sre-bot
Copy link
Contributor

sre-bot commented Jul 1, 2021

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what's changed

Or if the count of mainly changed packages are more than 3, use

  • *: what's changed

@LittleFall LittleFall changed the title merge to tidb hotfix: merge to pingcap branch Jul 1, 2021
@LittleFall
Copy link
Contributor Author

LittleFall commented Jul 1, 2021

/run-all-tests

@LittleFall
Copy link
Contributor Author

LittleFall commented Jul 1, 2021

/run-check_release_note

@github-actions github-actions bot added the sig/sql-infra SIG: SQL Infra label Jul 1, 2021
@LittleFall
Copy link
Contributor Author

LittleFall commented Jul 1, 2021

/run-all-tests

@zhouqiang-cl
Copy link
Contributor

zhouqiang-cl commented Jul 1, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 1, 2021

@zhouqiang-cl: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

Details

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@LittleFall LittleFall merged commit 574b9d3 into pingcap:release-5.1-hotfix-tiflash-patch1 Jul 1, 2021
@LittleFall LittleFall deleted the release-5.1-hotfix-tiflash-patch1 branch July 1, 2021 08:17
@zhouqiang-cl zhouqiang-cl added this to the v5.1.1 milestone Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

sig/sql-infra SIG: SQL Infra size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

v5.1.1

Development

Successfully merging this pull request may close these issues.

7 participants

@LittleFall @ti-chi-bot @sre-bot @ti-srebot @zhouqiang-cl @windtalker @JaySon-Huang