Skip to content

copr: log more mpp task info when rpc fail#25671

Merged
ti-chi-bot merged 7 commits intopingcap:masterfrom
windtalker:log_mpp_task_id_when_rpc_fail
Jun 22, 2021
Merged

copr: log more mpp task info when rpc fail#25671
ti-chi-bot merged 7 commits intopingcap:masterfrom
windtalker:log_mpp_task_id_when_rpc_fail

Conversation

@windtalker
Copy link
Contributor

@windtalker windtalker commented Jun 22, 2021

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:
Currently, if a mpp task meet rpc fail, it only log the task id, which makes it difficult to find out the failure query and TiFlash node.

What is changed and how it works?

Proposal: xxx

What's Changed:

How it Works:
Log mpp task id and the start ts when mpp task meet rpc fail

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM
  • Breaking backward compatibility

Release note

  • No release note

@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 22, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 22, 2021

@fzhedu: Please use GitHub review feature instead of /lgtm [cancel] when you want to submit review to the pull request.
For how to use GitHub review feature, see also this document provided by GitHub.

For the reason we drop support to the commands, see also this page.
This reply is being used as a temporary reply during the migration of review process and will be removed on July 1st.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

fzhedu
fzhedu approved these changes Jun 22, 2021
View reviewed changes
Copy link
Contributor

@fzhedu fzhedu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 22, 2021
@windtalker
Copy link
Contributor Author

windtalker commented Jun 22, 2021

/label needs-cherry-pick-5.0

@windtalker
Copy link
Contributor Author

windtalker commented Jun 22, 2021

/label needs-cherry-pick-5.1

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 22, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • fzhedu
  • hanfei1991

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 22, 2021
@fzhedu
Copy link
Contributor

fzhedu commented Jun 22, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 22, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 4e86961

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 22, 2021
@fzhedu
Copy link
Contributor

fzhedu commented Jun 22, 2021

/merge

@windtalker
Copy link
Contributor Author

windtalker commented Jun 22, 2021

/run-all-tests

@ti-chi-bot ti-chi-bot merged commit a14d9fa into pingcap:master Jun 22, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jun 22, 2021
@windtalker @ti-srebot
cherry pick pingcap#25671 to release-5.0
b3cb773 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 22, 2021
Merged
@ti-srebot
Copy link
Contributor

ti-srebot commented Jun 22, 2021

cherry pick to release-5.0 in PR #25675

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jun 22, 2021
@windtalker @ti-srebot
cherry pick pingcap#25671 to release-5.1
931e712 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 22, 2021
Merged
@ti-srebot
Copy link
Contributor

ti-srebot commented Jun 22, 2021

cherry pick to release-5.1 in PR #25676

LittleFall pushed a commit to LittleFall/tidb that referenced this pull request Jun 28, 2021
@windtalker @LittleFall
copr: log more mpp task info when rpc fail (pingcap#25671)
6c7281b
LittleFall added a commit that referenced this pull request Jul 1, 2021
@LittleFall @windtalker @JaySon-Huang
hotfix: merge to pingcap branch (#25860)
574b9d3 
* copr: log more mpp task info when rpc fail (#25671)

* infoschema: Add new columns for information_schema.tiflash_tables (#25678)

Co-authored-by: xufei <xufei@pingcap.com>
Co-authored-by: JaySon <tshent@qq.com>
ti-chi-bot pushed a commit that referenced this pull request Jul 20, 2021
@ti-srebot
copr: log more mpp task info when rpc fail (#25671) (#25675)
16b4cc4
ti-chi-bot pushed a commit that referenced this pull request Jul 22, 2021
@ti-srebot
copr: log more mpp task info when rpc fail (#25671) (#25676)
a0d2867
@windtalker windtalker deleted the log_mpp_task_id_when_rpc_fail branch November 16, 2021 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hanfei1991 hanfei1991 hanfei1991 approved these changes

+1 more reviewer

@fzhedu fzhedu fzhedu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@windtalker @ti-chi-bot @fzhedu @ti-srebot @hanfei1991