Skip to content

copr: log more mpp task info when rpc fail (#25671)#25675

Merged
ti-chi-bot merged 2 commits intopingcap:release-5.0from
ti-srebot:release-5.0-a14d9fad96dd
Jul 20, 2021
Merged

copr: log more mpp task info when rpc fail (#25671)#25675
ti-chi-bot merged 2 commits intopingcap:release-5.0from
ti-srebot:release-5.0-a14d9fad96dd

Conversation

@ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Jun 22, 2021 •
edited
Loading

cherry-pick #25671 to release-5.0
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/25675

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/25675:release-5.0-a14d9fad96dd

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:
Currently, if a mpp task meet rpc fail, it only log the task id, which makes it difficult to find out the failure query and TiFlash node.

What is changed and how it works?

Proposal: xxx

What's Changed:

How it Works:
Log mpp task id and the start ts when mpp task meet rpc fail

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM
  • Breaking backward compatibility

Release note

  • No release note

@windtalker @ti-srebot
cherry pick pingcap#25671 to release-5.0
b3cb773 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

ti-srebot commented Jun 22, 2021

/run-all-tests

@ti-srebot ti-srebot mentioned this pull request Jun 22, 2021
Merged
@ti-srebot ti-srebot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/5.0-cherry-pick labels Jun 22, 2021
@ti-srebot ti-srebot requested review from fzhedu and hanfei1991 June 22, 2021 10:50
@ti-srebot ti-srebot added this to the v5.0.2 milestone Jun 22, 2021
@ti-srebot
Copy link
Contributor Author

ti-srebot commented Jun 22, 2021

@windtalker you're already a collaborator in bot's repo.

fzhedu
fzhedu approved these changes Jun 22, 2021
View reviewed changes
Copy link
Contributor

@fzhedu fzhedu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 22, 2021

@fzhedu: Please use GitHub review feature instead of /lgtm [cancel] when you want to submit review to the pull request.
For how to use GitHub review feature, see also this document provided by GitHub.

For the reason we drop support to the commands, see also this page.
This reply is being used as a temporary reply during the migration of review process and will be removed on July 1st.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 22, 2021
@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Jul 20, 2021
@windtalker
Copy link
Contributor

windtalker commented Jul 20, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 20, 2021

@windtalker: /merge in this pull request requires 2 approval(s).

Details

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

zanmato1984
zanmato1984 approved these changes Jul 20, 2021
View reviewed changes
Copy link
Contributor

@zanmato1984 zanmato1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 20, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • fzhedu
  • zanmato1984

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 20, 2021
@zanmato1984
Copy link
Contributor

zanmato1984 commented Jul 20, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 20, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: b3cb773

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 20, 2021
@windtalker
Copy link
Contributor

windtalker commented Jul 20, 2021

/run-all-tests

@ti-chi-bot ti-chi-bot merged commit 16b4cc4 into pingcap:release-5.0 Jul 20, 2021
@zhouqiang-cl zhouqiang-cl modified the milestones: v5.0.2, v5.0.4 Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zanmato1984 zanmato1984 zanmato1984 approved these changes

@hanfei1991 hanfei1991 Awaiting requested review from hanfei1991

+1 more reviewer

@fzhedu fzhedu fzhedu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@windtalker windtalker

Labels

cherry-pick-approved Cherry pick PR approved by release team. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/5.0-cherry-pick

Projects

None yet

Milestone

v5.0.4

Development

Successfully merging this pull request may close these issues.

6 participants

@ti-srebot @ti-chi-bot @windtalker @zanmato1984 @fzhedu @zhouqiang-cl