Skip to content

copr: add log to record task id when mpp task fail#25582

Merged
hanfei1991 merged 1 commit intopingcap:hanfei/release5.0-hotfix-tiflash-patch2from
windtalker:hanfei/release5.0-hotfix-tiflash-patch2
Jun 20, 2021
Merged

copr: add log to record task id when mpp task fail#25582
hanfei1991 merged 1 commit intopingcap:hanfei/release5.0-hotfix-tiflash-patch2from
windtalker:hanfei/release5.0-hotfix-tiflash-patch2

Conversation

@windtalker
Copy link
Contributor

@windtalker windtalker commented Jun 20, 2021 •
edited
Loading

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

Proposal: xxx

What's Changed:

How it Works:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM
  • Breaking backward compatibility

Release note

  • No release note

@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 20, 2021
@ti-srebot
Copy link
Contributor

ti-srebot commented Jun 20, 2021

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

@sre-bot
Copy link
Contributor

sre-bot commented Jun 20, 2021

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what's changed

Or if the count of mainly changed packages are more than 3, use

  • *: what's changed

@windtalker windtalker changed the title add log to record task id when mpp task fail copr: add log to record task id when mpp task fail Jun 20, 2021
@LittleFall
Copy link
Contributor

LittleFall commented Jun 20, 2021

lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 20, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 20, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • LittleFall
  • hanfei1991

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 20, 2021
@hanfei1991 hanfei1991 merged commit b426e4c into pingcap:hanfei/release5.0-hotfix-tiflash-patch2 Jun 20, 2021
windtalker added a commit to windtalker/tidb that referenced this pull request Jun 21, 2021
@windtalker
add log to record task id when mpp task fail (pingcap#25582)
6768a40
@windtalker windtalker deleted the hanfei/release5.0-hotfix-tiflash-patch2 branch October 23, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hanfei1991 hanfei1991 hanfei1991 approved these changes

+1 more reviewer

@LittleFall LittleFall LittleFall approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@windtalker @ti-srebot @sre-bot @LittleFall @ti-chi-bot @hanfei1991