Skip to content

infoschema: Add new columns for information_schema.tiflash_tables (#25678)#25708

Merged
ti-chi-bot merged 3 commits intopingcap:release-5.0from
ti-srebot:release-5.0-b0b01a9ef16e
Jun 24, 2021
Merged

infoschema: Add new columns for information_schema.tiflash_tables (#25678)#25708
ti-chi-bot merged 3 commits intopingcap:release-5.0from
ti-srebot:release-5.0-b0b01a9ef16e

Conversation

@ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Jun 23, 2021 •
edited
Loading

cherry-pick #25678 to release-5.0
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/25708

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/25708:release-5.0-b0b01a9ef16e

Signed-off-by: JaySon-Huang tshent@qq.com

What problem does this PR solve?

Issue Number: related to pingcap/tiflash#2229

Problem Summary: Suspicious that some TiFlash tasks hold snapshot for a long time, prevent PageStorage from GCing old PageFiles. We add some information about the oldest snapshot in TiFlash system tables and want to access them by TiDB system table information_schema.tiflash_tables.

What is changed and how it works?

Add column STORAGE_{STABLE,DELTA,META}_OLDEST_SNAPSHOT_LIFETIME and STORAGE_{STABLE,DELTA,META}_OLDEST_SNAPSHOT_THREAD_ID for information_schema.tiflash_tables

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch: 4.0, 5.0, 5.1

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    • Deploy a TiFlash contains that commit
    • Deploy a TiDB contains this commit
    • Check the query result of select * from information_schema.tiflash_tables limit 1

Side effects

  • Breaking backward compatibility

Release note

  • No release note

@JaySon-Huang @ti-srebot
cherry pick pingcap#25678 to release-5.0
244855d 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

ti-srebot commented Jun 23, 2021

/run-all-tests

@ti-srebot ti-srebot mentioned this pull request Jun 23, 2021
Merged
@ti-srebot ti-srebot added sig/sql-infra SIG: SQL Infra size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/5.0-cherry-pick labels Jun 23, 2021
@ti-srebot ti-srebot added this to the v5.0.2 milestone Jun 23, 2021
@ti-srebot
Copy link
Contributor Author

ti-srebot commented Jun 23, 2021

@JaySon-Huang you're already a collaborator in bot's repo.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 23, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 23, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • tangenta
  • xiongjiwei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 23, 2021
@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Jun 24, 2021
@JaySon-Huang
Copy link
Contributor

JaySon-Huang commented Jun 24, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 24, 2021

@JaySon-Huang: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

Details

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@zhouqiang-cl
Copy link
Contributor

zhouqiang-cl commented Jun 24, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 24, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 244855d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 24, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 24, 2021

@ti-srebot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

1 similar comment
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 24, 2021

@ti-srebot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 5ed2c7e into pingcap:release-5.0 Jun 24, 2021
@JaySon-Huang JaySon-Huang deleted the release-5.0-b0b01a9ef16e branch June 24, 2021 07:02
@zhouqiang-cl zhouqiang-cl modified the milestones: v5.0.2, v5.0.3 Jun 28, 2021
JaySon-Huang added a commit to JaySon-Huang/tidb that referenced this pull request Jun 29, 2021
@JaySon-Huang
Revert "infoschema: Add new columns for information_schema.tiflash_ta…
0b80aa3 
…bles (pingcap#25678) (pingcap#25708)"

This reverts commit 5ed2c7e.
@JaySon-Huang JaySon-Huang mentioned this pull request Jun 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tangenta tangenta tangenta approved these changes

@crazycs520 crazycs520 Awaiting requested review from crazycs520

@lidezhu lidezhu Awaiting requested review from lidezhu

+1 more reviewer

@xiongjiwei xiongjiwei xiongjiwei approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@JaySon-Huang JaySon-Huang

Labels

cherry-pick-approved Cherry pick PR approved by release team. sig/sql-infra SIG: SQL Infra size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/5.0-cherry-pick

Projects

None yet

Milestone

v5.0.3

Development

Successfully merging this pull request may close these issues.

6 participants

@ti-srebot @ti-chi-bot @JaySon-Huang @zhouqiang-cl @xiongjiwei @tangenta