Skip to content

infoschema: Add new columns for information_schema.tiflash_tables#25725

Merged
hanfei1991 merged 1 commit intopingcap:hanfei/release5.0-hotfix-tiflash-patch2from
JaySon-Huang:hanfei/release5.0-hotfix-tiflash-patch2
Jun 24, 2021
Merged

infoschema: Add new columns for information_schema.tiflash_tables#25725
hanfei1991 merged 1 commit intopingcap:hanfei/release5.0-hotfix-tiflash-patch2from
JaySon-Huang:hanfei/release5.0-hotfix-tiflash-patch2

Conversation

@JaySon-Huang
Copy link
Contributor

@JaySon-Huang JaySon-Huang commented Jun 24, 2021

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

Proposal: xxx

What's Changed:

How it Works:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM
  • Breaking backward compatibility

Release note

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 24, 2021

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 24, 2021
@ti-srebot
Copy link
Contributor

ti-srebot commented Jun 24, 2021

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

@github-actions github-actions bot added the sig/sql-infra SIG: SQL Infra label Jun 24, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 24, 2021

@hanfei1991: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@hanfei1991 hanfei1991 merged commit 0a5d04c into pingcap:hanfei/release5.0-hotfix-tiflash-patch2 Jun 24, 2021
@JaySon-Huang JaySon-Huang deleted the hanfei/release5.0-hotfix-tiflash-patch2 branch June 24, 2021 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hanfei1991 hanfei1991 hanfei1991 approved these changes

Assignees

No one assigned

Labels

sig/sql-infra SIG: SQL Infra size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JaySon-Huang @ti-chi-bot @ti-srebot @hanfei1991