infoschema: Add new columns for information_schema.tiflash_tables (#25678)#25707
infoschema: Add new columns for information_schema.tiflash_tables (#25678)#25707ti-srebot wants to merge 1 commit intopingcap:release-4.0from
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
@ti-srebot: This cherry pick PR is for a release branch and has not yet been approved by release team. To merge this cherry pick, it must first be approved by the collaborators. AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/run-all-tests |
|
@JaySon-Huang you're already a collaborator in bot's repo. |
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
|
Not plan to fix this in release-4.0, closing it. |
|
/close |
|
@JaySon-Huang: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
cherry-pick #25678 to release-4.0
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/25707After apply modifications, you can push your change to this PR via:
Signed-off-by: JaySon-Huang tshent@qq.com
What problem does this PR solve?
Issue Number: related to pingcap/tiflash#2229
Problem Summary: Suspicious that some TiFlash tasks hold snapshot for a long time, prevent PageStorage from GCing old PageFiles. We add some information about the oldest snapshot in TiFlash system tables and want to access them by TiDB system table
information_schema.tiflash_tables.What is changed and how it works?
Add column
STORAGE_{STABLE,DELTA,META}_OLDEST_SNAPSHOT_LIFETIMEandSTORAGE_{STABLE,DELTA,META}_OLDEST_SNAPSHOT_THREAD_IDforinformation_schema.tiflash_tablesRelated changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
select * from information_schema.tiflash_tables limit 1Side effects
Release note