Closed
Conversation
This prevent a test function to be locally allocated and interfering with measurements.
Co-authored-by: basimkhajwal <basimkhajwal@gmail.com> Co-authored-by: Mark Shinwell <mshinwell@pm.me>
gretay-js
reviewed
Feb 10, 2022
Contributor
gretay-js
left a comment
There was a problem hiding this comment.
It looks good, I have a bunch of minor comments/questions.
The only correctness concern is in the comment about Call_no_return.
Forward analysis mistake in L72 should be ~init:(value, bot) not ~init:(value, value).
gretay-js
reviewed
Feb 16, 2022
* Revert "Revert bswap PRs (480 and 482) (oxcaml#501)" This reverts commit 52cd50e. * Test for bswap32 * Add more test inputs * Refactor test * Add more tests
…ml#365) * Implemented inlining history * Add links between apply node and there respective function declaration * Fix formatting for inlining arguments * Inlining reports are now showing all decisions taken for any paths, making them work both with simplify and closure conversion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request basically augments the
Cfg_dataflowmodulewith a backward analysis and then instantiates it to compute the
liveness on CFG values. The liveness information computed through
this new analysis is compared to the one from the existing pass.
This pull request is a draft because of the duplication introduced
with respect to the forward variant of the dataflow analysis.
Making the two converge is likely to spot shortcomings or even
mistakes in the forward variant.