Skip to content

Split macOS CI job#507

Merged
mshinwell merged 5 commits intooxcaml:mainfrom
xclerc:split-macos-ci
Feb 7, 2022
Merged

Split macOS CI job#507
mshinwell merged 5 commits intooxcaml:mainfrom
xclerc:split-macos-ci

Conversation

@xclerc
Copy link
Copy Markdown
Contributor

@xclerc xclerc commented Feb 3, 2022

As discussed in #504 (sorry for hijacking the thread, by the way...),
this pull request splits the CI job for macOS so that:

  • activity on the pull request only builds;
  • merge of the pull request builds, installs, and tests.

@xclerc xclerc added the CI Github Actions CI changes label Feb 3, 2022
@xclerc xclerc requested a review from mshinwell as a code owner February 3, 2022 09:49
@xclerc
Copy link
Copy Markdown
Contributor Author

xclerc commented Feb 3, 2022

The macOS job with the changes of this pull request
clocked at 22 minutes, while similar jobs were taking
approx. 35 minutes in the recent past.

(See https://github.com/ocaml-flambda/flambda-backend/actions/workflows/macos.yml).

@xclerc xclerc mentioned this pull request Feb 3, 2022
@mshinwell
Copy link
Copy Markdown
Collaborator

Can we rename push_to_main to macos_build_and_test_flambda2 or something? I think the existing workflow scripts will still run on pushes to main as well.

@mshinwell mshinwell merged commit 6e986e4 into oxcaml:main Feb 7, 2022
mshinwell pushed a commit that referenced this pull request Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Github Actions CI changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants