Do not hardcode the threshold for heap reduction#535
Merged
mshinwell merged 2 commits intooxcaml:mainfrom Feb 21, 2022
Merged
Conversation
gretay-js
approved these changes
Feb 18, 2022
gretay-js
approved these changes
Feb 21, 2022
mshinwell
approved these changes
Feb 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the title suggests, this pull request simply
makes the threshold for a heap reduction before
code emission a variable that can be controlled
from the command-line or the environment.
The rationale is that one may want to change it
without rebuilding the compiler, and there is a
chance the build system may be in a position
to give some insight since it controls the level
of parallelism.