Type_grammar: include closure IDs in free names#508
Merged
chambart merged 1 commit intooxcaml:mainfrom Feb 3, 2022
Merged
Conversation
chambart
approved these changes
Feb 3, 2022
Contributor
chambart
left a comment
There was a problem hiding this comment.
This looks good. I'm not sure that the number of occurences is relevant for that kind of name. But the assumption seems ok anyway.
mshinwell
pushed a commit
that referenced
this pull request
Mar 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR complements #496, insuring that the closure IDs occurring in return types have their offsets properly re-exported.
Note that I'm assuming that the
function_typesandclosure_typesmaps have the same keys, so the closure IDs from the latter one are skipped to get a more accurate number of occurrences.