Avoid clearing caches in native toplevel#528
Merged
mshinwell merged 1 commit intooxcaml:mainfrom Feb 7, 2022
Merged
Conversation
mshinwell
approved these changes
Feb 7, 2022
xclerc
approved these changes
Feb 7, 2022
gretay-js
approved these changes
Feb 7, 2022
Contributor
gretay-js
left a comment
There was a problem hiding this comment.
Small comments that I have can be addressed separately.
mshinwell
pushed a commit
that referenced
this pull request
Feb 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #429,
Emitauxclears various caches before calling the assembler, including the typechecker's cache of loadedcmifiles.When using
ocamloptto compile a single file, this saves memory. However, when using the native toplevel, this breaks short-paths (which relies on the cmi cache), and probably slows things down (because there are usually multiple phrases and the cache is useful). So, this patch turns off this mechanism when run from the toplevel.(Future work: it may also be worth disabling this mechanism when
ocamloptis being used to compile multiple files)