Merged
Conversation
This reverts commit 20ed11a.
…xcaml#482)" This reverts commit 09629e2.
Collaborator
Author
|
Testcase: |
mshinwell
added a commit
that referenced
this pull request
Feb 2, 2022
Contributor
|
Tested with closure and flambda1 (before this was merged); both succeeded. |
gretay-js
added a commit
that referenced
this pull request
Feb 16, 2022
Gbury
pushed a commit
to Gbury/flambda-backend
that referenced
this pull request
Feb 17, 2022
* Revert "Revert bswap PRs (480 and 482) (oxcaml#501)" This reverts commit 52cd50e. * Test for bswap32 * Add more test inputs * Refactor test * Add more tests
mshinwell
pushed a commit
that referenced
this pull request
Mar 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are producing the wrong answer (testcase to be provided shortly), possibly only with Flambda 2 -- being looked into now. There must be some disagreement about the semantics of these, so let's revert for the moment.