Don't sign-extend bswap32 in Emit (amd64)#482
Merged
gretay-js merged 1 commit intooxcaml:mainfrom Jan 26, 2022
Merged
Conversation
See Cmm_helpers.box_int_gen.
xclerc
approved these changes
Jan 25, 2022
Contributor
|
Shouldn't we add a test? |
Contributor
Author
I am adding a test for it in ocaml_intrinsics library, to go along with other swap32 and Int32unsigned_to_int changes. |
mshinwell
pushed a commit
that referenced
this pull request
Feb 1, 2022
See Cmm_helpers.box_int_gen.
mshinwell
added a commit
to mshinwell/oxcaml
that referenced
this pull request
Feb 2, 2022
…xcaml#482)" This reverts commit 09629e2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ibswapoperation should treat its input as unsigned, but there is some inconsistently currently. ForIbswap 16, amd64 emits zero-extension, butIbswap 32gets sign-extended and we get code that looks like this:because the result of
Ibswap 32is also sign-extended when it's boxed (seeCmm_helpers.box_int_gen), and it's the only wayIbswap 32is used.@stedolan I think the sign-extension in
Emitbecame unnecessary after ocaml/ocaml#9006