Ensure sound closure of local alloc regions in Lambda_to_flambda#516
Merged
mshinwell merged 2 commits intooxcaml:mainfrom Feb 4, 2022
Merged
Ensure sound closure of local alloc regions in Lambda_to_flambda#516mshinwell merged 2 commits intooxcaml:mainfrom
mshinwell merged 2 commits intooxcaml:mainfrom
Conversation
lthls
approved these changes
Feb 4, 2022
Contributor
lthls
left a comment
There was a problem hiding this comment.
I believe the code is correct.
However, the approach used for placing regions (and in particular the various exceptional cases) needs to be documented.
@Keryan-dev is working on that, but I'm approving this PR already so that we can merge it now and spend all the time we want nitpicking on the documentation in a subsequent PR.
mshinwell
pushed a commit
that referenced
this pull request
Mar 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses continuations created through
Lambda_to_flambdato track the expected state of local stack and close regions only when it's necessary, i.e. when jumping a continuation (through a function or not) outside the scope of relevant regions.Wrapper continuations are used to avoid the duplications of
End_region, which produces noisy additionalLet_conts at some places that could be flatten out, but unused wrappers are cleared out byClosure_conversionso I don't expect a lot more code to be generated.