feat(ast): add custom builder methods to AST types by overlookmotel · Pull Request #23651 · oxc-project/oxc

overlookmotel · 2026-06-19T14:26:49Z

Part of #23043.

As well as the generated AstBuilder methods, we have hand-written convenience methods in ast_builder_impl.rs. Replicate these as methods on AST types themselves, using the new generic AstBuild approach.

Note: This stack is draft for now. I'd like to try migrating oxc_parser to new AstBuilder and check it all works before merging anything.

overlookmotel · 2026-06-19T14:27:02Z

feat(ast): add custom builder methods to AST types #23651 : 2 dependent PRs (#23729 , #23730 ) 👈 (View in Graphite)
feat(ast): add AST creation methods to AST types #23650
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2026-06-19T14:35:26Z

Merging this PR will not alter performance

✅ 62 untouched benchmarks
⏩ 9 skipped benchmarks¹

_{Comparing om/06-18-feat_ast_add_custom_builder_methods_to_ast_types (1e4a339) with om/06-06-feat_ast_add_ast_creation_methods_to_ast_types (eae9e61)²}

9 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
No successful run was found on om/06-06-feat_ast_add_ast_creation_methods_to_ast_types (f3b599f) during the generation of this report, so 33a2206 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

Copilot

Pull request overview

Adds handwritten convenience builder APIs to AST types under the new builder_new-gated builder module, mirroring the existing helpers in ast_builder_impl.rs to support the ongoing AstBuilder redesign (#23043).

Changes:

Includes a new builder::custom module in the new builder system.
Introduces convenience constructors on several AST types (e.g. Expression, Function, TemplateElement) that delegate to generated new_* methods with sensible defaults.
Reimplements template raw-string escaping for TemplateElement in the new builder path.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
crates/oxc_ast/src/builder/mod.rs	Wires in the new `custom` module so inherent convenience methods are compiled with `builder_new`.
crates/oxc_ast/src/builder/custom.rs	Adds the new AST-type convenience constructors and the template raw escaping helper.

graphite-app · 2026-06-25T01:45:05Z

Merge activity

Jun 25, 1:45 AM UTC: Dunqing added this pull request to the Graphite merge queue.
Jun 25, 1:53 AM UTC: Merged by the Graphite merge queue.

Part of #23043. As well as the generated `AstBuilder` methods, we have hand-written convenience methods in `ast_builder_impl.rs`. Replicate these as methods on AST types themselves, using the new generic `AstBuild` approach. Note: This stack is draft for now. I'd like to try migrating `oxc_parser` to new `AstBuilder` and check it all works before merging anything.

… nodes (#23783) When custom methods were added to new `AstBuilder` (#23651), there was a mistake. The 2 old `AstBuilder` methods `plain_export_named_declaration_declaration` and `plain_export_named_declaration` return an `ArenaBox<ExportNamedDeclaration>`, but the new methods added to new `AstBuilder` were returning unboxed `ExportNamedDeclaration`. Fix these mistakes, so the new methods are exact replacements for the old ones.

### 💥 BREAKING CHANGES - 94fbacb ast: [**BREAKING**] Only export `AstBuilder` and `NONE` in `builder` module (#23876) (overlookmotel) - 8de5122 ecmascript: [**BREAKING**] Switch to new `AstBuilder` (#23834) (overlookmotel) - dc0ef38 transformer: [**BREAKING**] Switch to new `AstBuilder` (#23831) (overlookmotel) - 88f4455 str: [**BREAKING**] `Str` and `Ident` methods take `&GetAllocator` (#23781) (overlookmotel) - 36009dd allocator: [**BREAKING**] `GetAllocator::allocator` take `&self` (#23676) (overlookmotel) - bd74f9d allocator: [**BREAKING**] Rename `AllocatorAccessor` trait to `GetAllocator` (#23675) (overlookmotel) ### 🚀 Features - 326fe25 transformer_plugins: Support `typeof` `define` keys (#23605) (Alexander Lichter) - f2091b3 ast: Unify old and new `AstBuilder`s (#23875) (overlookmotel) - cd1fd12 codegen: Expose `Codegen::print_string` API (#23785) (camc314) - 785461b ast: Add custom builder methods to AST types (#23651) (overlookmotel) - 05d1357 ast: Add AST creation methods to AST types (#23650) (overlookmotel) - 2580eda str: Add `Str::from_str_in` and `Ident::from_str_in` methods (#23767) (overlookmotel) - 6883fcf minifier: Fold write-once falsy var to false in boolean context (#23540) (Dunqing) - fcbf993 allocator: Add `Vec::from_value_in` method (#23718) (overlookmotel) - 989ddb7 allocator: Add `Vec::from_box_in` method (#23717) (overlookmotel) - 9d1aa7f allocator: Improve `PartialEq` for `Vec` (#23716) (overlookmotel) ### 🐛 Bug Fixes - da0e5bf minifier: Don't reorder a closed-over TDZ read when inlining a var (#23771) (Dunqing) - 0b3021f allocator: Remove `Vec::from_box_in` (#23873) (overlookmotel) - 0ab64ec ast: Silence deprecation warnings within files defining deprecated `AstBuilder` methods (#23889) (overlookmotel) - 8c07cad all: Enable `disable_old_builder` Cargo feature for `oxc_ast` crate in tests (#23888) (overlookmotel) - 3800f01 ast: Legacy `AstBuilder` methods take `self` not `&self` (#23891) (overlookmotel) - 869ac20 semantic/cfg: Connect for update exit to loop test (#23791) (camc314) - d3e92d5 semantic/cfg: Connect while branches from condition exit (#23790) (camc314) - 025045d ast: `ExportNamedDeclaration` plain builder methods return boxed nodes (#23783) (overlookmotel) - 7537c58 ast: Fix name of `AstBuilder` method for `Expression::V8IntrinsicExpression` (#23766) (overlookmotel) - 3f574f5 traverse: Fix unsoundness in `Traverse` walk functions (#23745) (overlookmotel) - 585760f parser: String in AST reference arena (#23721) (overlookmotel) - 7231d55 allocator: Fix unsound lifetime extension in `Box::new_in` (#23685) (overlookmotel) ### ⚡ Performance - d5c916a semantic: Flatten hoisting_variables to avoid per-scope map allocation (#23927) (Lawrence Lin) - e71609d minifier: Bail member-expr folding before the side-effect walk (#23924) (Lawrence Lin) - e1f89ab minifier: Reduce string allocations folding addition (#23846) (overlookmotel) - 9f6ee3b isolated-declarations: Pool scope maps to avoid per-scope alloc/rehash (#23761) (Boshen) - 0b07c4c semantic: Avoid heap alloc for catch-clause binding ids (#23911) (Lawrence Lin) - c5eef8b regular_expression: Skip capturing-group pre-parse when pattern has no `(` (#23908) (Lawrence Lin) - b4f5b4b isolated_declarations: Remove redundant clone of formal parameter pattern (#23912) (Lawrence Lin) - 53d083f isolated_declarations: Use `TakeIn` not `CloneIn` (#23847) (overlookmotel) - 3ea9304 react_compiler: Use faster API to arena allocate strings (#23849) (overlookmotel) - a6d8e45 parser: Avoid span lookup for arrow expression body (#23788) (camc314) - e1886a0 transformer, minifier: Use `static_ident!` macro to create static `Ident`s (#23727) (overlookmotel) - 5527bef transformer/object-rest-spread: Reduce iteration (#23720) (overlookmotel) - 680ffbc transformer: Allocate AST nodes in arena directly (#23711) (overlookmotel) - 1c63c66 parser: Allocate AST nodes in arena directly (#23712) (overlookmotel) - 3855f0c minifier: Allocate AST nodes in arena directly (#23710) (overlookmotel) - d025887 isolated_declarations: Allocate AST nodes in arena directly (#23709) (overlookmotel) - 10b96c6 parser: Remove string search from parsing JSX element name (#23713) (overlookmotel) ### 📚 Documentation - 3d61dea all: Correct capitalization in comments (#23887) (overlookmotel) - aa1ad74 ast: Add `#[deprecated]` to legacy `AstBuilder` methods (#23877) (overlookmotel) - a4676db ast: Correct doc comment for `NONE` (#23765) (overlookmotel) - 419ec80 syntax: Fix typo in doc comment (#23674) (overlookmotel) ### 🛡️ Security - 3cdd18f deps: Update npm packages (#23690) (renovate[bot]) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com> Co-authored-by: Cameron <cameron.clark@hey.com>

Part of #23043. As well as the generated `AstBuilder` methods, we have hand-written convenience methods in `ast_builder_impl.rs`. Replicate these as methods on AST types themselves, using the new generic `AstBuild` approach. Note: This stack is draft for now. I'd like to try migrating `oxc_parser` to new `AstBuilder` and check it all works before merging anything.

… nodes (#23783) When custom methods were added to new `AstBuilder` (#23651), there was a mistake. The 2 old `AstBuilder` methods `plain_export_named_declaration_declaration` and `plain_export_named_declaration` return an `ArenaBox<ExportNamedDeclaration>`, but the new methods added to new `AstBuilder` were returning unboxed `ExportNamedDeclaration`. Fix these mistakes, so the new methods are exact replacements for the old ones.

### 💥 BREAKING CHANGES - 94fbacb ast: [**BREAKING**] Only export `AstBuilder` and `NONE` in `builder` module (#23876) (overlookmotel) - 8de5122 ecmascript: [**BREAKING**] Switch to new `AstBuilder` (#23834) (overlookmotel) - dc0ef38 transformer: [**BREAKING**] Switch to new `AstBuilder` (#23831) (overlookmotel) - 88f4455 str: [**BREAKING**] `Str` and `Ident` methods take `&GetAllocator` (#23781) (overlookmotel) - 36009dd allocator: [**BREAKING**] `GetAllocator::allocator` take `&self` (#23676) (overlookmotel) - bd74f9d allocator: [**BREAKING**] Rename `AllocatorAccessor` trait to `GetAllocator` (#23675) (overlookmotel) ### 🚀 Features - 326fe25 transformer_plugins: Support `typeof` `define` keys (#23605) (Alexander Lichter) - f2091b3 ast: Unify old and new `AstBuilder`s (#23875) (overlookmotel) - cd1fd12 codegen: Expose `Codegen::print_string` API (#23785) (camc314) - 785461b ast: Add custom builder methods to AST types (#23651) (overlookmotel) - 05d1357 ast: Add AST creation methods to AST types (#23650) (overlookmotel) - 2580eda str: Add `Str::from_str_in` and `Ident::from_str_in` methods (#23767) (overlookmotel) - 6883fcf minifier: Fold write-once falsy var to false in boolean context (#23540) (Dunqing) - fcbf993 allocator: Add `Vec::from_value_in` method (#23718) (overlookmotel) - 989ddb7 allocator: Add `Vec::from_box_in` method (#23717) (overlookmotel) - 9d1aa7f allocator: Improve `PartialEq` for `Vec` (#23716) (overlookmotel) ### 🐛 Bug Fixes - da0e5bf minifier: Don't reorder a closed-over TDZ read when inlining a var (#23771) (Dunqing) - 0b3021f allocator: Remove `Vec::from_box_in` (#23873) (overlookmotel) - 0ab64ec ast: Silence deprecation warnings within files defining deprecated `AstBuilder` methods (#23889) (overlookmotel) - 8c07cad all: Enable `disable_old_builder` Cargo feature for `oxc_ast` crate in tests (#23888) (overlookmotel) - 3800f01 ast: Legacy `AstBuilder` methods take `self` not `&self` (#23891) (overlookmotel) - 869ac20 semantic/cfg: Connect for update exit to loop test (#23791) (camc314) - d3e92d5 semantic/cfg: Connect while branches from condition exit (#23790) (camc314) - 025045d ast: `ExportNamedDeclaration` plain builder methods return boxed nodes (#23783) (overlookmotel) - 7537c58 ast: Fix name of `AstBuilder` method for `Expression::V8IntrinsicExpression` (#23766) (overlookmotel) - 3f574f5 traverse: Fix unsoundness in `Traverse` walk functions (#23745) (overlookmotel) - 585760f parser: String in AST reference arena (#23721) (overlookmotel) - 7231d55 allocator: Fix unsound lifetime extension in `Box::new_in` (#23685) (overlookmotel) ### ⚡ Performance - d5c916a semantic: Flatten hoisting_variables to avoid per-scope map allocation (#23927) (Lawrence Lin) - e71609d minifier: Bail member-expr folding before the side-effect walk (#23924) (Lawrence Lin) - e1f89ab minifier: Reduce string allocations folding addition (#23846) (overlookmotel) - 9f6ee3b isolated-declarations: Pool scope maps to avoid per-scope alloc/rehash (#23761) (Boshen) - 0b07c4c semantic: Avoid heap alloc for catch-clause binding ids (#23911) (Lawrence Lin) - c5eef8b regular_expression: Skip capturing-group pre-parse when pattern has no `(` (#23908) (Lawrence Lin) - b4f5b4b isolated_declarations: Remove redundant clone of formal parameter pattern (#23912) (Lawrence Lin) - 53d083f isolated_declarations: Use `TakeIn` not `CloneIn` (#23847) (overlookmotel) - 3ea9304 react_compiler: Use faster API to arena allocate strings (#23849) (overlookmotel) - a6d8e45 parser: Avoid span lookup for arrow expression body (#23788) (camc314) - e1886a0 transformer, minifier: Use `static_ident!` macro to create static `Ident`s (#23727) (overlookmotel) - 5527bef transformer/object-rest-spread: Reduce iteration (#23720) (overlookmotel) - 680ffbc transformer: Allocate AST nodes in arena directly (#23711) (overlookmotel) - 1c63c66 parser: Allocate AST nodes in arena directly (#23712) (overlookmotel) - 3855f0c minifier: Allocate AST nodes in arena directly (#23710) (overlookmotel) - d025887 isolated_declarations: Allocate AST nodes in arena directly (#23709) (overlookmotel) - 10b96c6 parser: Remove string search from parsing JSX element name (#23713) (overlookmotel) ### 📚 Documentation - 3d61dea all: Correct capitalization in comments (#23887) (overlookmotel) - aa1ad74 ast: Add `#[deprecated]` to legacy `AstBuilder` methods (#23877) (overlookmotel) - a4676db ast: Correct doc comment for `NONE` (#23765) (overlookmotel) - 419ec80 syntax: Fix typo in doc comment (#23674) (overlookmotel) ### 🛡️ Security - 3cdd18f deps: Update npm packages (#23690) (renovate[bot]) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com> Co-authored-by: Cameron <cameron.clark@hey.com>

overlookmotel mentioned this pull request Jun 19, 2026

refactor(ast): add ast_builder Cargo feature #23649

Closed

overlookmotel mentioned this pull request Jun 19, 2026

feat(ast): add AST creation methods to AST types #23650

Merged

github-actions Bot added the A-ast Area - AST label Jun 19, 2026

overlookmotel self-assigned this Jun 19, 2026

overlookmotel force-pushed the om/06-18-feat_ast_add_custom_builder_methods_to_ast_types branch from cdf742f to fc5ec32 Compare June 20, 2026 22:21

overlookmotel force-pushed the om/06-06-feat_ast_add_ast_creation_methods_to_ast_types branch 2 times, most recently from 6a2e997 to 6143bb3 Compare June 21, 2026 00:39

overlookmotel force-pushed the om/06-18-feat_ast_add_custom_builder_methods_to_ast_types branch 2 times, most recently from 9966f70 to 3ae30e6 Compare June 23, 2026 00:31

overlookmotel force-pushed the om/06-06-feat_ast_add_ast_creation_methods_to_ast_types branch from 6143bb3 to 449b1b2 Compare June 23, 2026 00:31

overlookmotel force-pushed the om/06-06-feat_ast_add_ast_creation_methods_to_ast_types branch from 449b1b2 to c3ccd4d Compare June 23, 2026 00:56

overlookmotel force-pushed the om/06-18-feat_ast_add_custom_builder_methods_to_ast_types branch from 3ae30e6 to 95e4e59 Compare June 23, 2026 00:56

graphite-app Bot force-pushed the om/06-06-feat_ast_add_ast_creation_methods_to_ast_types branch from c3ccd4d to c1442ed Compare June 23, 2026 01:08

graphite-app Bot force-pushed the om/06-18-feat_ast_add_custom_builder_methods_to_ast_types branch from 95e4e59 to a1c320e Compare June 23, 2026 01:09

overlookmotel force-pushed the om/06-18-feat_ast_add_custom_builder_methods_to_ast_types branch from a1c320e to ade064d Compare June 23, 2026 10:46

overlookmotel mentioned this pull request Jun 23, 2026

feat(ast)!: put AstBuilder behind builder Cargo feature #23739

Closed

overlookmotel force-pushed the om/06-18-feat_ast_add_custom_builder_methods_to_ast_types branch from ade064d to 869ada5 Compare June 23, 2026 12:07

overlookmotel force-pushed the om/06-06-feat_ast_add_ast_creation_methods_to_ast_types branch from 5399e65 to 32f725e Compare June 23, 2026 12:07

overlookmotel mentioned this pull request Jun 23, 2026

refactor(ast): add builder Cargo feature #23743

Closed

overlookmotel force-pushed the om/06-06-feat_ast_add_ast_creation_methods_to_ast_types branch from 32f725e to cafc6dd Compare June 24, 2026 16:53

overlookmotel force-pushed the om/06-18-feat_ast_add_custom_builder_methods_to_ast_types branch from 869ada5 to dd42174 Compare June 24, 2026 16:53

overlookmotel requested a review from Copilot June 24, 2026 16:55

Copilot started reviewing on behalf of overlookmotel June 24, 2026 16:55 View session

overlookmotel force-pushed the om/06-06-feat_ast_add_ast_creation_methods_to_ast_types branch from cafc6dd to eae9e61 Compare June 24, 2026 16:56

overlookmotel force-pushed the om/06-18-feat_ast_add_custom_builder_methods_to_ast_types branch from dd42174 to 5ef81a0 Compare June 24, 2026 16:56

Copilot AI reviewed Jun 24, 2026

View reviewed changes

Comment thread crates/oxc_ast/src/builder/custom.rs

Comment thread crates/oxc_ast/src/builder/custom.rs

Comment thread crates/oxc_ast/src/builder/custom.rs

overlookmotel force-pushed the om/06-06-feat_ast_add_ast_creation_methods_to_ast_types branch from eae9e61 to f3b599f Compare June 24, 2026 17:50

overlookmotel force-pushed the om/06-18-feat_ast_add_custom_builder_methods_to_ast_types branch from 5ef81a0 to 1e4a339 Compare June 24, 2026 17:50

overlookmotel marked this pull request as ready for review June 24, 2026 17:51

camc314 approved these changes Jun 24, 2026

View reviewed changes

Dunqing approved these changes Jun 25, 2026

View reviewed changes

graphite-app Bot added the 0-merge Merge with Graphite Merge Queue label Jun 25, 2026

graphite-app Bot force-pushed the om/06-06-feat_ast_add_ast_creation_methods_to_ast_types branch from f3b599f to 05d1357 Compare June 25, 2026 01:45

graphite-app Bot force-pushed the om/06-18-feat_ast_add_custom_builder_methods_to_ast_types branch from 1e4a339 to 785461b Compare June 25, 2026 01:46

Base automatically changed from om/06-06-feat_ast_add_ast_creation_methods_to_ast_types to main June 25, 2026 01:52

graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label Jun 25, 2026

graphite-app Bot merged commit 785461b into main Jun 25, 2026
31 checks passed

graphite-app Bot deleted the om/06-18-feat_ast_add_custom_builder_methods_to_ast_types branch June 25, 2026 01:53

overlookmotel mentioned this pull request Jun 25, 2026

fix(ast): ExportNamedDeclaration plain builder methods return boxed nodes #23783

Merged

oxc-guard Bot mentioned this pull request Jun 29, 2026

release(crates): oxc v0.138.0 #23934

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat(ast): add custom builder methods to AST types#23651

feat(ast): add custom builder methods to AST types#23651
graphite-app[bot] merged 1 commit into
mainfrom
om/06-18-feat_ast_add_custom_builder_methods_to_ast_types

overlookmotel commented Jun 19, 2026 •

edited

Loading

Uh oh!

overlookmotel commented Jun 19, 2026 •

edited

Loading

Uh oh!

codspeed-hq Bot commented Jun 19, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

graphite-app Bot commented Jun 25, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Uh oh!

Conversation

overlookmotel commented Jun 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

overlookmotel commented Jun 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

codspeed-hq Bot commented Jun 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

graphite-app Bot commented Jun 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

overlookmotel commented Jun 19, 2026 •

edited

Loading

overlookmotel commented Jun 19, 2026 •

edited

Loading

codspeed-hq Bot commented Jun 19, 2026 •

edited

Loading

graphite-app Bot commented Jun 25, 2026 •

edited

Loading