Skip to content

feat(ast): add methods to create primitives to new AstBuilder#23729

Closed
overlookmotel wants to merge 1 commit into
graphite-base/23729from
om/06-22-feat_ast_add_methods_to_create_primitives_to_new_astbuilder_
Closed

feat(ast): add methods to create primitives to new AstBuilder#23729
overlookmotel wants to merge 1 commit into
graphite-base/23729from
om/06-22-feat_ast_add_methods_to_create_primitives_to_new_astbuilder_

Conversation

@overlookmotel

@overlookmotel overlookmotel commented Jun 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Part of #23043.

Add methods for creating primitives (Vec, Box, Str, Ident) to new AstBuilder, matching the ones on the old one.

These should not be methods on AstBuilder - call sites should use Vec::with_capacity_in etc instead. But that requires Vec::with_capacity_in to take an &A: &GetAllocator instead of &Allocator.

These methods are a temporary measure to avoid having to make that change right now.

This was referenced Jun 23, 2026
Merged
Merged
Closed
Merged
Merged
Merged
@github-actions github-actions Bot added the A-ast Area - AST label Jun 23, 2026
This was referenced Jun 23, 2026
Merged
Merged
@overlookmotel Graphite App

overlookmotel commented Jun 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Jun 23, 2026
Merged
Merged
@codspeed-hq

codspeed-hq Bot commented Jun 23, 2026 •
edited
Loading

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 62 untouched benchmarks
⏩ 9 skipped benchmarks1

Comparing om/06-22-feat_ast_add_methods_to_create_primitives_to_new_astbuilder_ (431ba1e) with om/06-18-feat_ast_add_custom_builder_methods_to_ast_types (ade064d)2

Open in CodSpeed

Footnotes

  1. 9 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on om/06-18-feat_ast_add_custom_builder_methods_to_ast_types (869ada5) during the generation of this report, so e6b8c28 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@overlookmotel overlookmotel force-pushed the om/06-22-feat_ast_add_methods_to_create_primitives_to_new_astbuilder_ branch from 27489b3 to e512626 Compare June 23, 2026 00:56
@overlookmotel overlookmotel force-pushed the om/06-18-feat_ast_add_custom_builder_methods_to_ast_types branch from 3ae30e6 to 95e4e59 Compare June 23, 2026 00:56
@graphite-app graphite-app Bot force-pushed the om/06-18-feat_ast_add_custom_builder_methods_to_ast_types branch from 95e4e59 to a1c320e Compare June 23, 2026 01:09
@graphite-app graphite-app Bot force-pushed the om/06-22-feat_ast_add_methods_to_create_primitives_to_new_astbuilder_ branch from e512626 to c5d5217 Compare June 23, 2026 01:09
@overlookmotel overlookmotel force-pushed the om/06-18-feat_ast_add_custom_builder_methods_to_ast_types branch from a1c320e to ade064d Compare June 23, 2026 10:46
@overlookmotel overlookmotel force-pushed the om/06-22-feat_ast_add_methods_to_create_primitives_to_new_astbuilder_ branch from c5d5217 to 6b2bb22 Compare June 23, 2026 10:46
@overlookmotel overlookmotel mentioned this pull request Jun 23, 2026
Closed
@overlookmotel overlookmotel force-pushed the om/06-18-feat_ast_add_custom_builder_methods_to_ast_types branch from ade064d to 869ada5 Compare June 23, 2026 12:07
@overlookmotel overlookmotel force-pushed the om/06-22-feat_ast_add_methods_to_create_primitives_to_new_astbuilder_ branch from 6b2bb22 to 431ba1e Compare June 23, 2026 12:07
@overlookmotel overlookmotel mentioned this pull request Jun 23, 2026
Closed
@overlookmotel overlookmotel changed the base branch from om/06-18-feat_ast_add_custom_builder_methods_to_ast_types to graphite-base/23729 June 24, 2026 16:53
@overlookmotel

overlookmotel commented Jun 24, 2026

Copy link
Copy Markdown
Member Author

This is not necessary.

@overlookmotel overlookmotel deleted the om/06-22-feat_ast_add_methods_to_create_primitives_to_new_astbuilder_ branch June 24, 2026 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

No one assigned

Labels

A-ast Area - AST

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@overlookmotel