perf(isolated-declarations): pool scope maps to avoid per-scope alloc/rehash#23761
Conversation
Merging this PR will improve performance by 5.99%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Simulation | isolated-declarations[vue-id.ts] |
52.8 ms | 49.8 ms | +5.99% |
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing perf/isolated-declarations-pool-scopes (f5d24d3) with main (163ed51)2
Footnotes
-
19 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
-
No successful run was found on
main(c8b032e) during the generation of this report, so 163ed51 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
Merge activity
|
…/rehash (#23761) ## What `ScopeTree` (resolves declaration references during `.d.ts` generation) walks a scope **stack**, allocating two fresh `FxHashMap`s on every `enter_scope` and dropping them on leave. ## Why For type-heavy files this is an allocate → grow → rehash → free cycle *per scope*, repeated thousands of times. Profiling the isolated-declarations benchmark (`vue-id.ts`) attributed ~10% of the run to this HashMap churn (`reserve_rehash` 4.4% + entry churn + alloc/free). ## How Scopes are entered and left in a stack pattern, so recycle them: on leave, `drain` / `clear` the maps (which keeps their heap buffer and capacity) and push the scope onto a free-list; on enter, reuse a pooled scope instead of allocating. Behaviour is identical — the maps still start empty. ## Result Interleaved A/B on the isolated-declarations benchmark (`vue-id.ts`): **~13.6% faster** (~5.24 ms → ~4.53 ms, consistent across 3 rounds). All 20 unit + snapshot tests pass (snapshots byte-identical); `cargo clippy` clean. --- _Disclosure: developed with AI assistance (Claude Code). Benchmarks, tests and clippy were run and the change reviewed._
f5d24d3 to
32be105
Compare
…/rehash (#23761) ## What `ScopeTree` (resolves declaration references during `.d.ts` generation) walks a scope **stack**, allocating two fresh `FxHashMap`s on every `enter_scope` and dropping them on leave. ## Why For type-heavy files this is an allocate → grow → rehash → free cycle *per scope*, repeated thousands of times. Profiling the isolated-declarations benchmark (`vue-id.ts`) attributed ~10% of the run to this HashMap churn (`reserve_rehash` 4.4% + entry churn + alloc/free). ## How Scopes are entered and left in a stack pattern, so recycle them: on leave, `drain` / `clear` the maps (which keeps their heap buffer and capacity) and push the scope onto a free-list; on enter, reuse a pooled scope instead of allocating. Behaviour is identical — the maps still start empty. ## Result Interleaved A/B on the isolated-declarations benchmark (`vue-id.ts`): **~13.6% faster** (~5.24 ms → ~4.53 ms, consistent across 3 rounds). All 20 unit + snapshot tests pass (snapshots byte-identical); `cargo clippy` clean. --- _Disclosure: developed with AI assistance (Claude Code). Benchmarks, tests and clippy were run and the change reviewed._
32be105 to
329bbfd
Compare
…/rehash (#23761) ## What `ScopeTree` (resolves declaration references during `.d.ts` generation) walks a scope **stack**, allocating two fresh `FxHashMap`s on every `enter_scope` and dropping them on leave. ## Why For type-heavy files this is an allocate → grow → rehash → free cycle *per scope*, repeated thousands of times. Profiling the isolated-declarations benchmark (`vue-id.ts`) attributed ~10% of the run to this HashMap churn (`reserve_rehash` 4.4% + entry churn + alloc/free). ## How Scopes are entered and left in a stack pattern, so recycle them: on leave, `drain` / `clear` the maps (which keeps their heap buffer and capacity) and push the scope onto a free-list; on enter, reuse a pooled scope instead of allocating. Behaviour is identical — the maps still start empty. ## Result Interleaved A/B on the isolated-declarations benchmark (`vue-id.ts`): **~13.6% faster** (~5.24 ms → ~4.53 ms, consistent across 3 rounds). All 20 unit + snapshot tests pass (snapshots byte-identical); `cargo clippy` clean. --- _Disclosure: developed with AI assistance (Claude Code). Benchmarks, tests and clippy were run and the change reviewed._
329bbfd to
9f6ee3b
Compare
### 💥 BREAKING CHANGES - 94fbacb ast: [**BREAKING**] Only export `AstBuilder` and `NONE` in `builder` module (#23876) (overlookmotel) - 8de5122 ecmascript: [**BREAKING**] Switch to new `AstBuilder` (#23834) (overlookmotel) - dc0ef38 transformer: [**BREAKING**] Switch to new `AstBuilder` (#23831) (overlookmotel) - 88f4455 str: [**BREAKING**] `Str` and `Ident` methods take `&GetAllocator` (#23781) (overlookmotel) - 36009dd allocator: [**BREAKING**] `GetAllocator::allocator` take `&self` (#23676) (overlookmotel) - bd74f9d allocator: [**BREAKING**] Rename `AllocatorAccessor` trait to `GetAllocator` (#23675) (overlookmotel) ### 🚀 Features - 326fe25 transformer_plugins: Support `typeof` `define` keys (#23605) (Alexander Lichter) - f2091b3 ast: Unify old and new `AstBuilder`s (#23875) (overlookmotel) - cd1fd12 codegen: Expose `Codegen::print_string` API (#23785) (camc314) - 785461b ast: Add custom builder methods to AST types (#23651) (overlookmotel) - 05d1357 ast: Add AST creation methods to AST types (#23650) (overlookmotel) - 2580eda str: Add `Str::from_str_in` and `Ident::from_str_in` methods (#23767) (overlookmotel) - 6883fcf minifier: Fold write-once falsy var to false in boolean context (#23540) (Dunqing) - fcbf993 allocator: Add `Vec::from_value_in` method (#23718) (overlookmotel) - 989ddb7 allocator: Add `Vec::from_box_in` method (#23717) (overlookmotel) - 9d1aa7f allocator: Improve `PartialEq` for `Vec` (#23716) (overlookmotel) ### 🐛 Bug Fixes - da0e5bf minifier: Don't reorder a closed-over TDZ read when inlining a var (#23771) (Dunqing) - 0b3021f allocator: Remove `Vec::from_box_in` (#23873) (overlookmotel) - 0ab64ec ast: Silence deprecation warnings within files defining deprecated `AstBuilder` methods (#23889) (overlookmotel) - 8c07cad all: Enable `disable_old_builder` Cargo feature for `oxc_ast` crate in tests (#23888) (overlookmotel) - 3800f01 ast: Legacy `AstBuilder` methods take `self` not `&self` (#23891) (overlookmotel) - 869ac20 semantic/cfg: Connect for update exit to loop test (#23791) (camc314) - d3e92d5 semantic/cfg: Connect while branches from condition exit (#23790) (camc314) - 025045d ast: `ExportNamedDeclaration` plain builder methods return boxed nodes (#23783) (overlookmotel) - 7537c58 ast: Fix name of `AstBuilder` method for `Expression::V8IntrinsicExpression` (#23766) (overlookmotel) - 3f574f5 traverse: Fix unsoundness in `Traverse` walk functions (#23745) (overlookmotel) - 585760f parser: String in AST reference arena (#23721) (overlookmotel) - 7231d55 allocator: Fix unsound lifetime extension in `Box::new_in` (#23685) (overlookmotel) ### ⚡ Performance - d5c916a semantic: Flatten hoisting_variables to avoid per-scope map allocation (#23927) (Lawrence Lin) - e71609d minifier: Bail member-expr folding before the side-effect walk (#23924) (Lawrence Lin) - e1f89ab minifier: Reduce string allocations folding addition (#23846) (overlookmotel) - 9f6ee3b isolated-declarations: Pool scope maps to avoid per-scope alloc/rehash (#23761) (Boshen) - 0b07c4c semantic: Avoid heap alloc for catch-clause binding ids (#23911) (Lawrence Lin) - c5eef8b regular_expression: Skip capturing-group pre-parse when pattern has no `(` (#23908) (Lawrence Lin) - b4f5b4b isolated_declarations: Remove redundant clone of formal parameter pattern (#23912) (Lawrence Lin) - 53d083f isolated_declarations: Use `TakeIn` not `CloneIn` (#23847) (overlookmotel) - 3ea9304 react_compiler: Use faster API to arena allocate strings (#23849) (overlookmotel) - a6d8e45 parser: Avoid span lookup for arrow expression body (#23788) (camc314) - e1886a0 transformer, minifier: Use `static_ident!` macro to create static `Ident`s (#23727) (overlookmotel) - 5527bef transformer/object-rest-spread: Reduce iteration (#23720) (overlookmotel) - 680ffbc transformer: Allocate AST nodes in arena directly (#23711) (overlookmotel) - 1c63c66 parser: Allocate AST nodes in arena directly (#23712) (overlookmotel) - 3855f0c minifier: Allocate AST nodes in arena directly (#23710) (overlookmotel) - d025887 isolated_declarations: Allocate AST nodes in arena directly (#23709) (overlookmotel) - 10b96c6 parser: Remove string search from parsing JSX element name (#23713) (overlookmotel) ### 📚 Documentation - 3d61dea all: Correct capitalization in comments (#23887) (overlookmotel) - aa1ad74 ast: Add `#[deprecated]` to legacy `AstBuilder` methods (#23877) (overlookmotel) - a4676db ast: Correct doc comment for `NONE` (#23765) (overlookmotel) - 419ec80 syntax: Fix typo in doc comment (#23674) (overlookmotel) ### 🛡️ Security - 3cdd18f deps: Update npm packages (#23690) (renovate[bot]) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com> Co-authored-by: Cameron <cameron.clark@hey.com>
…/rehash (#23761) ## What `ScopeTree` (resolves declaration references during `.d.ts` generation) walks a scope **stack**, allocating two fresh `FxHashMap`s on every `enter_scope` and dropping them on leave. ## Why For type-heavy files this is an allocate → grow → rehash → free cycle *per scope*, repeated thousands of times. Profiling the isolated-declarations benchmark (`vue-id.ts`) attributed ~10% of the run to this HashMap churn (`reserve_rehash` 4.4% + entry churn + alloc/free). ## How Scopes are entered and left in a stack pattern, so recycle them: on leave, `drain` / `clear` the maps (which keeps their heap buffer and capacity) and push the scope onto a free-list; on enter, reuse a pooled scope instead of allocating. Behaviour is identical — the maps still start empty. ## Result Interleaved A/B on the isolated-declarations benchmark (`vue-id.ts`): **~13.6% faster** (~5.24 ms → ~4.53 ms, consistent across 3 rounds). All 20 unit + snapshot tests pass (snapshots byte-identical); `cargo clippy` clean. --- _Disclosure: developed with AI assistance (Claude Code). Benchmarks, tests and clippy were run and the change reviewed._
### 💥 BREAKING CHANGES - 94fbacb ast: [**BREAKING**] Only export `AstBuilder` and `NONE` in `builder` module (#23876) (overlookmotel) - 8de5122 ecmascript: [**BREAKING**] Switch to new `AstBuilder` (#23834) (overlookmotel) - dc0ef38 transformer: [**BREAKING**] Switch to new `AstBuilder` (#23831) (overlookmotel) - 88f4455 str: [**BREAKING**] `Str` and `Ident` methods take `&GetAllocator` (#23781) (overlookmotel) - 36009dd allocator: [**BREAKING**] `GetAllocator::allocator` take `&self` (#23676) (overlookmotel) - bd74f9d allocator: [**BREAKING**] Rename `AllocatorAccessor` trait to `GetAllocator` (#23675) (overlookmotel) ### 🚀 Features - 326fe25 transformer_plugins: Support `typeof` `define` keys (#23605) (Alexander Lichter) - f2091b3 ast: Unify old and new `AstBuilder`s (#23875) (overlookmotel) - cd1fd12 codegen: Expose `Codegen::print_string` API (#23785) (camc314) - 785461b ast: Add custom builder methods to AST types (#23651) (overlookmotel) - 05d1357 ast: Add AST creation methods to AST types (#23650) (overlookmotel) - 2580eda str: Add `Str::from_str_in` and `Ident::from_str_in` methods (#23767) (overlookmotel) - 6883fcf minifier: Fold write-once falsy var to false in boolean context (#23540) (Dunqing) - fcbf993 allocator: Add `Vec::from_value_in` method (#23718) (overlookmotel) - 989ddb7 allocator: Add `Vec::from_box_in` method (#23717) (overlookmotel) - 9d1aa7f allocator: Improve `PartialEq` for `Vec` (#23716) (overlookmotel) ### 🐛 Bug Fixes - da0e5bf minifier: Don't reorder a closed-over TDZ read when inlining a var (#23771) (Dunqing) - 0b3021f allocator: Remove `Vec::from_box_in` (#23873) (overlookmotel) - 0ab64ec ast: Silence deprecation warnings within files defining deprecated `AstBuilder` methods (#23889) (overlookmotel) - 8c07cad all: Enable `disable_old_builder` Cargo feature for `oxc_ast` crate in tests (#23888) (overlookmotel) - 3800f01 ast: Legacy `AstBuilder` methods take `self` not `&self` (#23891) (overlookmotel) - 869ac20 semantic/cfg: Connect for update exit to loop test (#23791) (camc314) - d3e92d5 semantic/cfg: Connect while branches from condition exit (#23790) (camc314) - 025045d ast: `ExportNamedDeclaration` plain builder methods return boxed nodes (#23783) (overlookmotel) - 7537c58 ast: Fix name of `AstBuilder` method for `Expression::V8IntrinsicExpression` (#23766) (overlookmotel) - 3f574f5 traverse: Fix unsoundness in `Traverse` walk functions (#23745) (overlookmotel) - 585760f parser: String in AST reference arena (#23721) (overlookmotel) - 7231d55 allocator: Fix unsound lifetime extension in `Box::new_in` (#23685) (overlookmotel) ### ⚡ Performance - d5c916a semantic: Flatten hoisting_variables to avoid per-scope map allocation (#23927) (Lawrence Lin) - e71609d minifier: Bail member-expr folding before the side-effect walk (#23924) (Lawrence Lin) - e1f89ab minifier: Reduce string allocations folding addition (#23846) (overlookmotel) - 9f6ee3b isolated-declarations: Pool scope maps to avoid per-scope alloc/rehash (#23761) (Boshen) - 0b07c4c semantic: Avoid heap alloc for catch-clause binding ids (#23911) (Lawrence Lin) - c5eef8b regular_expression: Skip capturing-group pre-parse when pattern has no `(` (#23908) (Lawrence Lin) - b4f5b4b isolated_declarations: Remove redundant clone of formal parameter pattern (#23912) (Lawrence Lin) - 53d083f isolated_declarations: Use `TakeIn` not `CloneIn` (#23847) (overlookmotel) - 3ea9304 react_compiler: Use faster API to arena allocate strings (#23849) (overlookmotel) - a6d8e45 parser: Avoid span lookup for arrow expression body (#23788) (camc314) - e1886a0 transformer, minifier: Use `static_ident!` macro to create static `Ident`s (#23727) (overlookmotel) - 5527bef transformer/object-rest-spread: Reduce iteration (#23720) (overlookmotel) - 680ffbc transformer: Allocate AST nodes in arena directly (#23711) (overlookmotel) - 1c63c66 parser: Allocate AST nodes in arena directly (#23712) (overlookmotel) - 3855f0c minifier: Allocate AST nodes in arena directly (#23710) (overlookmotel) - d025887 isolated_declarations: Allocate AST nodes in arena directly (#23709) (overlookmotel) - 10b96c6 parser: Remove string search from parsing JSX element name (#23713) (overlookmotel) ### 📚 Documentation - 3d61dea all: Correct capitalization in comments (#23887) (overlookmotel) - aa1ad74 ast: Add `#[deprecated]` to legacy `AstBuilder` methods (#23877) (overlookmotel) - a4676db ast: Correct doc comment for `NONE` (#23765) (overlookmotel) - 419ec80 syntax: Fix typo in doc comment (#23674) (overlookmotel) ### 🛡️ Security - 3cdd18f deps: Update npm packages (#23690) (renovate[bot]) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com> Co-authored-by: Cameron <cameron.clark@hey.com>
What
ScopeTree(resolves declaration references during.d.tsgeneration) walks a scope stack, allocating two freshFxHashMaps on everyenter_scopeand dropping them on leave.Why
For type-heavy files this is an allocate → grow → rehash → free cycle per scope, repeated thousands of times. Profiling the isolated-declarations benchmark (
vue-id.ts) attributed ~10% of the run to this HashMap churn (reserve_rehash4.4% + entry churn + alloc/free).How
Scopes are entered and left in a stack pattern, so recycle them: on leave,
drain/clearthe maps (which keeps their heap buffer and capacity) and push the scope onto a free-list; on enter, reuse a pooled scope instead of allocating. Behaviour is identical — the maps still start empty.Result
Interleaved A/B on the isolated-declarations benchmark (
vue-id.ts): ~13.6% faster (~5.24 ms → ~4.53 ms, consistent across 3 rounds). All 20 unit + snapshot tests pass (snapshots byte-identical);cargo clippyclean.Disclosure: developed with AI assistance (Claude Code). Benchmarks, tests and clippy were run and the change reviewed.