feat(linter): add schema for `eslint/complexity` by Sysix · Pull Request #22960 · oxc-project/oxc

Sysix · 2026-06-04T14:02:49Z

The apps/oxlint/scripts/generate-config-types.ts was generated by AI 🤖

Sysix · 2026-06-04T14:03:12Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2026-06-04T14:10:26Z

Merging this PR will not alter performance

✅ 5 untouched benchmarks
⏩ 61 skipped benchmarks¹

_{Comparing 06-04-feat_linter_add_schema_for_eslint_class-method-use-this_ (bde0565) with 06-04-feat_linter_add_schema_for_eslint_class-emthods-use-this_ (5caa9cd)²}

61 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
No successful run was found on 06-04-feat_linter_add_schema_for_eslint_class-emthods-use-this_ (6bbd747) during the generation of this report, so a5cbb97 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

Copilot

Pull request overview

This PR updates oxlint’s configuration schema generation to include a verified, non-dummy schema for the eslint/complexity rule, and propagates that schema through the generated JSON schema, website snapshot, and JS package TypeScript types.

Changes:

Add ruledocs-only schema generation for eslint/complexity (including number-or-object config support).
Update npm/oxlint/configuration_schema.json (and the website snapshot) to include ComplexityConfig and Variant, and to type complexity correctly instead of DummyRule.
Regenerate apps/oxlint/src-js/package/config.generated.ts to reflect the updated schema/types.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
tasks/website_linter/src/snapshots/schema_json.snap	Updates the schema snapshot to include `ComplexityConfig`/`Variant` and the new `complexity` rule shape.
npm/oxlint/configuration_schema.json	Adds `ComplexityConfig`/`Variant` definitions and switches `complexity` from `DummyRule` to a real schema.
crates/oxc_linter/src/utils/schemars.rs	Removes `eslint/complexity` from the “unverified schema” list.
crates/oxc_linter/src/rules/eslint/complexity.rs	Adds `config_schema()` (ruledocs) and hooks in `number_as_object_schema` for schema generation.
apps/oxlint/src-js/package/config.generated.ts	Regenerates TS types to include `ComplexityConfig`, `Variant`, and the updated `complexity` rule signature.

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

camc314 · 2026-06-07T14:29:29Z

Merge activity

Jun 7, 2:29 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Jun 7, 2:39 PM UTC: camc314 added this pull request to the Graphite merge queue.
Jun 7, 2:45 PM UTC: Merged by the Graphite merge queue.

The `apps/oxlint/scripts/generate-config-types.ts` was generated by AI 🤖

# Oxlint ### 🚀 Features - e805174 linter: Add schema for `jest/vitest/max-expects` (#23105) (Sysix) - 7850577 linter: Add schema for `jest/vitest/expect-expect` (#23104) (Sysix) - 75f641a linter: Add schema for `jest/vitest/consistent-test-it` (#23103) (Sysix) - 5125f89 linter/unicorn: Support no-null `checkArguments` option (#23098) (camc314) - b8b9797 linter: Add schema for `import-max-dependencies` (#23096) (Sysix) - 65cb47a linter/eslint: Support no-unused-expressions `ignoreDirectives` option (#23097) (camc314) - f6c36d5 linter: Add schema for `import/prefer-default-export` (#23091) (Sysix) - 0d4a5d1 linter: Add schema for `eslint/sort-vars` (#23090) (Sysix) - fdb5bf5 linter: Add schema for `eslint/radix` (#23082) (Sysix) - 05b4dcf linter: Add schema for `eslint/prefer-const` (#23081) (Sysix) - 5a06c4d linter/vue: Implement next-tick-style rule (#23041) (Alex Peshkov) - e38a36a linter: Add schema for `eslint/operator-assignment` (#23080) (Sysix) - 907cee7 linter: Add schema for `eslint/no-warning-comments` (#23075) (Sysix) - 9470bb2 linter: Add schema for `eslint/no-unused-vars` (#23073) (Sysix) - 234b5cf linter: Add schema for `eslint/no-shadow` (#23072) (Sysix) - de0dd8b linter: Add schema for `eslint/no-restricted-exports` (#23020) (Sysix) - faa3e0d linter: Add schema for `eslint/no-param-reassign` (#23018) (Sysix) - dbc9c27 linter: Add schema for `eslint/no-magic-numbers` (#23017) (Sysix) - 38d3569 linter: Add schema for `eslint/no-inner-declarations` (#23016) (Sysix) - 008fa41 linter: Add schema for `eslint/no-constant-condition` (#22991) (Sysix) - ca44623 linter: Add schema for `eslint/no-empty-function` (#22988) (Sysix) - 43eb04d linter: Add schema for `eslint/id-match` (#22987) (Sysix) - a800f27 linter: Add schema for `eslint/capitalized-comments` (#22984) (Sysix) - 96e2d32 linter: Add schema for `eslint/id-length` (#22963) (Sysix) - 545493f linter: Add schema for `eslint/complexity` (#22960) (Sysix) - 5f0b558 linter: Add schema for `eslint/class-methods-use-this` (#22959) (Sysix) - 719b720 linter: Add schema for simple rule configurations (#22948) (Sysix) - fd00966 linter: Add right schema for `eslint/max-*` rules (#22923) (Sysix) - 1226d78 linter: Fill schema with rule configurations (#22907) (Sysix) - 8f423c1 linter/vue: Implement `require-direct-export` rule (#17623) (yefan) - 78e915b linter/vue: Implement no-reserved-props rule (#22914) (bab) - 0f200a9 linter/vue: Implement require-prop-types rule (#22083) (Alex Peshkov) - 5da9da9 linter/vue: Implement no-reserved-keys rule (#21780) (bab) - 75e14a8 linter/vue: Implement prop-name-casing rule (#22892) (bab) - 85efabf semantic: Make building the class table optional, off by default (#22862) (Boshen) ### 🐛 Bug Fixes - a49b0cf linter/no-map-spread: Remove ineffective autofix (#22956) (camc314) - cf53285 parser: Report reserved type-declaration names in the parser (#23035) (Boshen) - 0383e61 linter: Fix schema for rules without a config (#22946) (Sysix) - 4d722e0 parser: Report duplicate switch `default` clause in the parser (#23012) (Boshen) - 6cb34b8 linter/plugins: Make spreading `Token` instances keep `loc` property (#22947) (Nicolas Le Cam) - 27de044 linter/plugins: Make spreading `Comment` instances keep `loc` property (#22238) (Nicolas Le Cam) - 742fd0b linter/double-comparisons: Make fixer a suggestion (#22968) (camc314) - 93f4494 linter: Respect default child config plugin when extending parent config (#22903) (Sysix) - 594ed86 linter: Deny unknown options for some rules (#22924) (Sysix) - 3253038 linter/expect-expect: Align default rule options (#22890) (camc314) - bbe44ea linter: Respect default plugins from extended config (#22896) (Sysix) ### ⚡ Performance - 0b7ce7e linter/plugins: Create global prop vars at top level of modules (#22928) (overlookmotel) - 0f7c319 linter/plugins: Define class `#loc` setter functions as `const`s (#22919) (overlookmotel) ### 📚 Documentation - 7b0380d linter: Remove preserve-caught-error note (#22994) (camc314) - dadafe3 oxlint, oxfmt: Mention migrate skills in npm READMEs (#22965) (Boshen) # Oxfmt ### 🚀 Features - 3da77e0 oxfmt: Format `parser:json5` files by `oxc_formatter_json` (#22990) (leaysgur) - c786f0d oxfmt: Format `parser:jsonc` files by `oxc_formatter_json` (#22913) (leaysgur) - 27a6db8 formatter_json: Implement jsonc variant (#22912) (leaysgur) ### 🐛 Bug Fixes - 2aedd52 oxfmt: Avoid JS promise rejects for all TSFN call sites (#23107) (leaysgur) - 01e0871 formatter,formatter_json: Handle PS/LS as line terminator (#22978) (leaysgur) - 23902d9 formatter_json: Handle CR only line breaks (#22977) (leaysgur) - 136b72b formatter_json: Use line_suffix for line comment outside array (#22931) (leaysgur) - 44e40fa formatter_json: Expand line comment inside array (#22911) (leaysgur) - 2c86896 formatter_json: Avoid example binary name collision (#22904) (camc314) ### 📚 Documentation - cc69d8d formatter_json: Update AGENTS.md (#22981) (leaysgur) - 0490721 formatter_json: Update AGENTS.md (#22976) (leaysgur) - dadafe3 oxlint, oxfmt: Mention migrate skills in npm READMEs (#22965) (Boshen) - f88961a oxfmt: Annotate each config option with supported languages (#22953) (leaysgur) - 7e514bf formatter_json: Update AGENTS.md (#22930) (leaysgur) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>

github-actions Bot added A-linter Area - Linter A-cli Area - CLI A-linter-plugins Area - Linter JS plugins labels Jun 4, 2026

Sysix mentioned this pull request Jun 4, 2026

feat(linter): add schema for eslint/class-methods-use-this #22959

Merged

Sysix requested a review from Copilot June 4, 2026 14:04

Copilot started reviewing on behalf of Sysix June 4, 2026 14:04 View session

Sysix mentioned this pull request Jun 4, 2026

linter: verify rule config schemas #22955

Open

Sysix changed the title ~~feat(linter): add schema for eslint/class-method-use-this~~ feat(linter): add schema for eslint/complexity Jun 4, 2026

Copilot AI reviewed Jun 4, 2026

View reviewed changes

Comment thread crates/oxc_linter/src/utils/schemars.rs Outdated

Sysix force-pushed the 06-04-feat_linter_add_schema_for_eslint_class-method-use-this_ branch from 4d5cac5 to b52e22a Compare June 4, 2026 16:02

Sysix requested a review from Copilot June 4, 2026 16:03

Copilot started reviewing on behalf of Sysix June 4, 2026 16:03 View session

Copilot AI reviewed Jun 4, 2026

View reviewed changes

Comment thread npm/oxlint/configuration_schema.json

Sysix marked this pull request as ready for review June 4, 2026 16:07

Sysix requested review from camc314 and overlookmotel as code owners June 4, 2026 16:07

Sysix assigned camc314 Jun 4, 2026

This was referenced Jun 4, 2026

feat(linter): add schema for eslint/id-length #22963

Merged

feat(linter): add schema for eslint/capitalized-comments #22984

Merged

Sysix force-pushed the 06-04-feat_linter_add_schema_for_eslint_class-method-use-this_ branch from b52e22a to db97f24 Compare June 5, 2026 13:16

Sysix force-pushed the 06-04-feat_linter_add_schema_for_eslint_class-emthods-use-this_ branch from fa7cfe1 to 695f009 Compare June 5, 2026 13:16

This was referenced Jun 5, 2026

feat(linter): add schema for eslint/id-match #22987

Merged

feat(linter): add schema for eslint/no-empty-function #22988

Merged

feat(linter): add schema for eslint/no-constant-condition #22991

Merged

graphite-app Bot force-pushed the 06-04-feat_linter_add_schema_for_eslint_class-method-use-this_ branch from 2621270 to c87ee1b Compare June 6, 2026 21:42

Sysix marked this pull request as draft June 6, 2026 21:42

Sysix marked this pull request as ready for review June 6, 2026 21:42

Sysix force-pushed the 06-04-feat_linter_add_schema_for_eslint_class-emthods-use-this_ branch from 5caa9cd to 6bbd747 Compare June 7, 2026 12:32

Sysix force-pushed the 06-04-feat_linter_add_schema_for_eslint_class-method-use-this_ branch from c87ee1b to bde0565 Compare June 7, 2026 12:32

camc314 reviewed Jun 7, 2026

View reviewed changes

Comment thread apps/oxlint/scripts/generate-config-types.ts

camc314 approved these changes Jun 7, 2026

View reviewed changes

camc314 added the 0-merge Merge with Graphite Merge Queue label Jun 7, 2026

graphite-app Bot force-pushed the 06-04-feat_linter_add_schema_for_eslint_class-emthods-use-this_ branch 2 times, most recently from e3a8c5a to 438b545 Compare June 7, 2026 14:29

graphite-app Bot force-pushed the 06-04-feat_linter_add_schema_for_eslint_class-method-use-this_ branch from bde0565 to d1e7041 Compare June 7, 2026 14:29

feat(linter): add schema for eslint/complexity (#22960)

545493f

The `apps/oxlint/scripts/generate-config-types.ts` was generated by AI 🤖

graphite-app Bot force-pushed the 06-04-feat_linter_add_schema_for_eslint_class-emthods-use-this_ branch from 438b545 to 5f0b558 Compare June 7, 2026 14:40

graphite-app Bot force-pushed the 06-04-feat_linter_add_schema_for_eslint_class-method-use-this_ branch from d1e7041 to 545493f Compare June 7, 2026 14:41

Base automatically changed from 06-04-feat_linter_add_schema_for_eslint_class-emthods-use-this_ to main June 7, 2026 14:44

graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label Jun 7, 2026

graphite-app Bot merged commit 545493f into main Jun 7, 2026
31 checks passed

graphite-app Bot deleted the 06-04-feat_linter_add_schema_for_eslint_class-method-use-this_ branch June 7, 2026 14:45

This was referenced Jun 7, 2026

feat(linter): add schema for eslint/sort-vars #23090

Merged

feat(linter): add schema for import/prefer-default-export #23091

Merged

feat(linter): add schema for import-max-dependencies #23096

Merged

oxc-guard Bot mentioned this pull request Jun 8, 2026

release(apps): oxlint v1.69.0 && oxfmt v0.54.0 #23116

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(linter): add schema for `eslint/complexity`#22960

feat(linter): add schema for `eslint/complexity`#22960
graphite-app[bot] merged 1 commit into
mainfrom
06-04-feat_linter_add_schema_for_eslint_class-method-use-this_

Sysix commented Jun 4, 2026 •

edited

Loading

Uh oh!

Sysix commented Jun 4, 2026 •

edited

Loading

Uh oh!

codspeed-hq Bot commented Jun 4, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

camc314 commented Jun 7, 2026 •

edited by graphite-app Bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

Sysix commented Jun 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Sysix commented Jun 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

codspeed-hq Bot commented Jun 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

camc314 commented Jun 7, 2026 • edited by graphite-app Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Sysix commented Jun 4, 2026 •

edited

Loading

Sysix commented Jun 4, 2026 •

edited

Loading

codspeed-hq Bot commented Jun 4, 2026 •

edited

Loading

camc314 commented Jun 7, 2026 •

edited by graphite-app Bot

Loading