feat(linter): add schema for node/callback-return#23039
Closed
Sysix wants to merge 1 commit into
Closed
Conversation
This was referenced Jun 6, 2026
This was referenced Jun 6, 2026
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jun 6, 2026
Merging this PR will not alter performance
Comparing 
Footnotes
|
2ac9af7 to
f4b0dbf
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a verified JSON schema for the node/callback-return rule so it can be included in the generated configuration schema and downstream website/TS artifacts.
Changes:
- Adds a
CallbackReturnschema definition and wires upnode/callback-returnin the generated configuration schema/snapshots. - Updates ruledocs schema generation logic to better handle certain array-shaped rule schemas.
- Removes
node/callback-returnfrom the “no verified valid schema” skip list and updates generated TS config typings.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tasks/website_linter/src/snapshots/schema_json.snap | Snapshot update for the published configuration JSON schema. |
| npm/oxlint/configuration_schema.json | Adds CallbackReturn definition and updates node/callback-return rule schema. |
| crates/oxc_linter/src/utils/schemars.rs | Removes node/callback-return from the skip list for schema generation. |
| crates/oxc_linter/src/config/rules.rs | Adjusts schema generation logic for rule config arrays (severity prefixing, subschema handling). |
| apps/oxlint/src-js/package/config.generated.ts | Updates generated TS interface for node/callback-return config shape. |
f4b0dbf to
732b100
Compare
Comment on lines
+612
to
631
| if let Some(array) = obj.array { | ||
| let array_schema = match array.items.as_ref() { | ||
| // Tuple-style config (e.g. [Mode3, InitDeclarationsConfig]) | ||
| // should become [AllowWarnDeny, Mode3, InitDeclarationsConfig]. | ||
| Some(SingleOrVec::Vec(_)) => { | ||
| prepend_severity_to_array_schema(*array, r#gen) | ||
| } | ||
| // List-style config (e.g. string[]) should stay as a single option | ||
| // after severity: [AllowWarnDeny, string[]]. | ||
| _ => wrap_with_severity_and_single_option( | ||
| Schema::Object(SchemaObject { | ||
| instance_type: Some(InstanceType::Array.into()), | ||
| array: Some(array), | ||
| ..Default::default() | ||
| }), | ||
| r#gen, | ||
| ), | ||
| }; | ||
| return with_toggle_schema(array_schema, r#gen); | ||
| } |
732b100 to
7353446
Compare
8397d7b to
ae7633a
Compare
7353446 to
200a59a
Compare
ae7633a to
e1177e3
Compare
e1177e3 to
8713e1a
Compare
200a59a to
88015a6
Compare
This was referenced Jun 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.