fix(linter): respect default child config plugin when extending parent config by Sysix · Pull Request #22903 · oxc-project/oxc

Sysix · 2026-06-01T18:18:59Z

Follow up from #22896 where we respected the parent (omitted) default plugins.
This PR does the same for the child config, example:

{
 "extends": ["./other-config.json"],
}

Will now enable the default plugins too. This is not detected by the root config, where we always have a plugin vec. See #22788 (review)

fixes #22867

Sysix · 2026-06-01T18:19:16Z

fix(linter): respect default child config plugin when extending parent config #22903 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2026-06-01T18:26:42Z

Merging this PR will not alter performance

✅ 5 untouched benchmarks
⏩ 61 skipped benchmarks¹

_{Comparing 06-01-fix_linter_respect_default_child_config_plugin_when_extending_parent_config (4037631) with main (5da9da9)}

61 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

Copilot

Pull request overview

This PR fixes plugin resolution when a child .oxlintrc extends another config: if the child does not specify plugins, the merged config now preserves the child’s implicit default plugins in addition to any plugins coming from extended (parent) configs.

Changes:

Update Oxlintrc::merge so plugins: None on either side contributes LintPlugins::default() during merge (while still keeping None when both are None).
Adjust/expand config builder tests to cover the “child extends parent without specifying plugins” case and reflect the intended default-plugin behavior.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
crates/oxc_linter/src/config/oxlintrc.rs	Fix `plugins` merge semantics so default plugins aren’t dropped when extending configs.
crates/oxc_linter/src/config/config_builder.rs	Update tests to validate plugin behavior across `extends`, including default-plugin inheritance.

camc314 · 2026-06-03T07:46:29Z

Merge activity

Jun 3, 7:46 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Jun 3, 7:46 AM UTC: camc314 added this pull request to the Graphite merge queue.
Jun 3, 7:51 AM UTC: Merged by the Graphite merge queue.

…t config (#22903) Follow up from #22896 where we respected the parent (omitted) default plugins. This PR does the same for the child config, example: ``` { "extends": ["./other-config.json"], } ``` Will now enable the default plugins too. This is not detected by the root config, where we always have a plugin vec. See #22788 (review) fixes #22867

# Oxlint ### 🚀 Features - e805174 linter: Add schema for `jest/vitest/max-expects` (#23105) (Sysix) - 7850577 linter: Add schema for `jest/vitest/expect-expect` (#23104) (Sysix) - 75f641a linter: Add schema for `jest/vitest/consistent-test-it` (#23103) (Sysix) - 5125f89 linter/unicorn: Support no-null `checkArguments` option (#23098) (camc314) - b8b9797 linter: Add schema for `import-max-dependencies` (#23096) (Sysix) - 65cb47a linter/eslint: Support no-unused-expressions `ignoreDirectives` option (#23097) (camc314) - f6c36d5 linter: Add schema for `import/prefer-default-export` (#23091) (Sysix) - 0d4a5d1 linter: Add schema for `eslint/sort-vars` (#23090) (Sysix) - fdb5bf5 linter: Add schema for `eslint/radix` (#23082) (Sysix) - 05b4dcf linter: Add schema for `eslint/prefer-const` (#23081) (Sysix) - 5a06c4d linter/vue: Implement next-tick-style rule (#23041) (Alex Peshkov) - e38a36a linter: Add schema for `eslint/operator-assignment` (#23080) (Sysix) - 907cee7 linter: Add schema for `eslint/no-warning-comments` (#23075) (Sysix) - 9470bb2 linter: Add schema for `eslint/no-unused-vars` (#23073) (Sysix) - 234b5cf linter: Add schema for `eslint/no-shadow` (#23072) (Sysix) - de0dd8b linter: Add schema for `eslint/no-restricted-exports` (#23020) (Sysix) - faa3e0d linter: Add schema for `eslint/no-param-reassign` (#23018) (Sysix) - dbc9c27 linter: Add schema for `eslint/no-magic-numbers` (#23017) (Sysix) - 38d3569 linter: Add schema for `eslint/no-inner-declarations` (#23016) (Sysix) - 008fa41 linter: Add schema for `eslint/no-constant-condition` (#22991) (Sysix) - ca44623 linter: Add schema for `eslint/no-empty-function` (#22988) (Sysix) - 43eb04d linter: Add schema for `eslint/id-match` (#22987) (Sysix) - a800f27 linter: Add schema for `eslint/capitalized-comments` (#22984) (Sysix) - 96e2d32 linter: Add schema for `eslint/id-length` (#22963) (Sysix) - 545493f linter: Add schema for `eslint/complexity` (#22960) (Sysix) - 5f0b558 linter: Add schema for `eslint/class-methods-use-this` (#22959) (Sysix) - 719b720 linter: Add schema for simple rule configurations (#22948) (Sysix) - fd00966 linter: Add right schema for `eslint/max-*` rules (#22923) (Sysix) - 1226d78 linter: Fill schema with rule configurations (#22907) (Sysix) - 8f423c1 linter/vue: Implement `require-direct-export` rule (#17623) (yefan) - 78e915b linter/vue: Implement no-reserved-props rule (#22914) (bab) - 0f200a9 linter/vue: Implement require-prop-types rule (#22083) (Alex Peshkov) - 5da9da9 linter/vue: Implement no-reserved-keys rule (#21780) (bab) - 75e14a8 linter/vue: Implement prop-name-casing rule (#22892) (bab) - 85efabf semantic: Make building the class table optional, off by default (#22862) (Boshen) ### 🐛 Bug Fixes - a49b0cf linter/no-map-spread: Remove ineffective autofix (#22956) (camc314) - cf53285 parser: Report reserved type-declaration names in the parser (#23035) (Boshen) - 0383e61 linter: Fix schema for rules without a config (#22946) (Sysix) - 4d722e0 parser: Report duplicate switch `default` clause in the parser (#23012) (Boshen) - 6cb34b8 linter/plugins: Make spreading `Token` instances keep `loc` property (#22947) (Nicolas Le Cam) - 27de044 linter/plugins: Make spreading `Comment` instances keep `loc` property (#22238) (Nicolas Le Cam) - 742fd0b linter/double-comparisons: Make fixer a suggestion (#22968) (camc314) - 93f4494 linter: Respect default child config plugin when extending parent config (#22903) (Sysix) - 594ed86 linter: Deny unknown options for some rules (#22924) (Sysix) - 3253038 linter/expect-expect: Align default rule options (#22890) (camc314) - bbe44ea linter: Respect default plugins from extended config (#22896) (Sysix) ### ⚡ Performance - 0b7ce7e linter/plugins: Create global prop vars at top level of modules (#22928) (overlookmotel) - 0f7c319 linter/plugins: Define class `#loc` setter functions as `const`s (#22919) (overlookmotel) ### 📚 Documentation - 7b0380d linter: Remove preserve-caught-error note (#22994) (camc314) - dadafe3 oxlint, oxfmt: Mention migrate skills in npm READMEs (#22965) (Boshen) # Oxfmt ### 🚀 Features - 3da77e0 oxfmt: Format `parser:json5` files by `oxc_formatter_json` (#22990) (leaysgur) - c786f0d oxfmt: Format `parser:jsonc` files by `oxc_formatter_json` (#22913) (leaysgur) - 27a6db8 formatter_json: Implement jsonc variant (#22912) (leaysgur) ### 🐛 Bug Fixes - 2aedd52 oxfmt: Avoid JS promise rejects for all TSFN call sites (#23107) (leaysgur) - 01e0871 formatter,formatter_json: Handle PS/LS as line terminator (#22978) (leaysgur) - 23902d9 formatter_json: Handle CR only line breaks (#22977) (leaysgur) - 136b72b formatter_json: Use line_suffix for line comment outside array (#22931) (leaysgur) - 44e40fa formatter_json: Expand line comment inside array (#22911) (leaysgur) - 2c86896 formatter_json: Avoid example binary name collision (#22904) (camc314) ### 📚 Documentation - cc69d8d formatter_json: Update AGENTS.md (#22981) (leaysgur) - 0490721 formatter_json: Update AGENTS.md (#22976) (leaysgur) - dadafe3 oxlint, oxfmt: Mention migrate skills in npm READMEs (#22965) (Boshen) - f88961a oxfmt: Annotate each config option with supported languages (#22953) (leaysgur) - 7e514bf formatter_json: Update AGENTS.md (#22930) (leaysgur) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>

github-actions Bot added the A-linter Area - Linter label Jun 1, 2026

Sysix requested a review from Copilot June 1, 2026 18:22

Copilot started reviewing on behalf of Sysix June 1, 2026 18:22 View session

Copilot AI reviewed Jun 1, 2026

View reviewed changes

Comment thread crates/oxc_linter/src/config/config_builder.rs

Comment thread crates/oxc_linter/src/config/config_builder.rs

Sysix marked this pull request as ready for review June 1, 2026 18:35

Sysix requested a review from camc314 as a code owner June 1, 2026 18:35

Sysix assigned camc314 Jun 1, 2026

camc314 approved these changes Jun 3, 2026

View reviewed changes

camc314 added the 0-merge Merge with Graphite Merge Queue label Jun 3, 2026

graphite-app Bot force-pushed the 06-01-fix_linter_respect_default_child_config_plugin_when_extending_parent_config branch from 4037631 to 93f4494 Compare June 3, 2026 07:46

camc314 mentioned this pull request Jun 3, 2026

Oxlint nested .oxlintrc.json is not applied when it runs oxlint from workspace root. #22867

Closed

graphite-app Bot merged commit 93f4494 into main Jun 3, 2026
29 checks passed

graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label Jun 3, 2026

graphite-app Bot deleted the 06-01-fix_linter_respect_default_child_config_plugin_when_extending_parent_config branch June 3, 2026 07:51

oxc-guard Bot mentioned this pull request Jun 8, 2026

release(apps): oxlint v1.69.0 && oxfmt v0.54.0 #23116

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(linter): respect default child config plugin when extending parent config#22903

fix(linter): respect default child config plugin when extending parent config#22903
graphite-app[bot] merged 1 commit into
mainfrom
06-01-fix_linter_respect_default_child_config_plugin_when_extending_parent_config

Sysix commented Jun 1, 2026 •

edited by camc314

Loading

Uh oh!

Sysix commented Jun 1, 2026

Uh oh!

codspeed-hq Bot commented Jun 1, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

camc314 commented Jun 3, 2026 •

edited by graphite-app Bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

Sysix commented Jun 1, 2026 • edited by camc314 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Sysix commented Jun 1, 2026

How to use the Graphite Merge Queue

Uh oh!

codspeed-hq Bot commented Jun 1, 2026

Merging this PR will not alter performance

Footnotes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

camc314 commented Jun 3, 2026 • edited by graphite-app Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Sysix commented Jun 1, 2026 •

edited by camc314

Loading

camc314 commented Jun 3, 2026 •

edited by graphite-app Bot

Loading