feat(linter/vue): implement `require-direct-export` rule by huangtiandi1999 · Pull Request #17623 · oxc-project/oxc

huangtiandi1999 · 2026-01-04T09:48:06Z

related #11440

codspeed-hq · 2026-01-04T09:54:08Z

Merging this PR will not alter performance

✅ 5 untouched benchmarks
⏩ 61 skipped benchmarks¹

_{Comparing huangtiandi1999:feat/linter/vue/require-direct-export (980c8c4) with main (1bc5000)}

61 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

connorshea

A few suggestions for how the config options are handled

huangtiandi1999 · 2026-01-05T02:21:19Z

Hi @connorshea
Thanks for the review, I've pushed updates addressing all your comments.

huangtiandi1999 · 2026-01-08T11:46:19Z

@camc314 Thans for your review, I've switched to a Visit-based approach (ReturnFinder). It now correctly traverses the entire function body to find any valid return argument.

connorshea

The docs part of things looks good to me.

…re-direct-export # Conflicts: # crates/oxc_linter/src/generated/rule_runner_impls.rs # crates/oxc_linter/src/generated/rules_enum.rs # crates/oxc_linter/src/rules.rs

camc314

thank you!

# Oxlint ### 🚀 Features - e805174 linter: Add schema for `jest/vitest/max-expects` (#23105) (Sysix) - 7850577 linter: Add schema for `jest/vitest/expect-expect` (#23104) (Sysix) - 75f641a linter: Add schema for `jest/vitest/consistent-test-it` (#23103) (Sysix) - 5125f89 linter/unicorn: Support no-null `checkArguments` option (#23098) (camc314) - b8b9797 linter: Add schema for `import-max-dependencies` (#23096) (Sysix) - 65cb47a linter/eslint: Support no-unused-expressions `ignoreDirectives` option (#23097) (camc314) - f6c36d5 linter: Add schema for `import/prefer-default-export` (#23091) (Sysix) - 0d4a5d1 linter: Add schema for `eslint/sort-vars` (#23090) (Sysix) - fdb5bf5 linter: Add schema for `eslint/radix` (#23082) (Sysix) - 05b4dcf linter: Add schema for `eslint/prefer-const` (#23081) (Sysix) - 5a06c4d linter/vue: Implement next-tick-style rule (#23041) (Alex Peshkov) - e38a36a linter: Add schema for `eslint/operator-assignment` (#23080) (Sysix) - 907cee7 linter: Add schema for `eslint/no-warning-comments` (#23075) (Sysix) - 9470bb2 linter: Add schema for `eslint/no-unused-vars` (#23073) (Sysix) - 234b5cf linter: Add schema for `eslint/no-shadow` (#23072) (Sysix) - de0dd8b linter: Add schema for `eslint/no-restricted-exports` (#23020) (Sysix) - faa3e0d linter: Add schema for `eslint/no-param-reassign` (#23018) (Sysix) - dbc9c27 linter: Add schema for `eslint/no-magic-numbers` (#23017) (Sysix) - 38d3569 linter: Add schema for `eslint/no-inner-declarations` (#23016) (Sysix) - 008fa41 linter: Add schema for `eslint/no-constant-condition` (#22991) (Sysix) - ca44623 linter: Add schema for `eslint/no-empty-function` (#22988) (Sysix) - 43eb04d linter: Add schema for `eslint/id-match` (#22987) (Sysix) - a800f27 linter: Add schema for `eslint/capitalized-comments` (#22984) (Sysix) - 96e2d32 linter: Add schema for `eslint/id-length` (#22963) (Sysix) - 545493f linter: Add schema for `eslint/complexity` (#22960) (Sysix) - 5f0b558 linter: Add schema for `eslint/class-methods-use-this` (#22959) (Sysix) - 719b720 linter: Add schema for simple rule configurations (#22948) (Sysix) - fd00966 linter: Add right schema for `eslint/max-*` rules (#22923) (Sysix) - 1226d78 linter: Fill schema with rule configurations (#22907) (Sysix) - 8f423c1 linter/vue: Implement `require-direct-export` rule (#17623) (yefan) - 78e915b linter/vue: Implement no-reserved-props rule (#22914) (bab) - 0f200a9 linter/vue: Implement require-prop-types rule (#22083) (Alex Peshkov) - 5da9da9 linter/vue: Implement no-reserved-keys rule (#21780) (bab) - 75e14a8 linter/vue: Implement prop-name-casing rule (#22892) (bab) - 85efabf semantic: Make building the class table optional, off by default (#22862) (Boshen) ### 🐛 Bug Fixes - a49b0cf linter/no-map-spread: Remove ineffective autofix (#22956) (camc314) - cf53285 parser: Report reserved type-declaration names in the parser (#23035) (Boshen) - 0383e61 linter: Fix schema for rules without a config (#22946) (Sysix) - 4d722e0 parser: Report duplicate switch `default` clause in the parser (#23012) (Boshen) - 6cb34b8 linter/plugins: Make spreading `Token` instances keep `loc` property (#22947) (Nicolas Le Cam) - 27de044 linter/plugins: Make spreading `Comment` instances keep `loc` property (#22238) (Nicolas Le Cam) - 742fd0b linter/double-comparisons: Make fixer a suggestion (#22968) (camc314) - 93f4494 linter: Respect default child config plugin when extending parent config (#22903) (Sysix) - 594ed86 linter: Deny unknown options for some rules (#22924) (Sysix) - 3253038 linter/expect-expect: Align default rule options (#22890) (camc314) - bbe44ea linter: Respect default plugins from extended config (#22896) (Sysix) ### ⚡ Performance - 0b7ce7e linter/plugins: Create global prop vars at top level of modules (#22928) (overlookmotel) - 0f7c319 linter/plugins: Define class `#loc` setter functions as `const`s (#22919) (overlookmotel) ### 📚 Documentation - 7b0380d linter: Remove preserve-caught-error note (#22994) (camc314) - dadafe3 oxlint, oxfmt: Mention migrate skills in npm READMEs (#22965) (Boshen) # Oxfmt ### 🚀 Features - 3da77e0 oxfmt: Format `parser:json5` files by `oxc_formatter_json` (#22990) (leaysgur) - c786f0d oxfmt: Format `parser:jsonc` files by `oxc_formatter_json` (#22913) (leaysgur) - 27a6db8 formatter_json: Implement jsonc variant (#22912) (leaysgur) ### 🐛 Bug Fixes - 2aedd52 oxfmt: Avoid JS promise rejects for all TSFN call sites (#23107) (leaysgur) - 01e0871 formatter,formatter_json: Handle PS/LS as line terminator (#22978) (leaysgur) - 23902d9 formatter_json: Handle CR only line breaks (#22977) (leaysgur) - 136b72b formatter_json: Use line_suffix for line comment outside array (#22931) (leaysgur) - 44e40fa formatter_json: Expand line comment inside array (#22911) (leaysgur) - 2c86896 formatter_json: Avoid example binary name collision (#22904) (camc314) ### 📚 Documentation - cc69d8d formatter_json: Update AGENTS.md (#22981) (leaysgur) - 0490721 formatter_json: Update AGENTS.md (#22976) (leaysgur) - dadafe3 oxlint, oxfmt: Mention migrate skills in npm READMEs (#22965) (Boshen) - f88961a oxfmt: Annotate each config option with supported languages (#22953) (leaysgur) - 7e514bf formatter_json: Update AGENTS.md (#22930) (leaysgur) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>

huangtiandi1999 requested a review from camc314 as a code owner January 4, 2026 09:48

github-actions Bot added A-linter Area - Linter C-enhancement Category - New feature or request labels Jan 4, 2026

connorshea requested changes Jan 4, 2026

View reviewed changes

Comment thread crates/oxc_linter/src/rules/vue/require_direct_export.rs Outdated

Comment thread crates/oxc_linter/src/rules/vue/require_direct_export.rs

Comment thread crates/oxc_linter/src/rules/vue/require_direct_export.rs

connorshea self-requested a review January 5, 2026 04:20

camc314 self-assigned this Jan 5, 2026

camc314 reviewed Jan 7, 2026

View reviewed changes

Comment thread crates/oxc_linter/src/rules/vue/require_direct_export.rs Outdated

camc314 requested changes Jan 7, 2026

View reviewed changes

Comment thread crates/oxc_linter/src/rules/vue/require_direct_export.rs Outdated

huangtiandi1999 requested a review from camc314 January 8, 2026 11:46

connorshea approved these changes Jan 17, 2026

View reviewed changes

huangtiandi1999 and others added 7 commits February 1, 2026 12:21

implement

6289a22

fix

ac80a53

fix

3933fd6

Update rule config parsing to match current conventions.

f11a071

Fix minor issue.

f1e9e18

Regenerate rulegen-related code.

c8e5b50

Fix indentation for rule tests.

35c186f

connorshea force-pushed the feat/linter/vue/require-direct-export branch from 1a15abf to 35c186f Compare February 1, 2026 19:30

Regenerate rule files.

57b4e45

camc314 changed the title ~~feat(linter/vue): add vue/require-direct-export rule~~ feat(linter/vue): implement require-direct-export rule Jun 2, 2026

camc314 added 5 commits June 2, 2026 18:52

Merge remote-tracking branch 'origin/main' into feat/linter/vue/requi…

25b6a2b

…re-direct-export # Conflicts: # crates/oxc_linter/src/generated/rule_runner_impls.rs # crates/oxc_linter/src/generated/rules_enum.rs # crates/oxc_linter/src/rules.rs

add missing version = "next",

1361b7a

regenerate linter snap

8efa1c2

update snap

95e124e

update config.generated.ts

2dcb0bf

camc314 requested a review from overlookmotel as a code owner June 2, 2026 18:01

reorder imports

86df0ea

camc314 added 2 commits June 2, 2026 19:07

align with upstream

8d2d43b

align with upstream

f3fc29c

camc314 approved these changes Jun 2, 2026

View reviewed changes

lint

980c8c4

camc314 merged commit 8f423c1 into oxc-project:main Jun 2, 2026
29 checks passed

oxc-guard Bot mentioned this pull request Jun 8, 2026

release(apps): oxlint v1.69.0 && oxfmt v0.54.0 #23116

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(linter/vue): implement `require-direct-export` rule#17623

feat(linter/vue): implement `require-direct-export` rule#17623
camc314 merged 17 commits into
oxc-project:mainfrom
huangtiandi1999:feat/linter/vue/require-direct-export

huangtiandi1999 commented Jan 4, 2026

Uh oh!

codspeed-hq Bot commented Jan 4, 2026 •

edited

Loading

Uh oh!

connorshea left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

huangtiandi1999 commented Jan 5, 2026

Uh oh!

Uh oh!

Uh oh!

huangtiandi1999 commented Jan 8, 2026

Uh oh!

connorshea left a comment

Uh oh!

camc314 left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

huangtiandi1999 commented Jan 4, 2026

Uh oh!

codspeed-hq Bot commented Jan 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

connorshea left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

huangtiandi1999 commented Jan 5, 2026

Uh oh!

Uh oh!

Uh oh!

huangtiandi1999 commented Jan 8, 2026

Uh oh!

connorshea left a comment

Choose a reason for hiding this comment

Uh oh!

camc314 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codspeed-hq Bot commented Jan 4, 2026 •

edited

Loading