feat(semantic): improve error message to add # for private identifiers#17779
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Pull request overview
This pull request improves error messages for private class identifiers by adding the # prefix to match the format used by Chrome DevTools. The change affects two types of error messages: undeclared private fields and duplicate private identifier declarations.
- Updated error messages to include
#prefix for private identifiers - Modified duplicate class element checking to format private identifier names
- Updated all test snapshots to reflect the new error message format
Reviewed changes
Copilot reviewed 2 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| crates/oxc_semantic/src/diagnostics.rs | Added # prefix to private field undeclared error message |
| crates/oxc_semantic/src/checker/javascript.rs | Added logic to format private identifier names with # prefix for duplicate declaration errors |
| tasks/coverage/snapshots/parser_typescript.snap | Updated test snapshots with new error message format |
| tasks/coverage/snapshots/parser_test262.snap | Updated test snapshots with new error message format |
| tasks/coverage/snapshots/parser_misc.snap | Updated test snapshots with new error message format |
| tasks/coverage/snapshots/parser_babel.snap | Updated test snapshots with new error message format |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Merging this PR will not alter performanceSummary
Comparing 
Footnotes
|
077b170 to
f31e6c1
Compare
Merge activity
|
…ers (#17779) ```js class A { #a; #a } ``` Chrome devtool throws: `VM411:3 Uncaught SyntaxError: Identifier '#a' has already been declared`
f31e6c1 to
2261e6e
Compare
### 🚀 Features - 10426af codegen: Print soft space between inline block comments on the same line (#17799) (camc314) - 2261e6e semantic: Improve error message to add `#` for private identifiers (#17779) (Dunqing) ### 🐛 Bug Fixes - 7422b7e parser/trivia: Correctly mark whether a block comment is on a newline (#17754) (camc314) - c32e8d5 codegen: Wrap `TSAsExpression` in parens when used with in/instanceof operators (#17752) (camc314) - 5755b2d semantic: Report duplicate private identifier for static and instance elements (#17591) (camc314) - 0600df3 isolated_declarations: Only print jsdoc comments (#17748) (camc314) - ef7e014 parser: Preserve `@__NO_SIDE_EFFECTS__` annotation with parenthesized expressions (#17711) (camc314) - 59a6228 parser: Detect TS1363 error for type-only imports with mixed default and named/namespace bindings (#17712) (Copilot) ### ⚡ Performance - 864f1fa semantic: Mark duplicate class element error reporting as cold (#17746) (camc314) - 3a452b8 semantic: Use smallvec for storing reference IDs (#17731) (camchenry) - d5979dc minifier: Do not allocate when checking to convert `const` to `let` (#17730) (camchenry) - 3f4429c parser: Do not re-allocate TS interface heritage (#17692) (camchenry) ### 📚 Documentation - 120a27c minifier: Add prettier-ignore for js-in-md part (#17687) (leaysgur) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Chrome devtool throws:
VM411:3 Uncaught SyntaxError: Identifier '#a' has already been declared