fix(parser/trivia): correctly mark whether a block comment is on a newline#17754
Merged
graphite-app[bot] merged 1 commit intomainfrom Jan 8, 2026
Merged
fix(parser/trivia): correctly mark whether a block comment is on a newline#17754graphite-app[bot] merged 1 commit intomainfrom
graphite-app[bot] merged 1 commit intomainfrom
Conversation
Contributor
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
3e0dff7 to
40899ee
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the parser's trivia builder where block comments were incorrectly marked as being preceded by a newline. The fix introduces a separate tracking field saw_newline_for_comment to distinguish between newlines for trailing comment detection versus newlines for setting the preceded_by_newline metadata on comments.
Key changes:
- Added
saw_newline_for_commentfield to track newlines since the last comment or token, separate fromsaw_newlinewhich only tracks since the last token - Updated logic to correctly reset
saw_newline_for_commentafter block comments (but not line comments) - Added test case for consecutive block comments to verify the fix
Reviewed changes
Copilot reviewed 3 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| crates/oxc_parser/src/lexer/trivia_builder.rs | Adds saw_newline_for_comment field and updates logic to correctly track whether block comments are preceded by newlines |
| crates/oxc_codegen/tests/integration/comments.rs | Adds new test case for consecutive block comments |
| crates/oxc_codegen/tests/integration/snapshots/misc_comments.snap | Snapshot for the new test showing expected output |
| tasks/coverage/snapshots/transformer_babel.snap | Improved test pass rate from 99.87% to 99.96% due to the fix |
| tasks/coverage/snapshots/minifier_babel.snap | Improved test pass rate from 99.89% to 100.00% due to the fix |
| tasks/coverage/snapshots/codegen_babel.snap | Improved test pass rate from 99.91% to 100.00% due to the fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
40899ee to
def421c
Compare
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
Footnotes
|
def421c to
24aac35
Compare
24aac35 to
a6a5c3c
Compare
Member
Merge activity
|
a6a5c3c to
c32e8d5
Compare
96adcca to
7422b7e
Compare
Base automatically changed from
c/01-07-fix_codegen_wrap_tsasexpression_in_parens_when_used_with_in_instanceof_operators
to
main
January 8, 2026 12:40
Dunqing
pushed a commit
that referenced
this pull request
Jan 12, 2026
### 🚀 Features - 10426af codegen: Print soft space between inline block comments on the same line (#17799) (camc314) - 2261e6e semantic: Improve error message to add `#` for private identifiers (#17779) (Dunqing) ### 🐛 Bug Fixes - 7422b7e parser/trivia: Correctly mark whether a block comment is on a newline (#17754) (camc314) - c32e8d5 codegen: Wrap `TSAsExpression` in parens when used with in/instanceof operators (#17752) (camc314) - 5755b2d semantic: Report duplicate private identifier for static and instance elements (#17591) (camc314) - 0600df3 isolated_declarations: Only print jsdoc comments (#17748) (camc314) - ef7e014 parser: Preserve `@__NO_SIDE_EFFECTS__` annotation with parenthesized expressions (#17711) (camc314) - 59a6228 parser: Detect TS1363 error for type-only imports with mixed default and named/namespace bindings (#17712) (Copilot) ### ⚡ Performance - 864f1fa semantic: Mark duplicate class element error reporting as cold (#17746) (camc314) - 3a452b8 semantic: Use smallvec for storing reference IDs (#17731) (camchenry) - d5979dc minifier: Do not allocate when checking to convert `const` to `let` (#17730) (camchenry) - 3f4429c parser: Do not re-allocate TS interface heritage (#17692) (camchenry) ### 📚 Documentation - 120a27c minifier: Add prettier-ignore for js-in-md part (#17687) (leaysgur) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI is green(er) https://github.com/oxc-project/monitor-oxc/actions/runs/20788815777/job/59705840652