Skip to content

perf(semantic): mark duplicate class element error reporting as cold#17746

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/01-07-perf_semantic_mark_duplicate_class_element_error_reporting_as_cold
Jan 8, 2026
Merged

perf(semantic): mark duplicate class element error reporting as cold#17746
graphite-app[bot] merged 1 commit intomainfrom
c/01-07-perf_semantic_mark_duplicate_class_element_error_reporting_as_cold

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Jan 7, 2026

No description provided.

@github-actions github-actions bot added A-semantic Area - Semantic C-performance Category - Solution not expected to change functional behavior, only performance labels Jan 7, 2026
Copy link
Contributor Author

camc314 commented Jan 7, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 7, 2026

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing c/01-07-perf_semantic_mark_duplicate_class_element_error_reporting_as_cold (e42d220) with c/01-02-fix_semantic_report_duplicate_private_identifier_for_static_and_instance_elements (d8129a7)

Summary

✅ 42 untouched benchmarks
⏩ 3 skipped benchmarks1

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@camc314 camc314 marked this pull request as ready for review January 7, 2026 10:54
@camc314 camc314 requested a review from Dunqing as a code owner January 7, 2026 10:54
@Dunqing Dunqing added the 0-merge Merge with Graphite Merge Queue label Jan 8, 2026
Copy link
Member

Dunqing commented Jan 8, 2026

Merge activity

@graphite-app graphite-app bot force-pushed the c/01-02-fix_semantic_report_duplicate_private_identifier_for_static_and_instance_elements branch from d8129a7 to 5755b2d Compare January 8, 2026 03:02
@graphite-app graphite-app bot force-pushed the c/01-07-perf_semantic_mark_duplicate_class_element_error_reporting_as_cold branch from e42d220 to 864f1fa Compare January 8, 2026 03:03
Base automatically changed from c/01-02-fix_semantic_report_duplicate_private_identifier_for_static_and_instance_elements to main January 8, 2026 03:09
@graphite-app graphite-app bot merged commit 864f1fa into main Jan 8, 2026
21 checks passed
@graphite-app graphite-app bot deleted the c/01-07-perf_semantic_mark_duplicate_class_element_error_reporting_as_cold branch January 8, 2026 03:09
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jan 8, 2026
Dunqing pushed a commit that referenced this pull request Jan 12, 2026
### 🚀 Features

- 10426af codegen: Print soft space between inline block comments on the
same line (#17799) (camc314)
- 2261e6e semantic: Improve error message to add `#` for private
identifiers (#17779) (Dunqing)

### 🐛 Bug Fixes

- 7422b7e parser/trivia: Correctly mark whether a block comment is on a
newline (#17754) (camc314)
- c32e8d5 codegen: Wrap `TSAsExpression` in parens when used with
in/instanceof operators (#17752) (camc314)
- 5755b2d semantic: Report duplicate private identifier for static and
instance elements (#17591) (camc314)
- 0600df3 isolated_declarations: Only print jsdoc comments (#17748)
(camc314)
- ef7e014 parser: Preserve `@__NO_SIDE_EFFECTS__` annotation with
parenthesized expressions (#17711) (camc314)
- 59a6228 parser: Detect TS1363 error for type-only imports with mixed
default and named/namespace bindings (#17712) (Copilot)

### ⚡ Performance

- 864f1fa semantic: Mark duplicate class element error reporting as cold
(#17746) (camc314)
- 3a452b8 semantic: Use smallvec for storing reference IDs (#17731)
(camchenry)
- d5979dc minifier: Do not allocate when checking to convert `const` to
`let` (#17730) (camchenry)
- 3f4429c parser: Do not re-allocate TS interface heritage (#17692)
(camchenry)

### 📚 Documentation

- 120a27c minifier: Add prettier-ignore for js-in-md part (#17687)
(leaysgur)

Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-semantic Area - Semantic C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants