perf(parser): do not re-allocate TS interface heritage#17692
Merged
graphite-app[bot] merged 1 commit intomainfrom Jan 6, 2026
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
5464329 to
10375f4
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the TypeScript interface heritage parsing to reduce memory allocations by eliminating an unnecessary intermediate representation. Instead of parsing heritage clauses into tuples and then reconstructing TSInterfaceHeritage objects, the parser now directly returns TSInterfaceHeritage objects using the AstBuilder API.
Key changes:
- Updated
parse_extends_clauseto useAstBuilder::ts_interface_heritageand returnTSInterfaceHeritageobjects directly - Simplified heritage clause handling in TypeScript interface parsing by removing the intermediate tuple-to-struct mapping
- Reduced arena allocations as evidenced by the snapshot changes (1 allocation saved in checker.ts, 3 in cal.com.tsx)
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
tasks/track_memory_allocations/allocs_parser.snap |
Updated allocation benchmarks showing reduction in arena allocations for test files |
crates/oxc_parser/src/ts/statement.rs |
Simplified interface declaration parsing by removing the tuple-to-TSInterfaceHeritage mapping step |
crates/oxc_parser/src/js/class.rs |
Refactored parse_extends_clause to return TSInterfaceHeritage directly and use AstBuilder API; updated heritage clause parsing and class parsing to use the new structure |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
CodSpeed Performance ReportMerging #17692 will not alter performanceComparing Summary
Footnotes
|
Dunqing
approved these changes
Jan 6, 2026
Member
Merge activity
|
- related to oxc-project/backlog#74 this was a small refactor that came out of removing the extra pass for counting nodes in semantic. this is the only place (as far as I can tell) that we don't use the `AstBuilder` functions in the parser. - updated parsing code to use `AstBuilder` instead of `TSInterfaceHeritage { ... }` directly - reduced allocations by returning `TSInterfaceHeritage` directly from parsing functions, instead of its constituent data
10375f4 to
3f4429c
Compare
Dunqing
pushed a commit
that referenced
this pull request
Jan 12, 2026
### 🚀 Features - 10426af codegen: Print soft space between inline block comments on the same line (#17799) (camc314) - 2261e6e semantic: Improve error message to add `#` for private identifiers (#17779) (Dunqing) ### 🐛 Bug Fixes - 7422b7e parser/trivia: Correctly mark whether a block comment is on a newline (#17754) (camc314) - c32e8d5 codegen: Wrap `TSAsExpression` in parens when used with in/instanceof operators (#17752) (camc314) - 5755b2d semantic: Report duplicate private identifier for static and instance elements (#17591) (camc314) - 0600df3 isolated_declarations: Only print jsdoc comments (#17748) (camc314) - ef7e014 parser: Preserve `@__NO_SIDE_EFFECTS__` annotation with parenthesized expressions (#17711) (camc314) - 59a6228 parser: Detect TS1363 error for type-only imports with mixed default and named/namespace bindings (#17712) (Copilot) ### ⚡ Performance - 864f1fa semantic: Mark duplicate class element error reporting as cold (#17746) (camc314) - 3a452b8 semantic: Use smallvec for storing reference IDs (#17731) (camchenry) - d5979dc minifier: Do not allocate when checking to convert `const` to `let` (#17730) (camchenry) - 3f4429c parser: Do not re-allocate TS interface heritage (#17692) (camchenry) ### 📚 Documentation - 120a27c minifier: Add prettier-ignore for js-in-md part (#17687) (leaysgur) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this was a small refactor that came out of removing the extra pass for counting nodes in semantic. this is the only place (as far as I can tell) that we don't use the
AstBuilderfunctions in the parser.AstBuilderinstead ofTSInterfaceHeritage { ... }directlyTSInterfaceHeritagedirectly from parsing functions, instead of its constituent data