Skip to content

docs(minifier): Add prettier-ignore for js-in-md part#17687

Merged
graphite-app[bot] merged 1 commit intomainfrom
01-06-docs_minifier_add_prettier-ignore_for_js-in-md_part
Jan 6, 2026
Merged

docs(minifier): Add prettier-ignore for js-in-md part#17687
graphite-app[bot] merged 1 commit intomainfrom
01-06-docs_minifier_add_prettier-ignore_for_js-in-md_part

Conversation

@leaysgur
Copy link
Member

@leaysgur leaysgur commented Jan 6, 2026

Follow up #17679 (comment)

Copilot AI review requested due to automatic review settings January 6, 2026 01:57
@github-actions github-actions bot added A-minifier Area - Minifier C-docs Category - Documentation. Related to user-facing or internal documentation labels Jan 6, 2026
Copy link
Member Author

leaysgur commented Jan 6, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@leaysgur leaysgur added the 0-merge Merge with Graphite Merge Queue label Jan 6, 2026
Copy link
Member Author

leaysgur commented Jan 6, 2026

Merge activity

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds Prettier ignore directives to prevent automatic formatting of specific JavaScript code examples in the minifier optimization documentation. Prettier was incorrectly wrapping certain JavaScript expressions in parentheses, which misrepresented the actual minified output.

  • Added <!-- prettier-ignore-start --> and <!-- prettier-ignore-end --> comments around three code blocks
  • Corrected the displayed minified output by removing unnecessary parentheses that Prettier was adding
  • Ensures documentation accurately shows the exact minified code output

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@graphite-app graphite-app bot force-pushed the 01-06-docs_minifier_add_prettier-ignore_for_js-in-md_part branch from 3523599 to 120a27c Compare January 6, 2026 02:06
@graphite-app graphite-app bot merged commit 120a27c into main Jan 6, 2026
18 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jan 6, 2026
@graphite-app graphite-app bot deleted the 01-06-docs_minifier_add_prettier-ignore_for_js-in-md_part branch January 6, 2026 02:12
Dunqing pushed a commit that referenced this pull request Jan 12, 2026
### 🚀 Features

- 10426af codegen: Print soft space between inline block comments on the
same line (#17799) (camc314)
- 2261e6e semantic: Improve error message to add `#` for private
identifiers (#17779) (Dunqing)

### 🐛 Bug Fixes

- 7422b7e parser/trivia: Correctly mark whether a block comment is on a
newline (#17754) (camc314)
- c32e8d5 codegen: Wrap `TSAsExpression` in parens when used with
in/instanceof operators (#17752) (camc314)
- 5755b2d semantic: Report duplicate private identifier for static and
instance elements (#17591) (camc314)
- 0600df3 isolated_declarations: Only print jsdoc comments (#17748)
(camc314)
- ef7e014 parser: Preserve `@__NO_SIDE_EFFECTS__` annotation with
parenthesized expressions (#17711) (camc314)
- 59a6228 parser: Detect TS1363 error for type-only imports with mixed
default and named/namespace bindings (#17712) (Copilot)

### ⚡ Performance

- 864f1fa semantic: Mark duplicate class element error reporting as cold
(#17746) (camc314)
- 3a452b8 semantic: Use smallvec for storing reference IDs (#17731)
(camchenry)
- d5979dc minifier: Do not allocate when checking to convert `const` to
`let` (#17730) (camchenry)
- 3f4429c parser: Do not re-allocate TS interface heritage (#17692)
(camchenry)

### 📚 Documentation

- 120a27c minifier: Add prettier-ignore for js-in-md part (#17687)
(leaysgur)

Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-minifier Area - Minifier C-docs Category - Documentation. Related to user-facing or internal documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants