Skip to content

fix(isolated_declarations): only print jsdoc comments#17748

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/01-07-fix_isolated_declarations_only_print_jsdoc_comments
Jan 8, 2026
Merged

fix(isolated_declarations): only print jsdoc comments#17748
graphite-app[bot] merged 1 commit intomainfrom
c/01-07-fix_isolated_declarations_only_print_jsdoc_comments

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Jan 7, 2026

fixes #17666

Copy link
Contributor Author

camc314 commented Jan 7, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camc314 camc314 marked this pull request as ready for review January 7, 2026 11:39
@camc314 camc314 requested a review from Dunqing as a code owner January 7, 2026 11:39
@camc314 camc314 changed the base branch from c/01-07-perf_semantic_mark_duplicate_class_element_error_reporting_as_cold to graphite-base/17748 January 7, 2026 11:39
@camc314 camc314 force-pushed the c/01-07-fix_isolated_declarations_only_print_jsdoc_comments branch from 1684e4e to c779a52 Compare January 7, 2026 11:39
@camc314 camc314 force-pushed the graphite-base/17748 branch from e42d220 to f3ec67c Compare January 7, 2026 11:39
@camc314 camc314 changed the base branch from graphite-base/17748 to main January 7, 2026 11:40
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 7, 2026

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing c/01-07-fix_isolated_declarations_only_print_jsdoc_comments (c779a52) with main (efa1255)1

Summary

✅ 38 untouched benchmarks
⏩ 7 skipped benchmarks2

Footnotes

  1. No successful run was found on main (f3ec67c) during the generation of this report, so efa1255 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 7 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Copy link
Member

@Dunqing Dunqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

Goes a little bit faster

@Dunqing Dunqing added the 0-merge Merge with Graphite Merge Queue label Jan 8, 2026
Copy link
Member

Dunqing commented Jan 8, 2026

Merge activity

Copilot AI review requested due to automatic review settings January 8, 2026 02:56
@graphite-app graphite-app bot force-pushed the c/01-07-fix_isolated_declarations_only_print_jsdoc_comments branch from c779a52 to 0600df3 Compare January 8, 2026 02:56
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@graphite-app graphite-app bot merged commit 0600df3 into main Jan 8, 2026
20 checks passed
@graphite-app graphite-app bot deleted the c/01-07-fix_isolated_declarations_only_print_jsdoc_comments branch January 8, 2026 03:02
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jan 8, 2026
Dunqing pushed a commit that referenced this pull request Jan 12, 2026
### 🚀 Features

- 10426af codegen: Print soft space between inline block comments on the
same line (#17799) (camc314)
- 2261e6e semantic: Improve error message to add `#` for private
identifiers (#17779) (Dunqing)

### 🐛 Bug Fixes

- 7422b7e parser/trivia: Correctly mark whether a block comment is on a
newline (#17754) (camc314)
- c32e8d5 codegen: Wrap `TSAsExpression` in parens when used with
in/instanceof operators (#17752) (camc314)
- 5755b2d semantic: Report duplicate private identifier for static and
instance elements (#17591) (camc314)
- 0600df3 isolated_declarations: Only print jsdoc comments (#17748)
(camc314)
- ef7e014 parser: Preserve `@__NO_SIDE_EFFECTS__` annotation with
parenthesized expressions (#17711) (camc314)
- 59a6228 parser: Detect TS1363 error for type-only imports with mixed
default and named/namespace bindings (#17712) (Copilot)

### ⚡ Performance

- 864f1fa semantic: Mark duplicate class element error reporting as cold
(#17746) (camc314)
- 3a452b8 semantic: Use smallvec for storing reference IDs (#17731)
(camchenry)
- d5979dc minifier: Do not allocate when checking to convert `const` to
`let` (#17730) (camchenry)
- 3f4429c parser: Do not re-allocate TS interface heritage (#17692)
(camchenry)

### 📚 Documentation

- 120a27c minifier: Add prettier-ignore for js-in-md part (#17687)
(leaysgur)

Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-isolated-declarations Isolated Declarations C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ecosystem CI failure: Isolated declarations includes regular comments in .d.ts output

3 participants