Merged
Conversation
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
jzelinskie
approved these changes
Jan 12, 2024
Contributor
|
LGTM |
stevvooe
approved these changes
Jan 12, 2024
mikebrow
approved these changes
Jan 16, 2024
Member
mikebrow
left a comment
There was a problem hiding this comment.
LGTM with reservation, a final RC for 1.1 should resolve:
- subject descriptor in this distribution spec should be made consistent with the image spec restrictions see https://github.com/opencontainers/image-spec/blob/main/descriptor.md dag requirements e.g. validation
- a plan or fix is made for 1.1.0 or 1.1.x resolving the apparent breakage with 1.0 dag support #459
- define what must accept means (in clear terms) with respect to receiving push of artifacts referring to an image that does not exist.. e.g. garbage collection appears to be only allowed here by the client.. where in prior 1.0 registry image implementations repo content management included ability of the registry to remove (gc) content that was no longer in a dag.
dmcgowan
approved these changes
Jan 18, 2024
This was referenced Jan 25, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mailing list: https://groups.google.com/a/opencontainers.org/g/dev/c/aZqq6PjVGC4
tag
This would mean tagging d7bc0ef as v1.1.0-rc4
changes
diff
v1.1.0-rc3...jdolitsky:distribution-spec:d7bc0ef
votes