Rephrase the subject exclusion from validation#445
Merged
jdolitsky merged 1 commit intoopencontainers:mainfrom Jul 27, 2023
Merged
Rephrase the subject exclusion from validation#445jdolitsky merged 1 commit intoopencontainers:mainfrom
jdolitsky merged 1 commit intoopencontainers:mainfrom
Conversation
Signed-off-by: Brandon Mitchell <git@bmitch.net>
andaaron
approved these changes
Jul 8, 2023
jdolitsky
approved these changes
Jul 10, 2023
| A registry MAY reject a manifest of any type uploaded to the manifest endpoint if it references manifests or blobs that do not exist in the registry. | ||
| A registry MUST accept an otherwise valid manifest with a `subject` field that references a manifest that does not exist, allowing clients to push a manifest and referrers to that manifest in either order. | ||
| When a manifest is rejected for these reasons, it MUST result in one or more `MANIFEST_BLOB_UNKNOWN` errors <sup>[code-1](#error-codes)</sup>. | ||
| A registry MAY reject a manifest uploaded to the manifest endpoint with descriptors in other fields that reference a manifest or blob that does not exist in the registry. |
Contributor
There was a problem hiding this comment.
Swapping the order of these lines makes "otherwise valid manifest" a strange phrase.
Contributor
Author
There was a problem hiding this comment.
If we removed "otherwise valid", then couldn't someone upload an invalid manifest (missing fields, unknown media type, etc), but include a subject field and insist that the manifest must now be accepted?
dmcgowan
approved these changes
Jul 27, 2023
sudo-bmitch
added a commit
to sudo-bmitch/distribution-spec
that referenced
this pull request
Aug 18, 2023
Signed-off-by: Brandon Mitchell <git@bmitch.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #442.