Skip to content

conformance: OCI-Filters-Applied should return a literal#449

Merged
jdolitsky merged 1 commit intoopencontainers:mainfrom
rchincha:fix-ref
Jul 24, 2023
Merged

conformance: OCI-Filters-Applied should return a literal#449
jdolitsky merged 1 commit intoopencontainers:mainfrom
rchincha:fix-ref

Conversation

@rchincha
Copy link
Copy Markdown
Contributor

Per spec, the filter type (in this case "artifactType") should be returned instead of the actual filter values.

Fixes #448

jdolitsky
jdolitsky previously approved these changes Jul 21, 2023
@jdolitsky
Copy link
Copy Markdown
Contributor

in the same boat as #436 with CI failing - do we have a zot release/rc yet that will go green for these changes?

sudo-bmitch
sudo-bmitch previously approved these changes Jul 21, 2023
Copy link
Copy Markdown
Contributor

@sudo-bmitch sudo-bmitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Per spec, the filter type (in this case "artifactType") should be
returned instead of the actual filter values.

Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com>
@sudo-bmitch sudo-bmitch added this to the v1.1.0 milestone Jul 23, 2023
@jdolitsky jdolitsky merged commit 9b5b19b into opencontainers:main Jul 24, 2023
sudo-bmitch pushed a commit to sudo-bmitch/distribution-spec that referenced this pull request Aug 18, 2023
…ers#449)

Per spec, the filter type (in this case "artifactType") should be
returned instead of the actual filter values.

Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com>
@jdolitsky jdolitsky mentioned this pull request Jan 11, 2024
8 tasks
@sudo-bmitch sudo-bmitch mentioned this pull request Feb 1, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Question: What is the correct value for the "OCI-Filters-Applied" header?

3 participants