Merged
Conversation
Member
|
pls sign commits |
…list req Signed-off-by: wayne warren <wayne.warren.s@gmail.com>
…te blobs, disregard 404 responses Signed-off-by: wayne warren <wayne.warren.s@gmail.com>
e671dec to
5afc3ee
Compare
sudo-bmitch
requested changes
Oct 13, 2023
Contributor
sudo-bmitch
left a comment
There was a problem hiding this comment.
Couple minor changes to align all the manifests.
Contributor
|
@waynr do you have time to work on the changes requested? If not, I can take a stab at it. |
Co-authored-by: Brandon Mitchell <git@bmitch.net> Signed-off-by: wayne <wayne.warren.s@gmail.com>
Co-authored-by: Brandon Mitchell <git@bmitch.net> Signed-off-by: wayne <wayne.warren.s@gmail.com>
Co-authored-by: Brandon Mitchell <git@bmitch.net> Signed-off-by: wayne <wayne.warren.s@gmail.com>
Co-authored-by: Brandon Mitchell <git@bmitch.net> Signed-off-by: wayne <wayne.warren.s@gmail.com>
Contributor
Author
|
@sudo-bmitch I accepted your suggested changes, thanks for the reminder! |
sudo-bmitch
approved these changes
Nov 11, 2023
Contributor
sudo-bmitch
left a comment
There was a problem hiding this comment.
LGTM. Should be squashed but that can be done on the merge if it's easier.
jdolitsky
approved these changes
Nov 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discovery test teardown was broken prior to this because it would attempt to
delete a blob before deleting at least five manifests left over from the setup
that still reference it. Most registries probably don't care about deleting
content that's referenced by other content, which is probably why this works
for others.
Also, I was seeing
GET /v2/<name>/tags/list?n=0requests and then out ofbounds indexing into the resulting slice because of the weird logic used to
calculate what the
nparameter should be in the tag listing endpoint tests.Fixes #457.