Skip to content

Do not panic conformance when last request fails#450

Merged
jdolitsky merged 1 commit intoopencontainers:mainfrom
sudo-bmitch:pr-conformance-panic
Jul 22, 2023
Merged

Do not panic conformance when last request fails#450
jdolitsky merged 1 commit intoopencontainers:mainfrom
sudo-bmitch:pr-conformance-panic

Conversation

@sudo-bmitch
Copy link
Copy Markdown
Contributor

There are a couple of panics in the conformance test if the registry does not pass the previous test and set lastResponse.

Signed-off-by: Brandon Mitchell <git@bmitch.net>
Copy link
Copy Markdown
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdolitsky jdolitsky merged commit 212108f into opencontainers:main Jul 22, 2023
@sudo-bmitch sudo-bmitch deleted the pr-conformance-panic branch July 22, 2023 22:15
sudo-bmitch added a commit to sudo-bmitch/distribution-spec that referenced this pull request Aug 18, 2023
Signed-off-by: Brandon Mitchell <git@bmitch.net>
@jdolitsky jdolitsky mentioned this pull request Jan 11, 2024
8 tasks
@sudo-bmitch sudo-bmitch mentioned this pull request Feb 1, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants