Support referrers to a missing manifest#491
Merged
sudo-bmitch merged 1 commit intoopencontainers:mainfrom Jan 11, 2024
Merged
Conversation
Contributor
Author
|
cc @jonjohnsonjr and @sajayantony |
mikebrow
requested changes
Nov 14, 2023
Member
mikebrow
left a comment
There was a problem hiding this comment.
see comment on additional phrase... that would need to be removed..
and the question regarding contentDiscovery with/without 1.0 type validations..
Signed-off-by: Brandon Mitchell <git@bmitch.net>
f695222 to
0a867d6
Compare
jdolitsky
approved these changes
Dec 14, 2023
Contributor
jdolitsky
left a comment
There was a problem hiding this comment.
as a card-carrying mike brown, i approve
jonjohnsonjr
approved these changes
Jan 4, 2024
Contributor
Author
|
@mikebrow was your feedback addressed, or is there anything else I'm missing? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the discussions of whether to require registries to accept a manifest with a subject pointing to missing digest, there was a use case mentioned of pushing metadata to a separate repo from the images. In cases where the registry does support pushing these manifests, the empty response to the referrers API breaks that use case. It also doesn't provide any value for those that want to validate the subject descriptor. So I propose removing that exception from the spec.
The changes to the conformance tests can be gated behind configuration variables if registries have the option to validate the subject field in a future version of the spec.