conformance: support OCI_REPORT_DIR#473
Merged
jdolitsky merged 1 commit intoopencontainers:mainfrom Oct 16, 2023
Merged
Conversation
sudo-bmitch
reviewed
Sep 30, 2023
sudo-bmitch
reviewed
Oct 8, 2023
7da3a67 to
8e2f23f
Compare
sudo-bmitch
requested changes
Oct 15, 2023
This makes it possible to run the conformance tests in a read-only directory without failing by specifying an output directory for the report files instead of hard-coding it to the current directory (which may not be writable, and _won't_ be writable if the tests are being run with `go test github.com/opencontainers/distribution-spec/conformance` rather than in a git checkout of the conformance module. We recognize the value `none` for disabling report generation entirely. Signed-off-by: Roger Peppe <rogpeppe@gmail.com>
8e2f23f to
219abb3
Compare
sudo-bmitch
approved these changes
Oct 15, 2023
Contributor
sudo-bmitch
left a comment
There was a problem hiding this comment.
Thanks for going through all the updates. LGTM!
jdolitsky
approved these changes
Oct 16, 2023
porcuepine
pushed a commit
to cue-labs/oci-trybot
that referenced
this pull request
Nov 3, 2023
This means that adding the golang.org/x/exp dependency in a later commit won't do this at the same time. We can also remove the replace statement in the conformance tests since [PR 473](opencontainers/distribution-spec#473) has landed. Signed-off-by: Roger Peppe <rogpeppe@gmail.com> Change-Id: I9ec1333d897e5d1af3a8511b5baead5c986fd295
porcuepine
pushed a commit
to cue-labs/oci-trybot
that referenced
this pull request
Nov 3, 2023
This means that adding the golang.org/x/exp dependency in a later commit won't do this at the same time. We can also remove the replace statement in the conformance tests since [PR 473](opencontainers/distribution-spec#473) has landed. Signed-off-by: Roger Peppe <rogpeppe@gmail.com> Change-Id: I9ec1333d897e5d1af3a8511b5baead5c986fd295 Dispatch-Trailer: {"type":"trybot","CL":1171068,"patchset":4,"ref":"refs/changes/68/1171068/4","targetBranch":"main"}
porcuepine
pushed a commit
to cue-labs/oci
that referenced
this pull request
Nov 3, 2023
This means that adding the golang.org/x/exp dependency in a later commit won't do this at the same time. We can also remove the replace statement in the conformance tests since [PR 473](opencontainers/distribution-spec#473) has landed. Signed-off-by: Roger Peppe <rogpeppe@gmail.com> Change-Id: I9ec1333d897e5d1af3a8511b5baead5c986fd295 Reviewed-on: https://review-eu.gerrithub.io/c/cue-labs/oci/+/1171068 TryBot-Result: CUE porcuepine <cue.porcuepine@gmail.com> Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it possible to run the conformance tests in a read-only directory without failing by specifying an output directory for the report files instead of hard-coding it to the current directory (which may not be writable, and won't be writable if the tests are being run with
go test github.com/opencontainers/distribution-spec/conformancerather than in a git checkout of the conformance module.We recognize the value
nonefor disabling report generation entirely.