Skip to content

cmake config update#2477

Closed
chcg wants to merge 1 commit intonotepad-plus-plus:masterfrom
chcg:cmake_usable
Closed

cmake config update#2477
chcg wants to merge 1 commit intonotepad-plus-plus:masterfrom
chcg:cmake_usable

Conversation

@chcg
Copy link
Copy Markdown
Contributor

@chcg chcg commented Oct 24, 2016

  • added usable cmake config file by transferring files structure from visual studio project file
  • contains also basic support for mingw make file creation, this needs cmake 3.4 to build rc files out-of-the-box
  • see https://ci.appveyor.com/project/chcg/notepad-plus-plus/build/1.0.38 for successful build with adapted appveyor config for the visual studio builds

@chcg
- added usable cmake config file by transferring files structure from…
5a7bbdb 
… visual studio project file

- contains also basic support for mingw make file creation
- see https://ci.appveyor.com/project/chcg/notepad-plus-plus/build/1.0.38 for successful with own appveyor config
@evpobr
Copy link
Copy Markdown
Contributor

evpobr commented Oct 25, 2016

@chcg

For CMake > 3.0 it's prefered to use target_compile_definitions instead of add_definitons and target_include_directories instead of include_directories.

You can take a look at my CMake cmake-notepad++ branch. There is almost complete Notepad++ build system in three files:

CMakeLists.txt in root scintilla/ folder is for SciLexer library, it is almost complete.

CMakeLists.txt in PowerEditor/ folder is for notepad++. It doesn't work with MinGW. MinGW support is tricky. As i remeber the last problem was about missing __inout_opt definition.

CMakeLists.txt in root folder is to join projects together.

I'm trying to implement VS2015 solution now, and my CMake work is stopped. You can use it if you wish.

@donho donho added the accepted label Oct 28, 2016
@donho donho added this to the 7.x (master) milestone Oct 28, 2016
@donho donho self-assigned this Oct 28, 2016
@donho donho closed this in b39c9a1 Oct 31, 2016
SinghRajenM added a commit to SinghRajenM/notepad-plus-plus that referenced this pull request Nov 11, 2016
@SinghRajenM
Java script readability (#11)
2d4079b 
* Update german.xml to version 7.0 - 14.10.16

including last updates following english.xml from 14.10.2016

Closes notepad-plus-plus#2423

* Update translations

* Update farsi.xml to 7.1

* Update slovenian.xml to v7.1

* Notepad++ 7.1 release

* Updated hindi.xml

Closes notepad-plus-plus#2375

* Update config.model.xml

* config.xml is generated by notepad++

No more config.model.xml. config.xml is generated by notepad++ directly.

* Add SmartHighLight node for config.xml generation

* Fixed disable smart highlihgt inconsistent behaviour

This bug can be reproduce by turning off smart highlight then restart
Notepad++ : some smart highlight options are still enabled.

Fixes notepad-plus-plus#2442, closes notepad-plus-plus#2465

* Add .profile, .bash_profile, and .bashrc extensions.

* Ensure backup directory exists

Failed backups result in a user error message and asks to save the file anyways. Closes notepad-plus-plus#2346, Closes notepad-plus-plus#2441

* Add smart highlighting extension to anothe view option

Add new option to enable smat highlighting extension to anothe view,
while both views are visible side by side.

* Fix a regression of double click on several zones of status bar.

* Fix a tab settings regression

Tab settings per language broken due to the entries are doubled by error
during the preferences dialog reorganization.

* Fix uninstaller silent mode issue

Remove also unecessary files

* Fix Installer for 64-bit fails with argument "/D"

* Change styler to make makefile more readable

Closes notepad-plus-plus#2482

* MinGW GCC update

- changes necessary to get back a buildable version with mingw, last adapted with notepad-plus-plus#1229
- fixed some gcc compiler errors and warnings, see https://ci.appveyor.com/project/chcg/notepad-plus-plus/build/1.0.3 to https://ci.appveyor.com/project/chcg/notepad-plus-plus/build/1.0.13
- remaining task is the wincontrol "ReadDirectoryChanges", which uses ATL, propably not available with mingw
Closes notepad-plus-plus#2478

* Japanese translation update

* update translations to v7.1
* correct indent
Closes notepad-plus-plus#2436

* Update Ukrainian translation

Closes notepad-plus-plus#2414

* Update catalan.xml

Update to v7.0

Closes notepad-plus-plus#2412

* Fix Encoding radio button issue in New Document

Sync UTF-8 checkbox with UTF-8 radio button

Closes notepad-plus-plus#2377

* cmake config update

- added usable cmake config file by transferring files structure from visual studio project file
- contains also basic support for mingw make file creation
- see https://ci.appveyor.com/project/chcg/notepad-plus-plus/build/1.0.38 for successful with own appveyor config

Closes notepad-plus-plus#2477

* Update translations

* Notepad++ release 7.2

* Expand environment variables in backup path

Fixes notepad-plus-plus#2520, Fixes notepad-plus-plus#2525

* Improve Javascript readability
SinghRajenM added a commit to SinghRajenM/notepad-plus-plus that referenced this pull request Nov 11, 2016
@SinghRajenM
Run marco ui fix (#12)
1cd84d0 
* Update german.xml to version 7.0 - 14.10.16

including last updates following english.xml from 14.10.2016

Closes notepad-plus-plus#2423

* Update translations

* Update farsi.xml to 7.1

* Update slovenian.xml to v7.1

* Notepad++ 7.1 release

* Updated hindi.xml

Closes notepad-plus-plus#2375

* Update config.model.xml

* config.xml is generated by notepad++

No more config.model.xml. config.xml is generated by notepad++ directly.

* Add SmartHighLight node for config.xml generation

* Fixed disable smart highlihgt inconsistent behaviour

This bug can be reproduce by turning off smart highlight then restart
Notepad++ : some smart highlight options are still enabled.

Fixes notepad-plus-plus#2442, closes notepad-plus-plus#2465

* Add .profile, .bash_profile, and .bashrc extensions.

* Ensure backup directory exists

Failed backups result in a user error message and asks to save the file anyways. Closes notepad-plus-plus#2346, Closes notepad-plus-plus#2441

* Add smart highlighting extension to anothe view option

Add new option to enable smat highlighting extension to anothe view,
while both views are visible side by side.

* Fix a regression of double click on several zones of status bar.

* Fix a tab settings regression

Tab settings per language broken due to the entries are doubled by error
during the preferences dialog reorganization.

* Fix uninstaller silent mode issue

Remove also unecessary files

* Fix Installer for 64-bit fails with argument "/D"

* Change styler to make makefile more readable

Closes notepad-plus-plus#2482

* MinGW GCC update

- changes necessary to get back a buildable version with mingw, last adapted with notepad-plus-plus#1229
- fixed some gcc compiler errors and warnings, see https://ci.appveyor.com/project/chcg/notepad-plus-plus/build/1.0.3 to https://ci.appveyor.com/project/chcg/notepad-plus-plus/build/1.0.13
- remaining task is the wincontrol "ReadDirectoryChanges", which uses ATL, propably not available with mingw
Closes notepad-plus-plus#2478

* Japanese translation update

* update translations to v7.1
* correct indent
Closes notepad-plus-plus#2436

* Update Ukrainian translation

Closes notepad-plus-plus#2414

* Update catalan.xml

Update to v7.0

Closes notepad-plus-plus#2412

* Fix Encoding radio button issue in New Document

Sync UTF-8 checkbox with UTF-8 radio button

Closes notepad-plus-plus#2377

* cmake config update

- added usable cmake config file by transferring files structure from visual studio project file
- contains also basic support for mingw make file creation
- see https://ci.appveyor.com/project/chcg/notepad-plus-plus/build/1.0.38 for successful with own appveyor config

Closes notepad-plus-plus#2477

* Update translations

* Notepad++ release 7.2

* Expand environment variables in backup path

Fixes notepad-plus-plus#2520, Fixes notepad-plus-plus#2525

* Improved Run Macro dialog UI.
1. Radio button and edit box were overlapped
2. Edit box and comboxed were not vertically aligned.
SinghRajenM added a commit to SinghRajenM/notepad-plus-plus that referenced this pull request Nov 11, 2016
@SinghRajenM
Sync with Npp master (#13)
3b0e34f 
* Update german.xml to version 7.0 - 14.10.16

including last updates following english.xml from 14.10.2016

Closes notepad-plus-plus#2423

* Update translations

* Update farsi.xml to 7.1

* Update slovenian.xml to v7.1

* Notepad++ 7.1 release

* Updated hindi.xml

Closes notepad-plus-plus#2375

* Update config.model.xml

* config.xml is generated by notepad++

No more config.model.xml. config.xml is generated by notepad++ directly.

* Add SmartHighLight node for config.xml generation

* Fixed disable smart highlihgt inconsistent behaviour

This bug can be reproduce by turning off smart highlight then restart
Notepad++ : some smart highlight options are still enabled.

Fixes notepad-plus-plus#2442, closes notepad-plus-plus#2465

* Add .profile, .bash_profile, and .bashrc extensions.

* Ensure backup directory exists

Failed backups result in a user error message and asks to save the file anyways. Closes notepad-plus-plus#2346, Closes notepad-plus-plus#2441

* Add smart highlighting extension to anothe view option

Add new option to enable smat highlighting extension to anothe view,
while both views are visible side by side.

* Fix a regression of double click on several zones of status bar.

* Fix a tab settings regression

Tab settings per language broken due to the entries are doubled by error
during the preferences dialog reorganization.

* Fix uninstaller silent mode issue

Remove also unecessary files

* Fix Installer for 64-bit fails with argument "/D"

* Change styler to make makefile more readable

Closes notepad-plus-plus#2482

* MinGW GCC update

- changes necessary to get back a buildable version with mingw, last adapted with notepad-plus-plus#1229
- fixed some gcc compiler errors and warnings, see https://ci.appveyor.com/project/chcg/notepad-plus-plus/build/1.0.3 to https://ci.appveyor.com/project/chcg/notepad-plus-plus/build/1.0.13
- remaining task is the wincontrol "ReadDirectoryChanges", which uses ATL, propably not available with mingw
Closes notepad-plus-plus#2478

* Japanese translation update

* update translations to v7.1
* correct indent
Closes notepad-plus-plus#2436

* Update Ukrainian translation

Closes notepad-plus-plus#2414

* Update catalan.xml

Update to v7.0

Closes notepad-plus-plus#2412

* Fix Encoding radio button issue in New Document

Sync UTF-8 checkbox with UTF-8 radio button

Closes notepad-plus-plus#2377

* cmake config update

- added usable cmake config file by transferring files structure from visual studio project file
- contains also basic support for mingw make file creation
- see https://ci.appveyor.com/project/chcg/notepad-plus-plus/build/1.0.38 for successful with own appveyor config

Closes notepad-plus-plus#2477

* Update translations

* Notepad++ release 7.2

* Expand environment variables in backup path

Fixes notepad-plus-plus#2520, Fixes notepad-plus-plus#2525

* Update readme.txt

* Improve Javascript string readability

Fixes notepad-plus-plus#1543, closes notepad-plus-plus#2550

* Small tune on Run Macro dialog UI.

1. Radio button and edit box were overlapped
2. Edit box and comboxed were not vertically aligned.

Closes notepad-plus-plus#2549

* Remove 32bit shell dll from 64bit installer

Closes notepad-plus-plus#2408
@chcg
Copy link
Copy Markdown
Contributor Author

chcg commented Nov 16, 2016

See also #361.
But there seems to be no further action on this topic.
@milipili Is a complete n++ cmake build still a target for the project?

@chcg
Copy link
Copy Markdown
Contributor Author

chcg commented Nov 16, 2016

@evpobr
See #2478 and #1663 for n++ mingw builds. There is still some part missing regarding the FileBrowser support

@milipili
Copy link
Copy Markdown
Contributor

milipili commented Nov 17, 2016 •
edited
Loading

yes it is, sorry. just currently focused on something else.

PalashBansal pushed a commit to PalashBansal/notepad-plus-plus that referenced this pull request Dec 3, 2016
@chcg @PalashBansal
cmake config update
cfe1b84 
- added usable cmake config file by transferring files structure from visual studio project file
- contains also basic support for mingw make file creation
- see https://ci.appveyor.com/project/chcg/notepad-plus-plus/build/1.0.38 for successful with own appveyor config

Closes notepad-plus-plus#2477
anil-shrestha pushed a commit to anil-shrestha/notepad-plus-plus that referenced this pull request Dec 7, 2016
@chcg @anil-shrestha
cmake config update
61c3528 
- added usable cmake config file by transferring files structure from visual studio project file
- contains also basic support for mingw make file creation
- see https://ci.appveyor.com/project/chcg/notepad-plus-plus/build/1.0.38 for successful with own appveyor config

Closes notepad-plus-plus#2477
@MetaChuh MetaChuh mentioned this pull request Apr 8, 2019
Closed
@chcg chcg deleted the cmake_usable branch January 2, 2021 09:34
iczelia pushed a commit to iczelia/notepad-plus-plus that referenced this pull request Jan 17, 2021
@chcg @donho
cmake config update
a8383af 
- added usable cmake config file by transferring files structure from visual studio project file
- contains also basic support for mingw make file creation
- see https://ci.appveyor.com/project/chcg/notepad-plus-plus/build/1.0.38 for successful with own appveyor config

Closes notepad-plus-plus#2477
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@donho donho

Labels

accepted

Projects

None yet

Milestone

7.x (master)

Development

Successfully merging this pull request may close these issues.

4 participants

@chcg @evpobr @milipili @donho