Mingw GCC update by chcg · Pull Request #2478 · notepad-plus-plus/notepad-plus-plus

chcg · 2016-10-24T21:20:19Z

changes necessary to get back to a buildable version with mingw, after last adaptation with Make GCC/MinGW build work again and support cross-building under Linux #1229
fixed some gcc compiler errors and warnings, see https://ci.appveyor.com/project/chcg/notepad-plus-plus/build/1.0.3 to https://ci.appveyor.com/project/chcg/notepad-plus-plus/build/1.0.13
remaining task is the wincontrol "ReadDirectoryChanges", which uses ATL, propably not available with mingw
@donho
what is your preference here, maybe it is easier to switch off this feature by ifdef mingw, than to adapt the control. I created a buildable version, which remove the dependency to ATL and replaced most parts by c++11 equivalents, but that is quite intrusive, see https://github.com/chcg/notepad-plus-plus/commits/mingw_gcc/PowerEditor/src/WinControls/ReadDirectoryChanges and not really tested for maybe newly introduced issues
should a build target for mingw(, see https://www.appveyor.com/docs/installed-software/#mingw-msys-cygwin) be added to appveyor?

…adapted with notepad-plus-plus#1229 - fixed some gcc compiler errors and warnings, see https://ci.appveyor.com/project/chcg/notepad-plus-plus/build/1.0.3 to https://ci.appveyor.com/project/chcg/notepad-plus-plus/build/1.0.13 - remaining task is the wincontrol "ReadDirectoryChanges", which uses ATL, propably not available with mingw

evpobr · 2016-10-25T11:07:32Z

remaining task is the wincontrol "ReadDirectoryChanges", which uses ATL, propably not available with mingw

Yes, MinGW doesn't have ATL.

donho · 2016-10-28T11:29:00Z

@chcg

remaining task is the wincontrol "ReadDirectoryChanges", which uses ATL, propably not available with mingw

So the makefile doesn't compile at all, does it?

chcg · 2016-10-28T16:15:23Z

@donho
With just this PR build fails with:

In file included from ../src/NppIO.cpp:36:0:
../src/WinControls/ReadDirectoryChanges/ReadDirectoryChanges.h:46:21: fatal error: atlbase.h: No such file or directory
compilation terminated.
makefile:260: recipe for target '../src/NppIO.o' failed
mingw32-make: *** [../src/NppIO.o] Error 1
Command exited with code 2

After:

replacement of ATL CStringW by generic_string
replacement of CComCritSecLock by std::unique_lockstd::mutex
replacement of microsoft compiler specific __super by typedef
replacement of _ASSERTE by assert
removal of SAL annotation __in in two method definition, which can't be easily avoided by empty define in various.h

this config also compiles. Also still multiple warnings occur and I havn't tested the mingw output, just slightly the one from VS compiler with this changes, which seems to be still usable.

* Update german.xml to version 7.0 - 14.10.16 including last updates following english.xml from 14.10.2016 Closes notepad-plus-plus#2423 * Update translations * Update farsi.xml to 7.1 * Update slovenian.xml to v7.1 * Notepad++ 7.1 release * Updated hindi.xml Closes notepad-plus-plus#2375 * Update config.model.xml * config.xml is generated by notepad++ No more config.model.xml. config.xml is generated by notepad++ directly. * Add SmartHighLight node for config.xml generation * Fixed disable smart highlihgt inconsistent behaviour This bug can be reproduce by turning off smart highlight then restart Notepad++ : some smart highlight options are still enabled. Fixes notepad-plus-plus#2442, closes notepad-plus-plus#2465 * Add .profile, .bash_profile, and .bashrc extensions. * Ensure backup directory exists Failed backups result in a user error message and asks to save the file anyways. Closes notepad-plus-plus#2346, Closes notepad-plus-plus#2441 * Add smart highlighting extension to anothe view option Add new option to enable smat highlighting extension to anothe view, while both views are visible side by side. * Fix a regression of double click on several zones of status bar. * Fix a tab settings regression Tab settings per language broken due to the entries are doubled by error during the preferences dialog reorganization. * Fix uninstaller silent mode issue Remove also unecessary files * Fix Installer for 64-bit fails with argument "/D" * Change styler to make makefile more readable Closes notepad-plus-plus#2482 * MinGW GCC update - changes necessary to get back a buildable version with mingw, last adapted with notepad-plus-plus#1229 - fixed some gcc compiler errors and warnings, see https://ci.appveyor.com/project/chcg/notepad-plus-plus/build/1.0.3 to https://ci.appveyor.com/project/chcg/notepad-plus-plus/build/1.0.13 - remaining task is the wincontrol "ReadDirectoryChanges", which uses ATL, propably not available with mingw Closes notepad-plus-plus#2478 * Japanese translation update * update translations to v7.1 * correct indent Closes notepad-plus-plus#2436 * Update Ukrainian translation Closes notepad-plus-plus#2414 * Update catalan.xml Update to v7.0 Closes notepad-plus-plus#2412 * Fix Encoding radio button issue in New Document Sync UTF-8 checkbox with UTF-8 radio button Closes notepad-plus-plus#2377 * cmake config update - added usable cmake config file by transferring files structure from visual studio project file - contains also basic support for mingw make file creation - see https://ci.appveyor.com/project/chcg/notepad-plus-plus/build/1.0.38 for successful with own appveyor config Closes notepad-plus-plus#2477 * Update translations * Notepad++ release 7.2 * Expand environment variables in backup path Fixes notepad-plus-plus#2520, Fixes notepad-plus-plus#2525 * Improve Javascript readability

* Update german.xml to version 7.0 - 14.10.16 including last updates following english.xml from 14.10.2016 Closes notepad-plus-plus#2423 * Update translations * Update farsi.xml to 7.1 * Update slovenian.xml to v7.1 * Notepad++ 7.1 release * Updated hindi.xml Closes notepad-plus-plus#2375 * Update config.model.xml * config.xml is generated by notepad++ No more config.model.xml. config.xml is generated by notepad++ directly. * Add SmartHighLight node for config.xml generation * Fixed disable smart highlihgt inconsistent behaviour This bug can be reproduce by turning off smart highlight then restart Notepad++ : some smart highlight options are still enabled. Fixes notepad-plus-plus#2442, closes notepad-plus-plus#2465 * Add .profile, .bash_profile, and .bashrc extensions. * Ensure backup directory exists Failed backups result in a user error message and asks to save the file anyways. Closes notepad-plus-plus#2346, Closes notepad-plus-plus#2441 * Add smart highlighting extension to anothe view option Add new option to enable smat highlighting extension to anothe view, while both views are visible side by side. * Fix a regression of double click on several zones of status bar. * Fix a tab settings regression Tab settings per language broken due to the entries are doubled by error during the preferences dialog reorganization. * Fix uninstaller silent mode issue Remove also unecessary files * Fix Installer for 64-bit fails with argument "/D" * Change styler to make makefile more readable Closes notepad-plus-plus#2482 * MinGW GCC update - changes necessary to get back a buildable version with mingw, last adapted with notepad-plus-plus#1229 - fixed some gcc compiler errors and warnings, see https://ci.appveyor.com/project/chcg/notepad-plus-plus/build/1.0.3 to https://ci.appveyor.com/project/chcg/notepad-plus-plus/build/1.0.13 - remaining task is the wincontrol "ReadDirectoryChanges", which uses ATL, propably not available with mingw Closes notepad-plus-plus#2478 * Japanese translation update * update translations to v7.1 * correct indent Closes notepad-plus-plus#2436 * Update Ukrainian translation Closes notepad-plus-plus#2414 * Update catalan.xml Update to v7.0 Closes notepad-plus-plus#2412 * Fix Encoding radio button issue in New Document Sync UTF-8 checkbox with UTF-8 radio button Closes notepad-plus-plus#2377 * cmake config update - added usable cmake config file by transferring files structure from visual studio project file - contains also basic support for mingw make file creation - see https://ci.appveyor.com/project/chcg/notepad-plus-plus/build/1.0.38 for successful with own appveyor config Closes notepad-plus-plus#2477 * Update translations * Notepad++ release 7.2 * Expand environment variables in backup path Fixes notepad-plus-plus#2520, Fixes notepad-plus-plus#2525 * Improved Run Macro dialog UI. 1. Radio button and edit box were overlapped 2. Edit box and comboxed were not vertically aligned.

* Update german.xml to version 7.0 - 14.10.16 including last updates following english.xml from 14.10.2016 Closes notepad-plus-plus#2423 * Update translations * Update farsi.xml to 7.1 * Update slovenian.xml to v7.1 * Notepad++ 7.1 release * Updated hindi.xml Closes notepad-plus-plus#2375 * Update config.model.xml * config.xml is generated by notepad++ No more config.model.xml. config.xml is generated by notepad++ directly. * Add SmartHighLight node for config.xml generation * Fixed disable smart highlihgt inconsistent behaviour This bug can be reproduce by turning off smart highlight then restart Notepad++ : some smart highlight options are still enabled. Fixes notepad-plus-plus#2442, closes notepad-plus-plus#2465 * Add .profile, .bash_profile, and .bashrc extensions. * Ensure backup directory exists Failed backups result in a user error message and asks to save the file anyways. Closes notepad-plus-plus#2346, Closes notepad-plus-plus#2441 * Add smart highlighting extension to anothe view option Add new option to enable smat highlighting extension to anothe view, while both views are visible side by side. * Fix a regression of double click on several zones of status bar. * Fix a tab settings regression Tab settings per language broken due to the entries are doubled by error during the preferences dialog reorganization. * Fix uninstaller silent mode issue Remove also unecessary files * Fix Installer for 64-bit fails with argument "/D" * Change styler to make makefile more readable Closes notepad-plus-plus#2482 * MinGW GCC update - changes necessary to get back a buildable version with mingw, last adapted with notepad-plus-plus#1229 - fixed some gcc compiler errors and warnings, see https://ci.appveyor.com/project/chcg/notepad-plus-plus/build/1.0.3 to https://ci.appveyor.com/project/chcg/notepad-plus-plus/build/1.0.13 - remaining task is the wincontrol "ReadDirectoryChanges", which uses ATL, propably not available with mingw Closes notepad-plus-plus#2478 * Japanese translation update * update translations to v7.1 * correct indent Closes notepad-plus-plus#2436 * Update Ukrainian translation Closes notepad-plus-plus#2414 * Update catalan.xml Update to v7.0 Closes notepad-plus-plus#2412 * Fix Encoding radio button issue in New Document Sync UTF-8 checkbox with UTF-8 radio button Closes notepad-plus-plus#2377 * cmake config update - added usable cmake config file by transferring files structure from visual studio project file - contains also basic support for mingw make file creation - see https://ci.appveyor.com/project/chcg/notepad-plus-plus/build/1.0.38 for successful with own appveyor config Closes notepad-plus-plus#2477 * Update translations * Notepad++ release 7.2 * Expand environment variables in backup path Fixes notepad-plus-plus#2520, Fixes notepad-plus-plus#2525 * Update readme.txt * Improve Javascript string readability Fixes notepad-plus-plus#1543, closes notepad-plus-plus#2550 * Small tune on Run Macro dialog UI. 1. Radio button and edit box were overlapped 2. Edit box and comboxed were not vertically aligned. Closes notepad-plus-plus#2549 * Remove 32bit shell dll from 64bit installer Closes notepad-plus-plus#2408

marcows · 2016-11-16T09:25:06Z

Why is this PR applied after a few days while mine #1663, which included all of these changes and more, is dangling for months?
There is not even an associated issue, which is mandatory according to the contribution guide.
This is duplicated effort, these fixes have been implemented since a long time.

chcg · 2016-11-16T16:25:56Z

@marcows
Unfortunately didn't see your closed PR. Thanks for the hint.
Would be nice to team up and fix the remaining issues. I will have a look at your changes.
Maybe just luck or that this PR was a little bit smaller.

Maybe one reason for donho was that milipili wanna take care, but I didn't see any action from him the last few month. But in the end just donho knows.

- changes necessary to get back a buildable version with mingw, last adapted with notepad-plus-plus#1229 - fixed some gcc compiler errors and warnings, see https://ci.appveyor.com/project/chcg/notepad-plus-plus/build/1.0.3 to https://ci.appveyor.com/project/chcg/notepad-plus-plus/build/1.0.13 - remaining task is the wincontrol "ReadDirectoryChanges", which uses ATL, propably not available with mingw Closes notepad-plus-plus#2478

ganego · 2017-01-01T02:36:23Z

So I just tried to compile it with mingw. I applied all your patches from HERE to the master source.

Now I get this error: On Pastebin to have better line breaks

- changes necessary to get back a buildable version with mingw, last adapted with notepad-plus-plus#1229 - fixed some gcc compiler errors and warnings, see https://ci.appveyor.com/project/chcg/notepad-plus-plus/build/1.0.3 to https://ci.appveyor.com/project/chcg/notepad-plus-plus/build/1.0.13 - remaining task is the wincontrol "ReadDirectoryChanges", which uses ATL, propably not available with mingw Closes notepad-plus-plus#2478

donho added the accepted label Oct 28, 2016

donho added this to the 7.x (master) milestone Oct 28, 2016

donho self-assigned this Oct 28, 2016

donho closed this in 5a96eb6 Oct 31, 2016

chcg mentioned this pull request Nov 16, 2016

cmake config update #2477

Closed

This was referenced Feb 4, 2018

Codebase incompatible with /Zc:strictStrings #4146

Closed

update makefile for mingw gcc builds #4145

Closed

chcg mentioned this pull request Mar 29, 2018

Get rid of ATL dependency #4320

Closed

chcg deleted the gcc_basic_fixes branch January 2, 2021 09:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mingw GCC update#2478

Mingw GCC update#2478
chcg wants to merge 1 commit intonotepad-plus-plus:masterfrom
chcg:gcc_basic_fixes

chcg commented Oct 24, 2016 •

edited

Loading

Uh oh!

evpobr commented Oct 25, 2016

Uh oh!

donho commented Oct 28, 2016

Uh oh!

chcg commented Oct 28, 2016

Uh oh!

marcows commented Nov 16, 2016

Uh oh!

chcg commented Nov 16, 2016

Uh oh!

ganego commented Jan 1, 2017 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

chcg commented Oct 24, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

evpobr commented Oct 25, 2016

Uh oh!

donho commented Oct 28, 2016

Uh oh!

chcg commented Oct 28, 2016

this config also compiles. Also still multiple warnings occur and I havn't tested the mingw output, just slightly the one from VS compiler with this changes, which seems to be still usable.

Uh oh!

marcows commented Nov 16, 2016

Uh oh!

chcg commented Nov 16, 2016

Uh oh!

ganego commented Jan 1, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

chcg commented Oct 24, 2016 •

edited

Loading

ganego commented Jan 1, 2017 •

edited

Loading