Expand environment variables in backup path#2525
Closed
dail8859 wants to merge 1 commit intonotepad-plus-plus:masterfrom
Closed
Expand environment variables in backup path#2525dail8859 wants to merge 1 commit intonotepad-plus-plus:masterfrom
dail8859 wants to merge 1 commit intonotepad-plus-plus:masterfrom
Conversation
MAPJe71
reviewed
Nov 3, 2016
|
|
||
| // Expand any environment variables | ||
| TCHAR fn_bak_expanded[MAX_PATH] = { '\0' }; | ||
| ::ExpandEnvironmentStrings(fn_bak.c_str(), fn_bak_expanded, MAX_PATH); |
Contributor
There was a problem hiding this comment.
Might be wise to check the return value, see ExpandEnvironmentStrings help and it's example.
Contributor
Author
There was a problem hiding this comment.
I wasn't too worried about checking the return value since most other places in the code tend to ignore it as well. Plus if something does fail it most likely will cause CopyFile() to fail.
SinghRajenM
added a commit
to SinghRajenM/notepad-plus-plus
that referenced
this pull request
Nov 11, 2016
* Update german.xml to version 7.0 - 14.10.16 including last updates following english.xml from 14.10.2016 Closes notepad-plus-plus#2423 * Update translations * Update farsi.xml to 7.1 * Update slovenian.xml to v7.1 * Notepad++ 7.1 release * Updated hindi.xml Closes notepad-plus-plus#2375 * Update config.model.xml * config.xml is generated by notepad++ No more config.model.xml. config.xml is generated by notepad++ directly. * Add SmartHighLight node for config.xml generation * Fixed disable smart highlihgt inconsistent behaviour This bug can be reproduce by turning off smart highlight then restart Notepad++ : some smart highlight options are still enabled. Fixes notepad-plus-plus#2442, closes notepad-plus-plus#2465 * Add .profile, .bash_profile, and .bashrc extensions. * Ensure backup directory exists Failed backups result in a user error message and asks to save the file anyways. Closes notepad-plus-plus#2346, Closes notepad-plus-plus#2441 * Add smart highlighting extension to anothe view option Add new option to enable smat highlighting extension to anothe view, while both views are visible side by side. * Fix a regression of double click on several zones of status bar. * Fix a tab settings regression Tab settings per language broken due to the entries are doubled by error during the preferences dialog reorganization. * Fix uninstaller silent mode issue Remove also unecessary files * Fix Installer for 64-bit fails with argument "/D" * Change styler to make makefile more readable Closes notepad-plus-plus#2482 * MinGW GCC update - changes necessary to get back a buildable version with mingw, last adapted with notepad-plus-plus#1229 - fixed some gcc compiler errors and warnings, see https://ci.appveyor.com/project/chcg/notepad-plus-plus/build/1.0.3 to https://ci.appveyor.com/project/chcg/notepad-plus-plus/build/1.0.13 - remaining task is the wincontrol "ReadDirectoryChanges", which uses ATL, propably not available with mingw Closes notepad-plus-plus#2478 * Japanese translation update * update translations to v7.1 * correct indent Closes notepad-plus-plus#2436 * Update Ukrainian translation Closes notepad-plus-plus#2414 * Update catalan.xml Update to v7.0 Closes notepad-plus-plus#2412 * Fix Encoding radio button issue in New Document Sync UTF-8 checkbox with UTF-8 radio button Closes notepad-plus-plus#2377 * cmake config update - added usable cmake config file by transferring files structure from visual studio project file - contains also basic support for mingw make file creation - see https://ci.appveyor.com/project/chcg/notepad-plus-plus/build/1.0.38 for successful with own appveyor config Closes notepad-plus-plus#2477 * Update translations * Notepad++ release 7.2 * Expand environment variables in backup path Fixes notepad-plus-plus#2520, Fixes notepad-plus-plus#2525 * Improve Javascript readability
SinghRajenM
added a commit
to SinghRajenM/notepad-plus-plus
that referenced
this pull request
Nov 11, 2016
* Update german.xml to version 7.0 - 14.10.16 including last updates following english.xml from 14.10.2016 Closes notepad-plus-plus#2423 * Update translations * Update farsi.xml to 7.1 * Update slovenian.xml to v7.1 * Notepad++ 7.1 release * Updated hindi.xml Closes notepad-plus-plus#2375 * Update config.model.xml * config.xml is generated by notepad++ No more config.model.xml. config.xml is generated by notepad++ directly. * Add SmartHighLight node for config.xml generation * Fixed disable smart highlihgt inconsistent behaviour This bug can be reproduce by turning off smart highlight then restart Notepad++ : some smart highlight options are still enabled. Fixes notepad-plus-plus#2442, closes notepad-plus-plus#2465 * Add .profile, .bash_profile, and .bashrc extensions. * Ensure backup directory exists Failed backups result in a user error message and asks to save the file anyways. Closes notepad-plus-plus#2346, Closes notepad-plus-plus#2441 * Add smart highlighting extension to anothe view option Add new option to enable smat highlighting extension to anothe view, while both views are visible side by side. * Fix a regression of double click on several zones of status bar. * Fix a tab settings regression Tab settings per language broken due to the entries are doubled by error during the preferences dialog reorganization. * Fix uninstaller silent mode issue Remove also unecessary files * Fix Installer for 64-bit fails with argument "/D" * Change styler to make makefile more readable Closes notepad-plus-plus#2482 * MinGW GCC update - changes necessary to get back a buildable version with mingw, last adapted with notepad-plus-plus#1229 - fixed some gcc compiler errors and warnings, see https://ci.appveyor.com/project/chcg/notepad-plus-plus/build/1.0.3 to https://ci.appveyor.com/project/chcg/notepad-plus-plus/build/1.0.13 - remaining task is the wincontrol "ReadDirectoryChanges", which uses ATL, propably not available with mingw Closes notepad-plus-plus#2478 * Japanese translation update * update translations to v7.1 * correct indent Closes notepad-plus-plus#2436 * Update Ukrainian translation Closes notepad-plus-plus#2414 * Update catalan.xml Update to v7.0 Closes notepad-plus-plus#2412 * Fix Encoding radio button issue in New Document Sync UTF-8 checkbox with UTF-8 radio button Closes notepad-plus-plus#2377 * cmake config update - added usable cmake config file by transferring files structure from visual studio project file - contains also basic support for mingw make file creation - see https://ci.appveyor.com/project/chcg/notepad-plus-plus/build/1.0.38 for successful with own appveyor config Closes notepad-plus-plus#2477 * Update translations * Notepad++ release 7.2 * Expand environment variables in backup path Fixes notepad-plus-plus#2520, Fixes notepad-plus-plus#2525 * Improved Run Macro dialog UI. 1. Radio button and edit box were overlapped 2. Edit box and comboxed were not vertically aligned.
SinghRajenM
added a commit
to SinghRajenM/notepad-plus-plus
that referenced
this pull request
Nov 11, 2016
* Update german.xml to version 7.0 - 14.10.16 including last updates following english.xml from 14.10.2016 Closes notepad-plus-plus#2423 * Update translations * Update farsi.xml to 7.1 * Update slovenian.xml to v7.1 * Notepad++ 7.1 release * Updated hindi.xml Closes notepad-plus-plus#2375 * Update config.model.xml * config.xml is generated by notepad++ No more config.model.xml. config.xml is generated by notepad++ directly. * Add SmartHighLight node for config.xml generation * Fixed disable smart highlihgt inconsistent behaviour This bug can be reproduce by turning off smart highlight then restart Notepad++ : some smart highlight options are still enabled. Fixes notepad-plus-plus#2442, closes notepad-plus-plus#2465 * Add .profile, .bash_profile, and .bashrc extensions. * Ensure backup directory exists Failed backups result in a user error message and asks to save the file anyways. Closes notepad-plus-plus#2346, Closes notepad-plus-plus#2441 * Add smart highlighting extension to anothe view option Add new option to enable smat highlighting extension to anothe view, while both views are visible side by side. * Fix a regression of double click on several zones of status bar. * Fix a tab settings regression Tab settings per language broken due to the entries are doubled by error during the preferences dialog reorganization. * Fix uninstaller silent mode issue Remove also unecessary files * Fix Installer for 64-bit fails with argument "/D" * Change styler to make makefile more readable Closes notepad-plus-plus#2482 * MinGW GCC update - changes necessary to get back a buildable version with mingw, last adapted with notepad-plus-plus#1229 - fixed some gcc compiler errors and warnings, see https://ci.appveyor.com/project/chcg/notepad-plus-plus/build/1.0.3 to https://ci.appveyor.com/project/chcg/notepad-plus-plus/build/1.0.13 - remaining task is the wincontrol "ReadDirectoryChanges", which uses ATL, propably not available with mingw Closes notepad-plus-plus#2478 * Japanese translation update * update translations to v7.1 * correct indent Closes notepad-plus-plus#2436 * Update Ukrainian translation Closes notepad-plus-plus#2414 * Update catalan.xml Update to v7.0 Closes notepad-plus-plus#2412 * Fix Encoding radio button issue in New Document Sync UTF-8 checkbox with UTF-8 radio button Closes notepad-plus-plus#2377 * cmake config update - added usable cmake config file by transferring files structure from visual studio project file - contains also basic support for mingw make file creation - see https://ci.appveyor.com/project/chcg/notepad-plus-plus/build/1.0.38 for successful with own appveyor config Closes notepad-plus-plus#2477 * Update translations * Notepad++ release 7.2 * Expand environment variables in backup path Fixes notepad-plus-plus#2520, Fixes notepad-plus-plus#2525 * Update readme.txt * Improve Javascript string readability Fixes notepad-plus-plus#1543, closes notepad-plus-plus#2550 * Small tune on Run Macro dialog UI. 1. Radio button and edit box were overlapped 2. Edit box and comboxed were not vertically aligned. Closes notepad-plus-plus#2549 * Remove 32bit shell dll from 64bit installer Closes notepad-plus-plus#2408
PalashBansal
pushed a commit
to PalashBansal/notepad-plus-plus
that referenced
this pull request
Dec 3, 2016
anil-shrestha
pushed a commit
to anil-shrestha/notepad-plus-plus
that referenced
this pull request
Dec 7, 2016
iczelia
pushed a commit
to iczelia/notepad-plus-plus
that referenced
this pull request
Jan 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2520