Skip to content

Improve Javascript readability#2550

Closed
SinghRajenM wants to merge 1 commit intonotepad-plus-plus:masterfrom
SinghRajenM:JavaScript_readability
Closed

Improve Javascript readability#2550
SinghRajenM wants to merge 1 commit intonotepad-plus-plus:masterfrom
SinghRajenM:JavaScript_readability

Conversation

@SinghRajenM
Copy link
Copy Markdown
Contributor

@dail8859
Copy link
Copy Markdown
Contributor

dail8859 commented Nov 8, 2016

Related issue #1543

@donho donho added the accepted label Nov 11, 2016
@donho donho added this to the 7.x (master) milestone Nov 11, 2016
@donho donho self-assigned this Nov 11, 2016
@donho donho closed this in bc38c74 Nov 11, 2016
@SinghRajenM SinghRajenM deleted the JavaScript_readability branch November 11, 2016 18:14
@SinghRajenM SinghRajenM restored the JavaScript_readability branch November 11, 2016 18:24
@SinghRajenM SinghRajenM deleted the JavaScript_readability branch November 11, 2016 18:26
SinghRajenM added a commit to SinghRajenM/notepad-plus-plus that referenced this pull request Nov 11, 2016
* Update german.xml to version 7.0 - 14.10.16

including last updates following english.xml from 14.10.2016

Closes notepad-plus-plus#2423

* Update translations

* Update farsi.xml to 7.1

* Update slovenian.xml to v7.1

* Notepad++ 7.1 release

* Updated hindi.xml

Closes notepad-plus-plus#2375

* Update config.model.xml

* config.xml is generated by notepad++

No more config.model.xml. config.xml is generated by notepad++ directly.

* Add SmartHighLight node for config.xml generation

* Fixed disable smart highlihgt inconsistent behaviour

This bug can be reproduce by turning off smart highlight then restart
Notepad++ : some smart highlight options are still enabled.

Fixes notepad-plus-plus#2442, closes notepad-plus-plus#2465

* Add .profile, .bash_profile, and .bashrc extensions.

* Ensure backup directory exists

Failed backups result in a user error message and asks to save the file anyways. Closes notepad-plus-plus#2346, Closes notepad-plus-plus#2441

* Add smart highlighting extension to anothe view option

Add new option to enable smat highlighting extension to anothe view,
while both views are visible side by side.

* Fix a regression of double click on several zones of status bar.

* Fix a tab settings regression

Tab settings per language broken due to the entries are doubled by error
during the preferences dialog reorganization.

* Fix uninstaller silent mode issue

Remove also unecessary files

* Fix Installer for 64-bit fails with argument "/D"

* Change styler to make makefile more readable

Closes notepad-plus-plus#2482

* MinGW GCC update

- changes necessary to get back a buildable version with mingw, last adapted with notepad-plus-plus#1229
- fixed some gcc compiler errors and warnings, see https://ci.appveyor.com/project/chcg/notepad-plus-plus/build/1.0.3 to https://ci.appveyor.com/project/chcg/notepad-plus-plus/build/1.0.13
- remaining task is the wincontrol "ReadDirectoryChanges", which uses ATL, propably not available with mingw
Closes notepad-plus-plus#2478

* Japanese translation update

* update translations to v7.1
* correct indent
Closes notepad-plus-plus#2436

* Update Ukrainian translation

Closes notepad-plus-plus#2414

* Update catalan.xml

Update to v7.0

Closes notepad-plus-plus#2412

* Fix Encoding radio button issue in New Document

Sync UTF-8 checkbox with UTF-8 radio button

Closes notepad-plus-plus#2377

* cmake config update

- added usable cmake config file by transferring files structure from visual studio project file
- contains also basic support for mingw make file creation
- see https://ci.appveyor.com/project/chcg/notepad-plus-plus/build/1.0.38 for successful with own appveyor config

Closes notepad-plus-plus#2477

* Update translations

* Notepad++ release 7.2

* Expand environment variables in backup path

Fixes notepad-plus-plus#2520, Fixes notepad-plus-plus#2525

* Update readme.txt

* Improve Javascript string readability

Fixes notepad-plus-plus#1543, closes notepad-plus-plus#2550

* Small tune on Run Macro dialog UI.

1. Radio button and edit box were overlapped
2. Edit box and comboxed were not vertically aligned.

Closes notepad-plus-plus#2549

* Remove 32bit shell dll from 64bit installer

Closes notepad-plus-plus#2408
@swiftSwathSee
Copy link
Copy Markdown

Still needs improvement. The background color C0C0C0 is currently the same as the highlight color (on Windows, at least). I suggest changing it to the slightly lighter color E9E9E9.

In my opinion, it should just be orange text against a white background (like Python does with its ''' strings). The background for all other strings is white, so this one shouldn't be any different. Or instead of orange text, just make it the same as every other JavaScript string: grey text.

PalashBansal pushed a commit to PalashBansal/notepad-plus-plus that referenced this pull request Dec 3, 2016
anil-shrestha pushed a commit to anil-shrestha/notepad-plus-plus that referenced this pull request Dec 7, 2016
iczelia pushed a commit to iczelia/notepad-plus-plus that referenced this pull request Jan 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants