Skip to content

Correct page title for Uint8Array.prototype.setFromHex()#39494

Merged
Josh-Cena merged 1 commit intomdn:mainfrom
dontwanttothink:main
May 13, 2025
Merged

Correct page title for Uint8Array.prototype.setFromHex()#39494
Josh-Cena merged 1 commit intomdn:mainfrom
dontwanttothink:main

Conversation

@dontwanttothink
Copy link
Copy Markdown
Contributor

Description

It looks like Uint8Array.prototype.setFromHex() is correct here instead of Uint8Array.setFromHex(). This is an instance method.

Motivation

If the title is incorrect, it can be confusing.

Additional details

Related issues and pull requests

@dontwanttothink dontwanttothink requested a review from a team as a code owner May 13, 2025 01:26
@dontwanttothink dontwanttothink requested review from Josh-Cena and removed request for a team May 13, 2025 01:26
@github-actions github-actions bot added Content:JS JavaScript docs size/xs [PR only] 0-5 LoC changed labels May 13, 2025
Copy link
Copy Markdown
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, great catch, thanks :D

@github-actions
Copy link
Copy Markdown
Contributor

@Josh-Cena Josh-Cena merged commit 2b4f6d0 into mdn:main May 13, 2025
7 checks passed
wbamberg added a commit to wbamberg/content that referenced this pull request May 21, 2025
* upstream/main: (40 commits)
  Add a guide on xs-leaks (mdn#38977)
  chore: Link to child pages in SVG, URI section (mdn#39470)
  Correct page title for `Uint8Array.prototype.setFromHex()` (mdn#39494)
  Bump markdownlint-cli2 from 0.17.2 to 0.18.0 (mdn#39488)
  Add more documentation for sizes=auto (mdn#39464)
  css(fix): update 'shape()' page (mdn#39454)
  Expand Compression Dictionary format description (mdn#39441)
  Add username/password section to URLs guide (mdn#39487)
  Fix typos (mdn#39481)
  CSS: mask-position property description (mdn#39449)
  Adding @starting-style to CSS nesting at-rules (mdn#39473)
  feat(aria): Add short titles, format titles for roles (mdn#39472)
  Fix Circle Collision detection algorithm (mdn#39484)
  Add warning against using element IDs as global properties. (mdn#39422)
  Fix typos in web audio spatialization basics (mdn#39476)
  More Error Messages (mdn#39419)
  Add links to CSS sidebar (mdn#39445)
  css: add 'stretch' value examples (mdn#39451)
  chore: link to unlinked child pages (mdn#39469)
  Fix typos (mdn#39465)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Content:JS JavaScript docs size/xs [PR only] 0-5 LoC changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants