Conversation
|
Preview URLs (comment last updated: 2025-05-10 02:28:57) |
chrisdavidmills
left a comment
There was a problem hiding this comment.
Thanks @OnkarRuikar, this is looking pretty good!
My only comment is that, in .shape2 in the second example, the first shape looks a bit messy. It should surely be symmetrical?
|
the example is giving me text ("Your browser doesn't support the |
@chrisdavidmills I tried to make it a heart. Now I've made it symmetrical.
@estelle try nightly or dev builds of Chrome. Or try Safari on ipad. |
chrisdavidmills
left a comment
There was a problem hiding this comment.
@OnkarRuikar Cool, the heart looks good.
I'm seeing support for the second demo in Chrome 136, Edge 136, but not Firefox Nightly.
I'm seeing support for the first demo in Chrome Canary 138 only (Chrome/Edge 136 give me the not supported message, and Firefox kind of supports it but it doesn't work properly)
So I think the content update is fine, but the BCD needs some followup work.
|
@chrisdavidmills it's a bit complicated. There are two things to consider: |
You are right, but the trouble is that the |
|
I don't think this blocks the merge, BTW. I'm happy to merge as-is. |
Yes, let's add the note in BCD. Raised an issue there: mdn/browser-compat-data#26756 |
Shape() is supported for clip-path but not offset path in Edge. We should likely updated the generated content to say that. |
|
I was working on a heart: in case you want to use it. (https://codepen.io/estelle/pen/PwwdrbR) |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* upstream/main: (40 commits) Add a guide on xs-leaks (mdn#38977) chore: Link to child pages in SVG, URI section (mdn#39470) Correct page title for `Uint8Array.prototype.setFromHex()` (mdn#39494) Bump markdownlint-cli2 from 0.17.2 to 0.18.0 (mdn#39488) Add more documentation for sizes=auto (mdn#39464) css(fix): update 'shape()' page (mdn#39454) Expand Compression Dictionary format description (mdn#39441) Add username/password section to URLs guide (mdn#39487) Fix typos (mdn#39481) CSS: mask-position property description (mdn#39449) Adding @starting-style to CSS nesting at-rules (mdn#39473) feat(aria): Add short titles, format titles for roles (mdn#39472) Fix Circle Collision detection algorithm (mdn#39484) Add warning against using element IDs as global properties. (mdn#39422) Fix typos in web audio spatialization basics (mdn#39476) More Error Messages (mdn#39419) Add links to CSS sidebar (mdn#39445) css: add 'stretch' value examples (mdn#39451) chore: link to unlinked child pages (mdn#39469) Fix typos (mdn#39465) ...
The PR updates
via->withand160px 1px 20% 16px->160px 1px / 20% 16px. The examples have also been updated.Test this on Chrome or Safari. Firefox hasn't released the feature yet.