Skip to content

Fix Circle Collision detection algorithm#39484

Merged
Josh-Cena merged 5 commits intomdn:mainfrom
ragul1697:patch-4
May 12, 2025
Merged

Fix Circle Collision detection algorithm#39484
Josh-Cena merged 5 commits intomdn:mainfrom
ragul1697:patch-4

Conversation

@ragul1697
Copy link
Copy Markdown
Contributor

Fixes #39483 - Reverted the Circle Collision detection by adding its radius.

@ragul1697 ragul1697 requested a review from a team as a code owner May 12, 2025 10:25
@ragul1697 ragul1697 requested review from hamishwillee and removed request for a team May 12, 2025 10:25
@github-actions github-actions bot added Content:Games Games docs size/s [PR only] 6-50 LoC changed labels May 12, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 12, 2025

Preview URLs

(comment last updated: 2025-05-12 11:16:56)

ragul1697 added 2 commits May 12, 2025 16:03
Added changes for PR suggestions
Copy link
Copy Markdown
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

@Josh-Cena Josh-Cena merged commit 33e22d8 into mdn:main May 12, 2025
8 checks passed
wbamberg added a commit to wbamberg/content that referenced this pull request May 21, 2025
* upstream/main: (40 commits)
  Add a guide on xs-leaks (mdn#38977)
  chore: Link to child pages in SVG, URI section (mdn#39470)
  Correct page title for `Uint8Array.prototype.setFromHex()` (mdn#39494)
  Bump markdownlint-cli2 from 0.17.2 to 0.18.0 (mdn#39488)
  Add more documentation for sizes=auto (mdn#39464)
  css(fix): update 'shape()' page (mdn#39454)
  Expand Compression Dictionary format description (mdn#39441)
  Add username/password section to URLs guide (mdn#39487)
  Fix typos (mdn#39481)
  CSS: mask-position property description (mdn#39449)
  Adding @starting-style to CSS nesting at-rules (mdn#39473)
  feat(aria): Add short titles, format titles for roles (mdn#39472)
  Fix Circle Collision detection algorithm (mdn#39484)
  Add warning against using element IDs as global properties. (mdn#39422)
  Fix typos in web audio spatialization basics (mdn#39476)
  More Error Messages (mdn#39419)
  Add links to CSS sidebar (mdn#39445)
  css: add 'stretch' value examples (mdn#39451)
  chore: link to unlinked child pages (mdn#39469)
  Fix typos (mdn#39465)
  ...
@ragul1697 ragul1697 deleted the patch-4 branch September 10, 2025 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Content:Games Games docs size/s [PR only] 6-50 LoC changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2D collision detection - Circle Collision looks incorrect

3 participants