Merged
Conversation
bsmth
reviewed
May 9, 2025
bsmth
reviewed
May 9, 2025
bsmth
reviewed
May 9, 2025
bsmth
reviewed
May 9, 2025
bsmth
reviewed
May 9, 2025
Member
|
Super! Thank you very much. I think there's only one change I feel we should check and that's https://github.com/mdn/content/pull/39445/files#r2081301414 for Every other comment about listSubPages is a suggestion, so I'm happy to hear what you think. |
Contributor
|
Preview URLs (comment last updated: 2025-05-09 14:15:48) |
Contributor
Author
|
Thanks a lot @bsmth for reviewing. Using auto alpha sorting where possible is a great suggestion. This is ready for you to take another look |
bsmth
approved these changes
May 9, 2025
Member
bsmth
left a comment
There was a problem hiding this comment.
Super, everything looks good, thank you!
wbamberg
added a commit
to wbamberg/content
that referenced
this pull request
May 21, 2025
* upstream/main: (40 commits) Add a guide on xs-leaks (mdn#38977) chore: Link to child pages in SVG, URI section (mdn#39470) Correct page title for `Uint8Array.prototype.setFromHex()` (mdn#39494) Bump markdownlint-cli2 from 0.17.2 to 0.18.0 (mdn#39488) Add more documentation for sizes=auto (mdn#39464) css(fix): update 'shape()' page (mdn#39454) Expand Compression Dictionary format description (mdn#39441) Add username/password section to URLs guide (mdn#39487) Fix typos (mdn#39481) CSS: mask-position property description (mdn#39449) Adding @starting-style to CSS nesting at-rules (mdn#39473) feat(aria): Add short titles, format titles for roles (mdn#39472) Fix Circle Collision detection algorithm (mdn#39484) Add warning against using element IDs as global properties. (mdn#39422) Fix typos in web audio spatialization basics (mdn#39476) More Error Messages (mdn#39419) Add links to CSS sidebar (mdn#39445) css: add 'stretch' value examples (mdn#39451) chore: link to unlinked child pages (mdn#39469) Fix typos (mdn#39465) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a few existing landing pages to the sidebar that are not currently discoverable.
A broader CSS area reorganization is coming soon, but this improvement doesn't need to be delayed for that.
Motivation
To improve the discoverability of the landing pages we already have.
Additional details
We're currently lacking the functionality in the sidebar to do the following:
"At-rules" in the sidebar currently only shows the top-level items.
I've tried using
depth: 2and addingcss-at-rule-descriptortotags, but the expected child folders (e.g., for@counter-style) don't show up.And we don't want the
listSubPagesGroupedfunctionality here."Properties" in the sidebar (and same applies to pseudo-classes and pseudo-elements) are of type
listSubPagesGrouped.As a result, we see
-moz-*and-webkit-*groups but we don't have a handle on these top-level group items to link them to their respective landing pages. (Firefox (-moz-) vendor-prefixed CSS extensions and WebKit (-webkit-) vendor-prefixed CSS extensions).